UBIFS memleak ?

PATCH Matthieu CASTET 2 participants 2 messages Jul 13, 2010 – Jul 18, 2010

Subsystems (2)

Memory technology devices (MTD) UBI file system (UBIFS)

lore

Share & tools

lore

Matthieu CASTET

author

2010-07-13 09:21 UTC #0 lore raw

Hi,

in mount_ubifs shouldn't we do something like that in case of ubifs_leb_unmap error ?

Matthieu

fs/ubifs/super.c +1 -1

index 4d2f215..9362f16 100644
@@ -1318,7 +1318,7 @@ static int mount_ubifs(struct ubifs_info *c)
 			 */
 			err = ubifs_leb_unmap(c, c->gc_lnum);
 			if (err)
-				return err;
+				goto out_orphans;
 		}
 
 		err = dbg_check_lprops(c);

Artem Bityutskiy

2010-07-18 08:53 UTC #1 lore raw

Quoted 4 lines · Matthieu CASTET

Hi,
in mount_ubifs shouldn't we do something like that in case of ubifs_leb_unmap error ?

Yes, are you going to send a proper patch with signed-off-by?

Signature · 2 lines

Best Regards,
Artem Bityutskiy (Артём Битюцкий)