Skip to contentSkip to conversation

trivial: clear the comment on parameters for ext2_xattr_set

PATCH In review Wang Sheng-Hui 2 participants 2 messages Jul 13, 2010

Subsystems (2)
Kernel janitors ext2 file system
lore
Share & tools
lore

Wang Sheng-Hui

author
#0 lore raw

PATCH 1/1 trivial: clear the comment on parameters for ext2_xattr_set

Hi,

The comment for ext2_xattr_get is confusing for it has no parameter named "buffer". I checked the code and think the description is suitable for the parameter "value". Following patch is against 2.6.35-rc5. Please check it.

Signed-off-by Wang Sheng-Hui <[email protected]>

---
fs/ext2/xattr.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
fs/ext2/xattr.c +0 -0
index 5ecbbd8..f56b599 100644
@@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct

super_block *sb)
/*
* ext2_xattr_set()
*
- * Create, replace or remove an extended attribute for this inode. Buffer
+ * Create, replace or remove an extended attribute for this inode. Value
* is NULL to remove an existing extended attribute, and non-NULL to
* either replace an existing extended attribute, or create a new extended
* attribute. The flags XATTR_REPLACE and XATTR_CREATE

Signature · 6 lines
1.7.1.1


-- 
Thanks and Regards,
shenghui
#1 lore raw

fs/ext2/xattr.c static void ext2_xattr_update_super_block(struct · line 360

Quoted 12 lines · Wang Sheng-Hui
fs/ext2/xattr.c +1 -1
index 5ecbbd8..f56b599 100644
@@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct
 super_block *sb)
 /*
 * ext2_xattr_set()
 *
- * Create, replace or remove an extended attribute for this inode. Buffer
+ * Create, replace or remove an extended attribute for this inode. Value
 * is NULL to remove an existing extended attribute, and non-NULL to

It is talking about the "value" parameter, but your email client mangled this patch so it doesn't apply.

regards,
dan carpenter