Skip to contentSkip to conversation

Remove 9 second reboot delay on Lenovo T400/T500

PATCH Matthew Garrett 6 participants 15 messages Jul 14, 2010 – Jul 23, 2010 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 9 lines · Pedro Ribeiro

Please consider this patch. Let me know if you would like me to change anything or if you don't agree with it. It applies cleanly to 2.6.35-rc5.

The Lenovo T400 and T500 have an annoying 9 second delay when rebooting, unless reboot=pci is passed to the kernel command line. This delay happens from at least kernel 2.6.20.

Make this change permanent by hardcoding the Tx00 on the arch/kernel/reboot.c pci quirks table.

There's two possibilities here:

1) Lenovo's firmware is broken and the 9-second delay is always going to be there. In that case we should try to use the ACPI reboot vector first.

2) We're doing something wrong in our shutdown sequence which then triggers this problem as a result.

Either way, I think this patch is wrong.

Signature · 1 line
Matthew Garrett | [email protected]
#2 lore raw
Quoted 17 lines · Matthew Garrett
Quoted 9 lines · Pedro Ribeiro

 Please consider this patch. Let me know if you would like me to change anything or if you don't agree with it. It applies cleanly to 2.6.35-rc5.

 The Lenovo T400 and T500 have an annoying 9 second delay when rebooting, unless reboot=pci is passed to the kernel command line. This delay happens from at least kernel 2.6.20.

 Make this change permanent by hardcoding the Tx00 on the arch/kernel/reboot.c pci quirks table.

There's two possibilities here:

1) Lenovo's firmware is broken and the 9-second delay is always going to be there. In that case we should try to use the ACPI reboot vector first.

Quoted 8 lines

2) We're doing something wrong in our shutdown sequence which then triggers this problem as a result.

Either way, I think this patch is wrong.

--
Matthew Garrett | [email protected]

Hi Matthew,

by acpi reboot vector you mean using reboot=acpi?
I tried it and does not solve the problem.
Check here http://marc.info/?l=linux-kernel&m=127590255224570&w=2

Can you please tell me how to debug this?

Thanks,
Pedro

#3 lore raw
In reply to Matthew Garrett
Quoted 4 lines · Matthew Garrett
Quoted 3 lines · Pedro Ribeiro

The Lenovo T400 and T500 have an annoying 9 second delay when rebooting, unless reboot=pci is passed to the kernel command line. This delay happens from at least kernel 2.6.20.

[...]

Quoted 3 lines

1) Lenovo's firmware is broken and the 9-second delay is always going to be there. In that case we should try to use the ACPI reboot vector first.

While it may be true that the firmware is buggy, reboot=acpi does not solve the problem; reboot=pci does.

Signature · 1 line
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
#4 lore raw
In reply to Matthew Garrett
Quoted 5 lines · Matthew Garrett

There's two possibilities here:

1) Lenovo's firmware is broken and the 9-second delay is always going to be there. In that case we should try to use the ACPI reboot vector first.

Or maybe we should key into whatever OSI() the ACPI firmware asked, and try first whatever shutdown path the highest version of Windows asked for by the firmware would.

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#5 lore raw
Quoted 3 lines · Henrique de Moraes Holschuh

Or maybe we should key into whatever OSI() the ACPI firmware asked, and try first whatever shutdown path the highest version of Windows asked for by the firmware would.

I've been tracing how Windows implements reboots (XP, Vista and 7). It appears to use the ACPI reboot vector, the keyboard controller, the ACPI reboot vector again, the keyboard controller again and then hangs. I'll try implementing equivalent behaviour in Linux and see whether it makes any difference.

Signature · 1 line
Matthew Garrett | [email protected]
#6 lore raw
Quoted 10 lines · Matthew Garrett
Quoted 3 lines · Henrique de Moraes Holschuh

Or maybe we should key into whatever OSI() the ACPI firmware asked, and try first whatever shutdown path the highest version of Windows asked for by the firmware would.

I've been tracing how Windows implements reboots (XP, Vista and 7). It appears to use the ACPI reboot vector, the keyboard controller, the ACPI reboot vector again, the keyboard controller again and then hangs. I'll try implementing equivalent behaviour in Linux and see whether it makes any difference.

Icky. It doesn't happen always, but this time it does looks like we will NOT be better off doing whatever Windows is doing.

Do you want to escalate this to Lenovo? I need a clear and consise description of the problem and the boxes we know to be affected.

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#7 lore raw
Quoted 2 lines · Henrique de Moraes Holschuh

Do you want to escalate this to Lenovo? I need a clear and consise description of the problem and the boxes we know to be affected.

Well, right now we're not doing precisely what Windows does. The other possibility is that when the keyboard controller write triggers some SMM code, it makes an assumption about some piece of hardware state that isn't true and loops for a while to see if it changes. If we knew what that was then we could ensure that we're performing the same state change on our way down to reboot.

One thing that would be worth checking is whether performing the keyboard controller writes from userspace with a minimal kernel and init=/bin/bash shows the 9-second pause or not - and then, ideally, see whether the same is also true under DOS.

Signature · 1 line
Matthew Garrett | [email protected]
#8 lore raw
Quoted 11 lines · Matthew Garrett
Quoted 2 lines · Henrique de Moraes Holschuh

Do you want to escalate this to Lenovo? I need a clear and consise description of the problem and the boxes we know to be affected.

Well, right now we're not doing precisely what Windows does. The other possibility is that when the keyboard controller write triggers some SMM code, it makes an assumption about some piece of hardware state that isn't true and loops for a while to see if it changes. If we knew what that was then we could ensure that we're performing the same state change on our way down to reboot.

Quoted 4 lines

One thing that would be worth checking is whether performing the keyboard controller writes from userspace with a minimal kernel and init=/bin/bash shows the 9-second pause or not - and then, ideally, see whether the same is also true under DOS.

I can't help much there, as the only hardware I have is a ThinkPad T43.

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#14 lore raw
In reply to a message not in the archive

Am 14.07.2010 16:33 schrieb Pedro Ribeiro:

Quoted 9 lines

Please consider this patch. Let me know if you would like me to change anything or if you don't agree with it. It applies cleanly to 2.6.35-rc5.

The Lenovo T400 and T500 have an annoying 9 second delay when rebooting, unless reboot=pci is passed to the kernel command line. This delay happens from at least kernel 2.6.20.

Make this change permanent by hardcoding the Tx00 on the arch/kernel/reboot.c pci quirks table.

Hi,

I just want to add to this discussion that this problem also occurs on my T61 with only Linux installed on it. "reboot=pci" also removed the reboot delay here.

If you need some further information or want me to try some patches / old kernels I'd be glad to help.

Regards,
Jens

#13 lore raw
In reply to Matthew Garrett
Quoted 12 lines · Matthew Garrett
Quoted 2 lines · Henrique de Moraes Holschuh

Do you want to escalate this to Lenovo?  I need a clear and consise description of the problem and the boxes we know to be affected.

Well, right now we're not doing precisely what Windows does. The other possibility is that when the keyboard controller write triggers some SMM code, it makes an assumption about some piece of hardware state that isn't true and loops for a while to see if it changes. If we knew what that was then we could ensure that we're performing the same state change on our way down to reboot.

Quoted 8 lines

One thing that would be worth checking is whether performing the keyboard controller writes from userspace with a minimal kernel and init=/bin/bash shows the 9-second pause or not - and then, ideally, see whether the same is also true under DOS.

--
Matthew Garrett | [email protected]

I'm available to try and test whatever you want on my machine .

Regards,
Pedro

#15 lore raw
In reply to Jens Rutschmann
Quoted 13 lines · On Fri, 16 Jul 2010 09:38:54 +0200 Jens Rutschmann <[email protected]>…

Am 14.07.2010 16:33 schrieb Pedro Ribeiro:

Quoted 9 lines

Please consider this patch. Let me know if you would like me to change anything or if you don't agree with it. It applies cleanly to 2.6.35-rc5.

The Lenovo T400 and T500 have an annoying 9 second delay when rebooting, unless reboot=pci is passed to the kernel command line. This delay happens from at least kernel 2.6.20.

Make this change permanent by hardcoding the Tx00 on the arch/kernel/reboot.c pci quirks table.

Hi,

Quoted 8 lines

I just want to add to this discussion that this problem also occurs on my T61 with only Linux installed on it. "reboot=pci" also removed the reboot delay here.

If you need some further information or want me to try some patches / old kernels I'd be glad to help.

Regards,
Jens

Hi!

Just a quick me too: I'm on Lenovo R61. reboot=pci gives instantaneous reboot, reboot=acpi and default-reboot delays for 9 seconds...

Cheers,
Flo

#10 lore raw
In reply to Matthew Garrett
Quoted 5 lines · Matthew Garrett

1) The ACPI reboot vector reboots these machines instantly, but the flag that indicates we should use it isn't set.
2) Windows takes 9 seconds to reboot on the same hardware.

It just sounds like broken firmware.

I'm confused. Is it the PCI reboot vector, or the ACPI reboot vector that acts instantly? The bug reporters say that they use reboot=pci to have instant reboot, in this thread...

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#11 lore raw
Quoted 3 lines · Henrique de Moraes Holschuh

I'm confused. Is it the PCI reboot vector, or the ACPI reboot vector that acts instantly? The bug reporters say that they use reboot=pci to have instant reboot, in this thread...

The PCI one, since it's a function of the chipset. The ACPI one would act instantly (it's the PCI one, in this case) but it's marked as unsupported. However, the PCI one is poorly standardised - Windows never uses it, different chips have subtly different requirements and so on.

Signature · 1 line
Matthew Garrett | [email protected]
#12 lore raw
Quoted 6 lines · Matthew Garrett
Quoted 3 lines · Henrique de Moraes Holschuh

I'm confused.  Is it the PCI reboot vector, or the ACPI reboot vector that acts instantly?  The bug reporters say that they use reboot=pci to have instant reboot, in this thread...

Quoted 8 lines

The PCI one, since it's a function of the chipset. The ACPI one would act instantly (it's the PCI one, in this case) but it's marked as unsupported. However, the PCI one is poorly standardised - Windows never uses it, different chips have subtly different requirements and so on.

--
Matthew Garrett | [email protected]

So what should be done then? This is not the most annoying of bugs, but still a bug.

Regards,
Pedro