Skip to contentSkip to conversation

Bugzilla # 16395: Regression in 2.6.35-rc4 since commit 0b28bac5aef7bd1ab213723df031e61db9ff151a on HP Mini 110 Netbook

PATCH Larry Finger 2 participants 4 messages Jul 14, 2010 – Jul 15, 2010 Input drivers

lore
Share & tools
lore
#0 lore raw

Since the commit in the title, a kernel built on an HP Mini 110 Netbook no
longer has keyboard input. The main difference is that CONFIG_SERIO_I8042 is no longer defined. When this equal yes, the keyboard works. The faulty commit was located by bisection and has been verified by reverting the patch.

Further investigation shows that the faulty hunk is

drivers/input/serio/Kconfig +1 -1
index 3bfe8fa..256b9e9 100644
@@ -22,7 +22,7 @@ config SERIO_I8042
        tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
        default y
        depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \
-                  (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN
+                  (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !X86_MRST
        help
          i8042 is the chip over which the standard AT keyboard and PS/2
          mouse are connected to the computer. If you use these devices,

Reverting this one hunk alone results in a working system. Obviously, this Netbook does not have X86_MRST set.

maintainer
#1 lore raw
Quoted 22 lines · Larry Finger

Since the commit in the title, a kernel built on an HP Mini 110 Netbook no longer has keyboard input. The main difference is that CONFIG_SERIO_I8042 is no longer defined. When this equal yes, the keyboard works. The faulty commit was located by bisection and has been verified by reverting the patch.

Further investigation shows that the faulty hunk is

drivers/input/serio/Kconfig +1 -1
index 3bfe8fa..256b9e9 100644
@@ -22,7 +22,7 @@ config SERIO_I8042
         tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
         default y
         depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \
-                  (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN
+                  (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN &&

!X86_MRST help
i8042 is the chip over which the standard AT keyboard and PS/2 mouse are connected to the computer. If you use these devices,

Quoted 2 lines

Reverting this one hunk alone results in a working system. Obviously, this Netbook does not have X86_MRST set.

You meant to say "does have CONFIG_X86_MRST set", right?

Thanks.

Signature · 1 line
Dmitry
#2 lore raw
Quoted 23 lines · Dmitry Torokhov
Quoted 22 lines · Larry Finger

Since the commit in the title, a kernel built on an HP Mini 110 Netbook no longer has keyboard input. The main difference is that CONFIG_SERIO_I8042 is no longer defined. When this equal yes, the keyboard works. The faulty commit was located by bisection and has been verified by reverting the patch.

Further investigation shows that the faulty hunk is

drivers/input/serio/Kconfig +1 -1
index 3bfe8fa..256b9e9 100644
@@ -22,7 +22,7 @@ config SERIO_I8042
          tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
          default y
          depends on !PARISC&&  (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST)&&  \
-                  (!SUPERH || SH_CAYMAN)&&  !M68K&&  !BLACKFIN
+                  (!SUPERH || SH_CYes, AYMAN)&&  !M68K&&  !BLACKFIN&&

!X86_MRST help
i8042 is the chip over which the standard AT keyboard and PS/2 mouse are connected to the computer. If you use these devices,

Quoted 5 lines
Quoted 2 lines

Reverting this one hunk alone results in a working system. Obviously, this Netbook does not have X86_MRST set.

You meant to say "does have CONFIG_X86_MRST set", right?

Yes. I got lost in the negative logic. Since !X86_MRST is false, then X86_MRST has to be defined. In fact, .config has CONFIG_X86_MRST=y.

Larry

maintainer
#3 lore raw
Quoted 30 lines · Larry Finger
Quoted 23 lines · Dmitry Torokhov
Quoted 22 lines · Larry Finger

Since the commit in the title, a kernel built on an HP Mini 110 Netbook no longer has keyboard input. The main difference is that CONFIG_SERIO_I8042 is no longer defined. When this equal yes, the keyboard works. The faulty commit was located by bisection and has been verified by reverting the patch.

Further investigation shows that the faulty hunk is

drivers/input/serio/Kconfig +1 -1
index 3bfe8fa..256b9e9 100644
@@ -22,7 +22,7 @@ config SERIO_I8042
         tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
         default y
         depends on !PARISC&&  (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST)&&  \
-                  (!SUPERH || SH_CAYMAN)&&  !M68K&&  !BLACKFIN
+                  (!SUPERH || SH_CYes, AYMAN)&&  !M68K&&  !BLACKFIN&&

!X86_MRST help
i8042 is the chip over which the standard AT keyboard and PS/2 mouse are connected to the computer. If you use these devices,

Quoted 5 lines
Quoted 2 lines

Reverting this one hunk alone results in a working system. Obviously, this Netbook does not have X86_MRST set.

You meant to say "does have CONFIG_X86_MRST set", right?

Quoted 4 lines

Yes. I got lost in the negative logic. Since !X86_MRST is false, then X86_MRST has to be defined. In fact, .config has CONFIG_X86_MRST=y.

Good. HPA posted a patch series that should fix the problem, in the mean time just disable Moorestown support - you do not need it anyway.

Signature · 1 line
Dmitry