ARM/nuc900: fix nuc900 touchscreen clk definition bug
Subsystems (2)
PATCH 1/1 ARM/nuc900: fix nuc900 touchscreen clk definition bug
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's name should be 'nuc900-ts', it should be the same to pdev.name. or else, the touchscreen driver will be not working well due to clock engine disabled.
--- arch/arm/mach-w90x900/cpu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-w90x900/cpu.c +1 -1
@@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {DEF_CLKLOOK (&clk_kpi,"nuc900-kpi" ,NULL ),DEF_CLKLOOK (&clk_wdt,"nuc900-wdt" ,NULL ),DEF_CLKLOOK (&clk_gdma,"nuc900-gdma" ,NULL ), -DEF_CLKLOOK (&clk_adc,"nuc900-adc" ,NULL ), +DEF_CLKLOOK (&clk_adc,"nuc900-ts" ,NULL ),DEF_CLKLOOK (&clk_usi,"nuc900-spi" ,NULL ),DEF_CLKLOOK (&clk_ext,NULL ,"ext" ), DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
Signature · 1 line
1.6.3.3
Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
Quoted 15 lines
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's name should be 'nuc900-ts', it should be the same to pdev.name. or else, the touchscreen driver will be not working well due to clock engine disabled.
Signed-off-by Wan ZongShun <[email protected]>--- arch/arm/mach-w90x900/cpu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-w90x900/cpu.c +0
-0
arch/arm/mach-w90x900/cpu.c static struct clk_lookup nuc900_clkregs[] = { · line 99
Quoted 8 lines
arch/arm/mach-w90x900/cpu.c +1
-1@@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {DEF_CLKLOOK (&clk_kpi,"nuc900-kpi" ,NULL ),DEF_CLKLOOK (&clk_wdt,"nuc900-wdt" ,NULL ),DEF_CLKLOOK (&clk_gdma,"nuc900-gdma" ,NULL ), -DEF_CLKLOOK (&clk_adc,"nuc900-adc" ,NULL ), +DEF_CLKLOOK (&clk_adc,"nuc900-ts" ,NULL ),DEF_CLKLOOK (&clk_usi,"nuc900-spi" ,NULL ),DEF_CLKLOOK (&clk_ext,NULL ,"ext" ), DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
Hey,
Is that thing really touchscreen or general-purpose analog/digital converter ?
Cheers
2010/7/16 Marek Vasut <[email protected]>:
Quoted 27 lines
Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
Quoted 15 lines
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's name should be 'nuc900-ts', it should be the same to pdev.name. or else, the touchscreen driver will be not working well due to clock engine disabled.
Signed-off-by Wan ZongShun <[email protected]>---
?arch/arm/mach-w90x900/cpu.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-w90x900/cpu.c +0
-0arch/arm/mach-w90x900/cpu.c static struct clk_lookup nuc900_clkregs[] = { · line 99
Quoted 8 lines
arch/arm/mach-w90x900/cpu.c +1
-1@@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = { ? ? ? DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL), ? ? ? DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL), ? ? ? DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL), - ? ? DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL), + ? ? DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL), ? ? ? DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL), ? ? ? DEF_CLKLOOK(&clk_ext, NULL, "ext"), ? ? ? DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),Hey,
Quoted 2 lines
Is that thing really touchscreen or general-purpose analog/digital converter ?
Oh, it is general-purpose analog/digital converter controller. I only use it to implemnt my touchscreen function, Also it can be use other function.
so, I have to change my touchscreen driver name to nuc900-adc?
Thanks for your Reminder, I appreciate it. :)
Quoted 2 lines
Cheers
Signature · 10 lines
*linux-arm-kernel mailing list mail addr:linux-arm-kernel at lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900 at googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com at gmail.com
Dne P? 16. ?ervence 2010 07:34:21 Wan ZongShun napsal(a):
Quoted 28 lines
2010/7/16 Marek Vasut <[email protected]>:
Quoted 27 lines
Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
Quoted 15 lines
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's name should be 'nuc900-ts', it should be the same to pdev.name. or else, the touchscreen driver will be not working well due to clock engine disabled.
Signed-off-by Wan ZongShun <[email protected]>--- arch/arm/mach-w90x900/cpu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-w90x900/cpu.c +0
-0arch/arm/mach-w90x900/cpu.c static struct clk_lookup nuc900_clkregs[] = { · line 99
Quoted 8 lines
arch/arm/mach-w90x900/cpu.c +1
-1@@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {DEF_CLKLOOK (&clk_kpi,"nuc900-kpi" ,NULL ),DEF_CLKLOOK (&clk_wdt,"nuc900-wdt" ,NULL ),DEF_CLKLOOK (&clk_gdma,"nuc900-gdma" ,NULL ), -DEF_CLKLOOK (&clk_adc,"nuc900-adc" ,NULL ), +DEF_CLKLOOK (&clk_adc,"nuc900-ts" ,NULL ),DEF_CLKLOOK (&clk_usi,"nuc900-spi" ,NULL ),DEF_CLKLOOK (&clk_ext,NULL ,"ext" ), DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),Hey,
Quoted 8 lines
Quoted 2 lines
Is that thing really touchscreen or general-purpose analog/digital converter ?
Oh, it is general-purpose analog/digital converter controller. I only use it to implemnt my touchscreen function, Also it can be use other function.
so, I have to change my touchscreen driver name to nuc900-adc?
No, just change the name of clock in the touchscreen driver. So that the touchscreen driver will use nuc900-adc clocksource.
You're welcome. :)
Quoted 4 lines
Thanks for your Reminder, I appreciate it. :)
Quoted 1 line
Cheers
2010/7/16 Marek Vasut <[email protected]>:
Quoted 32 lines
Dne P? 16. ?ervence 2010 07:34:21 Wan ZongShun napsal(a):
Quoted 31 lines
2010/7/16 Marek Vasut <[email protected]>:
Quoted 29 lines
Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
Quoted 15 lines
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's name should be 'nuc900-ts', it should be the same to pdev.name. or else, the touchscreen driver will be not working well due to clock engine disabled.
Signed-off-by Wan ZongShun <[email protected]>---
?arch/arm/mach-w90x900/cpu.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/mach-w90x900/cpu.c +0
-0arch/arm/mach-w90x900/cpu.c static struct clk_lookup nuc900_clkregs[] = { · line 99
Quoted 8 lines
arch/arm/mach-w90x900/cpu.c +1
-1@@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = { ? ? ? DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL), ? ? ? DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL), ? ? ? DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL), - ? ? DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL), + ? ? DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL), ? ? ? DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL), ? ? ? DEF_CLKLOOK(&clk_ext, NULL, "ext"), ? ? ? DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),Hey,
Is that thing really touchscreen or general-purpose analog/digital converter ?
Quoted 8 lines
Quoted 5 lines
Oh, it is general-purpose analog/digital converter controller. I only use it to implemnt my touchscreen function, Also it can be use other function.
so, I have to change my touchscreen driver name to nuc900-adc?
No, just change the name of clock in the touchscreen driver. So that the touchscreen driver will use nuc900-adc clocksource.
But the clk_get() identifies this clk via looking driver or pdev name. so I must change my touchscreen driver name, right?
Quoted 8 lines
You're welcome. :)
Quoted 4 lines
Thanks for your Reminder, I appreciate it. :)
Quoted 1 line
Cheers
Signature · 10 lines
*linux-arm-kernel mailing list mail addr:linux-arm-kernel at lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900 at googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com at gmail.com
Quoted 3 lines · Wan ZongShun
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's name should be 'nuc900-ts', it should be the same to pdev.name. or else, the touchscreen driver will be not working well due to clock engine disabled.
Ok.