ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
PATCH 1/1 ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
This patch modify some code which register a DAI with ASoC core according to modified registration API of DAI.
--- sound/soc/s3c24xx/aquila_wm8994.c | 3 +-- sound/soc/s3c24xx/s3c-i2s-v2.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
sound/soc/s3c24xx/aquila_wm8994.c +1 -2
@@ -268,8 +268,7 @@ static int __init aquila_init(void)return -ENOMEM ;/* register voice DAI here */ - ret =snd_soc_register_dai (&aquila_snd_device->dev, -0 , &voice_dai); + ret =snd_soc_register_dai (&aquila_snd_device->dev, &voice_dai);if (ret)return ret;
sound/soc/s3c24xx/s3c-i2s-v2.c +1 -1
@@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id, drv->suspend = s3c2412_i2s_suspend; drv->resume = s3c2412_i2s_resume; -return snd_soc_register_dai (dev, id, drv); +return snd_soc_register_dai (dev, drv); }EXPORT_SYMBOL_GPL (s3c_i2sv2_register_dai);
Signature · 1 line
1.6.3.3
Hi,
Quoted 29 lines · Chanwoo Choi
This patch modify some code which register a DAI with ASoC core according to modified registration API of DAI.
Signed-off-by Chanwoo Choi <[email protected]>Signed-off-by Kyungmin Park <[email protected]>---
sound/soc/s3c24xx/aquila_wm8994.c | 3 +--
sound/soc/s3c24xx/s3c-i2s-v2.c | 2 +-2 files changed, 2 insertions(+), 3 deletions(-)sound/soc/s3c24xx/aquila_wm8994.c +1
-2@@ -268,8 +268,7 @@ static int __init aquila_init(void) return -ENOMEM; /* register voice DAI here */ - ret = snd_soc_register_dai(&aquila_snd_device->dev, - 0, &voice_dai); + ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai); if (ret) return ret;sound/soc/s3c24xx/s3c-i2s-v2.c +0
-0
sound/soc/s3c24xx/s3c-i2s-v2.c int s3c_i2sv2_register_dai(struct device *dev, int id, · line 753
Quoted 5 lines
sound/soc/s3c24xx/s3c-i2s-v2.c +1
-1@@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id, drv->suspend = s3c2412_i2s_suspend; drv->resume = s3c2412_i2s_resume; - return snd_soc_register_dai(dev, id, drv); + return snd_soc_register_dai(dev, drv);
How about s3c64xx-i2s? I think, if this patch fixes all errors in 'sound/soc/s3c24xx',
It'll be more nice than this.
Quoted 11 lines
sound/soc/s3c24xx/s3c-i2s-v2.c +0
-1} EXPORT_SYMBOL_GPL(s3c_i2sv2_register_dai); --1.6.3.3
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 35 lines · Seungwhan Youn
Hi,
Quoted 32 lines · Chanwoo Choi
This patch modify some code which register a DAI with ASoC core according to modified registration API of DAI.
Signed-off-by Chanwoo Choi <[email protected]>Signed-off-by Kyungmin Park <[email protected]>--- sound/soc/s3c24xx/aquila_wm8994.c | 3 +-- sound/soc/s3c24xx/s3c-i2s-v2.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)sound/soc/s3c24xx/aquila_wm8994.c +1
-2@@ -268,8 +268,7 @@ static int __init aquila_init(void)return -ENOMEM ;/* register voice DAI here */ - ret =snd_soc_register_dai (&aquila_snd_device->dev, -0 , &voice_dai); + ret =snd_soc_register_dai (&aquila_snd_device->dev, &voice_dai);if (ret)return ret;sound/soc/s3c24xx/s3c-i2s-v2.c +0
-0@@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id, drv->suspend = s3c2412_i2s_suspend; drv->resume = s3c2412_i2s_resume;
Quoted 4 lines
sound/soc/s3c24xx/s3c-i2s-v2.c int s3c_i2sv2_register_dai(struct device *dev, int id, · line 753
Quoted 2 lines
sound/soc/s3c24xx/s3c-i2s-v2.c +1
-1-return snd_soc_register_dai (dev, id, drv); +return snd_soc_register_dai (dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?
Quoted 2 lines
'
sound/soc/s3c24xx',
It'll be more nice than this.
Quoted 36 lines · Chanwoo Choi
Quoted 35 lines · Seungwhan Youn
Hi,
Quoted 32 lines · Chanwoo Choi
This patch modify some code which register a DAI with ASoC core according to modified registration API of DAI.
Signed-off-by Chanwoo Choi <[email protected]>Signed-off-by Kyungmin Park <[email protected]>---
sound/soc/s3c24xx/aquila_wm8994.c | 3 +--
sound/soc/s3c24xx/s3c-i2s-v2.c | 2 +-2 files changed, 2 insertions(+), 3 deletions(-)sound/soc/s3c24xx/aquila_wm8994.c +1
-2@@ -268,8 +268,7 @@ static int __init aquila_init(void) return -ENOMEM; /* register voice DAI here */ - ret = snd_soc_register_dai(&aquila_snd_device->dev, - 0, &voice_dai); + ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai); if (ret) return ret;sound/soc/s3c24xx/s3c-i2s-v2.c +0
-0@@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id, drv->suspend = s3c2412_i2s_suspend; drv->resume = s3c2412_i2s_resume;
Quoted 6 lines
Quoted 4 lines
sound/soc/s3c24xx/s3c-i2s-v2.c int s3c_i2sv2_register_dai(struct device *dev, int id, · line 753
Quoted 2 lines
sound/soc/s3c24xx/s3c-i2s-v2.c +1
-1- return snd_soc_register_dai(dev, id, drv); + return snd_soc_register_dai(dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?
Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
Quoted 7 lines
Quoted 3 lines
'
sound/soc/s3c24xx',
It'll be more nice than this.
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
+ return
snd_soc_register_dai(dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?Actually '
sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
Quoted 8 lines
Quoted 2 lines
So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in '
sound/soc/s3c24xx/'.The '
sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 'snd_soc_register_dai()' function.
It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' to register a DAI.
Oh, I was confused about this even I modify this few days ago. I'm sorry that I make you to be confused.
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
'
sound/soc/s3c24xx',
It'll be more nice than this.
Thanks,
claude
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 40 lines · Seungwhan Youn
Quoted 39 lines · Chanwoo Choi
Quoted 38 lines · Seungwhan Youn
Hi,
Quoted 29 lines · Chanwoo Choi
This patch modify some code which register a DAI with ASoC core according to modified registration API of DAI.
Signed-off-by Chanwoo Choi <[email protected]>Signed-off-by Kyungmin Park <[email protected]>--- sound/soc/s3c24xx/aquila_wm8994.c | 3 +-- sound/soc/s3c24xx/s3c-i2s-v2.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)sound/soc/s3c24xx/aquila_wm8994.c +1
-2@@ -268,8 +268,7 @@ static int __init aquila_init(void)return -ENOMEM ;/* register voice DAI here */ - ret =snd_soc_register_dai (&aquila_snd_device->dev, -0 , &voice_dai); + ret =snd_soc_register_dai (&aquila_snd_device->dev, &voice_dai);if (ret)return ret;sound/soc/s3c24xx/s3c-i2s-v2.c +0
-0sound/soc/s3c24xx/s3c-i2s-v2.c int s3c_i2sv2_register_dai(struct device *dev, int id, · line 753
Quoted 5 lines
sound/soc/s3c24xx/s3c-i2s-v2.c +1
-1@@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id, drv->suspend = s3c2412_i2s_suspend; drv->resume = s3c2412_i2s_resume; -return snd_soc_register_dai (dev, id, drv); +return snd_soc_register_dai (dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Quoted 7 lines
Quoted 2 lines
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?Actually '
sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in '
sound/soc/s3c24xx/'.
The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 'snd_soc_register_dai()' function.
It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' to register a DAI.
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
'
sound/soc/s3c24xx',
It'll be more nice than this.
Quoted 10 lines · Seungwhan Youn
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
+ return
snd_soc_register_dai(dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?Actually '
sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in '
sound/soc/s3c24xx/'.
Quoted 9 lines
Quoted 5 lines
The '
sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 'snd_soc_register_dai()' function.
It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' to register a DAI.Oh, I was confused about this even I modify this few days ago. I'm sorry that I make you to be confused.
I'm confused too ;)
Is this to be applied or not ?
Liam
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
Quoted 17 lines · Liam Girdwood
Quoted 16 lines · Seungwhan Youn
Quoted 15 lines
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
+ return
snd_soc_register_dai(dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?Actually '
sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in '
sound/soc/s3c24xx/'.The '
sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 'snd_soc_register_dai()' function.
It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' to register a DAI.
Quoted 7 lines
Quoted 3 lines
Oh, I was confused about this even I modify this few days ago. I'm sorry that I make you to be confused.
I'm confused too ;)
Is this to be applied or not ?
I think this okay. :)
Quoted 8 lines
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 5 lines · Chanwoo Choi
This patch modify some code which register a DAI with ASoC core according to modified registration API of DAI.
Signed-off-by Chanwoo Choi <[email protected]>Signed-off-by Kyungmin Park <[email protected]>
Quoted 22 lines · Seungwhan Youn
Quoted 21 lines · Liam Girdwood
Quoted 19 lines · Seungwhan Youn
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
+ return
snd_soc_register_dai(dev, drv);How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?Actually '
sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.Quoted 8 lines
Quoted 2 lines
So, If this patch's purpose is to fix compile error, my opinion is that this patch fix all the same errors in '
sound/soc/s3c24xx/'.The '
sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 'snd_soc_register_dai()' function.
It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' to register a DAI.Oh, I was confused about this even I modify this few days ago. I'm sorry that I make you to be confused.
Quoted 6 lines
Quoted 3 lines
I'm confused too ;)
Is this to be applied or not ?
I think this okay. :)
All applied.
Thanks
Liam
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk