Skip to contentSkip to conversation

KVM: MMU: fix hugepage mapping corrupt caused by regression

PATCH Applied Xiao Guangrong 2 participants 2 messages Jul 23, 2010 – Jul 25, 2010

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Xiao Guangrong

author
#0 lore raw

PATCH 1/1 KVM: MMU: fix hugepage mapping corrupt caused by regression

This is the regression, the bug which is fixed by commit e09e90a5 is active now

Signed-off-by Xiao Guangrong <[email protected]>
---
 arch/x86/kvm/paging_tmpl.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kvm/paging_tmpl.h +2 -2
index a09e04c..d9a2742 100644
@@ -374,13 +374,13 @@ static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr,
 	     shadow_walk_next(&it)) {
 		gfn_t direct_gfn;
 
+		validate_direct_spte(vcpu, it.sptep, direct_access);
+
 		drop_large_spte(vcpu, it.sptep);
 
 		if (is_shadow_present_pte(*it.sptep))
 			continue;
 
-		validate_direct_spte(vcpu, it.sptep, direct_access);
-
 		direct_gfn = gw->gfn & ~(KVM_PAGES_PER_HPAGE(it.level) - 1);
 
 		sp = kvm_mmu_get_page(vcpu, direct_gfn, addr, it.level-1,
Signature · 1 line
1.6.1.2
Applied
#1 lore raw
Quoted 3 lines · Xiao Guangrong

This is the regression, the bug which is fixed by commit e09e90a5 is active now

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function