correct handling of return values
Quoted 8 lines
I'm currently working on this task:
http://kernelnewbies.org/KernelJanitors/Todo/ReturnCodesI think this task can be partly done with coccinelle. The most often cases of invalid handling is no handling :)
I am not guru of coccinelle, but I think it is very useful here. So, I've written basic script of finding common errors, but it is not ideal.
Were any improvements achieved since my request "Detection of ignored function return values" that will help in this use case?
http://lists.diku.dk/pipermail/cocci/2010-February/000690.html
http://www.mail-archive.com/[email protected]/msg00157.html
Regards,
Markus
Quoted 6 lines · SF Markus Elfring
Quoted 6 lines
I'm currently working on this task:
http://kernelnewbies.org/KernelJanitors/Todo/ReturnCodesI think this task can be partly done with coccinelle. The most often cases of invalid handling is no handling :)
Quoted 7 lines
Quoted 2 lines
I am not guru of coccinelle, but I think it is very useful here. So, I've written basic script of finding common errors, but it is not ideal.
Were any improvements achieved since my request "Detection of ignored function return values" that will help in this use case?
http://lists.diku.dk/pipermail/cocci/2010-February/000690.html
http://www.mail-archive.com/[email protected]/msg00157.html
Looking back at that disucssion, it sees that the main issue was whether one would know the return type of a function. If the function is not local, one can know that from the prototype. One then runs into the problem that prototypes are often in header files, and Coccinelle takes into account at most the header files that are mentioned in the file explicitly. Nothing has changed in that regard.
If you care only about bug finding, but not automatic bug fixing, a possibility is to run CPP first. There is some support for doing this, but I don't remember what it is. Nicolas Palix should know, however.
julia
Hi,
Quoted 23 lines · On Thursday 29 July 2010 10:56:21 Julia Lawall wrote:
Quoted 6 lines · SF Markus Elfring
Quoted 6 lines
I'm currently working on this task:
http://kernelnewbies.org/KernelJanitors/Todo/ReturnCodesI think this task can be partly done with coccinelle. The most often cases of invalid handling is no handling :)
Quoted 7 lines
Quoted 2 lines
I am not guru of coccinelle, but I think it is very useful here. So, I've written basic script of finding common errors, but it is not ideal.
Were any improvements achieved since my request "Detection of ignored function return values" that will help in this use case?
http://lists.diku.dk/pipermail/cocci/2010-February/000690.html
http://www.mail-archive.com/[email protected]/msg00157.htmlLooking back at that disucssion, it sees that the main issue was whether one would know the return type of a function. If the function is not local, one can know that from the prototype. One then runs into the problem that prototypes are often in header files, and Coccinelle takes into account at most the header files that are mentioned in the file explicitly. Nothing has changed in that regard.
Quoted 3 lines
If you care only about bug finding, but not automatic bug fixing, a possibility is to run CPP first. There is some support for doing this, but I don't remember what it is. Nicolas Palix should know, however.
It is with the spp tool. See tools/spp.ml and demos/spp in the source distribution.
I added some information in the wiki.
http://cocci.ekstranet.diku.dk/wiki/doku.php?id=using_cpp
Quoted 8 lines
julia
_______________________________________________
Cocci mailing list
[email protected]
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)
Signature · 4 lines
Nicolas Palix Tel: (+33) 1 44 27 87 25 Tel: (+33) 6 81 07 91 72 Web: http://www.diku.dk/~npalix/