Skip to contentSkip to conversation

pid namespace isolation broken with powertop

DISCUSSION Daniel Lezcano 3 participants 4 messages Jul 29, 2010 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Hi all,

I noticed all the tasks of the host are listed in /proc/timer_stats These information is not virtualized neither isolated within a container.

I was expecting to see only the tasks in the container with the corresponding pids.

I am not sure this is something critical, but the usage of powertop in the container shows all the tasks of the system.

While looking at the code in kernel/time/timer.c, it is not obvious to fix this isolation because it is the pid number which is stored in a list, so there is not enough informations to discriminate the pid namespace against the current one.

I am wondering if:

1) is it worth to isolate these informations ? (IMHO, yes).
2) should the stats be stored per pid namespace or adding an hash
value + pid namespace as a key in the timer stats list ?

Thanks
-- Daniel

#2 lore raw
In reply to a message not in the archive
Quoted 16 lines · Daniel Lezcano

Hi all,

I noticed all the tasks of the host are listed in /proc/timer_stats These information is not virtualized neither isolated within a container.

I was expecting to see only the tasks in the container with the corresponding pids.

I am not sure this is something critical, but the usage of powertop in the container shows all the tasks of the system.

While looking at the code in kernel/time/timer.c, it is not obvious to fix this isolation because it is the pid number which is stored in a list, so there is not enough informations to discriminate the pid namespace against the current one.

Quoted 5 lines

I am wondering if:

1) is it worth to isolate these informations ? (IMHO, yes).
2) should the stats be stored per pid namespace or adding an hash
value + pid namespace as a key in the timer stats list ?

Well, powertop is used for monitoring and modifying global system characteristics (e.g. processor C states, USB autosuspend) that don't make sense to virtualize. Many events in /proc/timer_stats are accocunted to pid 0 (swapper/idle). I think the question is whether a pidns-relative slice of timer events will be useful or just confusing.

#3 lore raw
Quoted 24 lines · Nathan Lynch
Quoted 16 lines · Daniel Lezcano

Hi all,

I noticed all the tasks of the host are listed in /proc/timer_stats These information is not virtualized neither isolated within a container.

I was expecting to see only the tasks in the container with the corresponding pids.

I am not sure this is something critical, but the usage of powertop in the container shows all the tasks of the system.

While looking at the code in kernel/time/timer.c, it is not obvious to fix this isolation because it is the pid number which is stored in a list, so there is not enough informations to discriminate the pid namespace against the current one.

Quoted 6 lines

I am wondering if:

1) is it worth to isolate these informations ? (IMHO, yes).
2) should the stats be stored per pid namespace or adding an hash
value + pid namespace as a key in the timer stats list ?

Quoted 6 lines

Well, powertop is used for monitoring and modifying global system characteristics (e.g. processor C states, USB autosuspend) that don't make sense to virtualize. Many events in /proc/timer_stats are accocunted to pid 0 (swapper/idle). I think the question is whether a pidns-relative slice of timer events will be useful or just confusing.

IMHO I find confusing to see all the applications name/pid running on the whole system (host + containers) from a container. Even if these applications are not accessible, that gives informations to the container on what is running on the system and I think we should consider that as a security breach.

We can just "hide" the content of this file for a pid namespace different of the init pid namespace, but that may suppress the possibility to investigate with powertop the consumption of a specific appliance, as accurate as it could be...

Thanks
-- Daniel

#5 lore raw
In reply to a message not in the archive
Quoted 39 lines · Daniel Lezcano
Quoted 6 lines · Nathan Lynch
Quoted 4 lines · Daniel Lezcano

Hi all,

I noticed all the tasks of the host are listed in /proc/timer_stats These information is not virtualized neither isolated within a

container.

Quoted 18 lines
Quoted 12 lines

I was expecting to see only the tasks in the container with the corresponding pids.

I am not sure this is something critical, but the usage of powertop in the container shows all the tasks of the system.

While looking at the code in kernel/time/timer.c, it is not obvious to fix this isolation because it is the pid number which is stored in a list, so there is not enough informations to discriminate the pid namespace against the current one.

Quoted 6 lines

I am wondering if:

1) is it worth to isolate these informations ? (IMHO, yes).
2) should the stats be stored per pid namespace or adding an hash
value + pid namespace as a key in the timer stats list ?

Quoted 6 lines

Well, powertop is used for monitoring and modifying global system characteristics (e.g. processor C states, USB autosuspend) that don't make sense to virtualize. Many events in /proc/timer_stats are accocunted to pid 0 (swapper/idle). I think the question is whether a pidns-relative slice of timer events will be useful or just confusing.

IMHO I find confusing to see all the applications name/pid running on the whole system (host + containers) from a container. Even if these applications are not accessible, that gives informations to the container on what is running on the system and I think we should consider that as a security breach.

Quoted 5 lines

We can just "hide" the content of this file for a pid namespace different of the init pid namespace, but that may suppress the possibility to investigate with powertop the consumption of a specific appliance, as accurate as it could be...

Hi Daniel, I wouldn't worry too much about powertop

http://www.phoronix.com/scan.php?page=article&item=powertop_2010_test&num=1

br.

Signature · 1 line
Marc