blktrace: blktrace documentation update
PATCH 4/6 blktrace: blktrace documentation update
Signature · 4 lines
-- Edward O. Shishkin Principal Software Engineer Red Hat Czech
Fixup for 595620.
Document undocumented blktrace options.
Update the man pages.
---
blktrace.c +19 -3
@@ -435,9 +435,24 @@ } }; -static char usage_str[] = \ -"-d <dev> [ -r debugfs path ] [ -o <output> ] [-k ] [ -w time ]\n" \ -"[ -a action ] [ -A action mask ] [ -I <devs file> ] [ -v ]\n\n" \ +static char usage_str[] ="\n\n" \ +"-d <dev> | --dev=<dev>\n" \ +"[ -r <debugfs path> | --relay=<debugfs path> ]\n" \ +"[ -o <file> | --output=<file>]\n" \ +"[ -D <dir> | --output-dir=<dir>\n" \ +"[ -w <time> | --stopwatch=<time>]\n" \ +"[ -a <action field> | --act-mask=<action field>]\n" \ +"[ -A <action mask> | --set-mask=<action mask>]\n" \ +"[ -b <size> | --buffer-size]\n" \ +"[ -n <number> | --num-sub-buffers=<number>]\n" \ +"[ -l | --listen]\n" \ +"[ -h <hostname> | --host=<hostname>]\n" \ +"[ -p <port number> | --port=<port number>]\n" \ +"[ -s | --no-sendfile]\n" \ +"[ -I <devs file> | --input-devs=<devs file>]\n" \ +"[ -v <version> | --version]\n" \ +"[ -V <version> | --version]\n" \ +"\t-d Use specified device. May also be given last after options\n" \"\t-r Path to mounted debugfs, defaults to /sys/kernel/debug\n" \"\t-o File(s) to send output to\n" \
@@ -452,6 +467,7 @@"\t-p Network port to use (default 8462)\n" \"\t-s Make the network client NOT use sendfile() to transfer data\n" \"\t-I Add devices found in <devs file>\n" \ +"\t-v Print program version info\n" \"\t-V Print program version info\n\n" ;static void clear_events (struct pollfd *pfd)
doc/blktrace.8 +50 -6
82 lines not on this page · raw message
Quoted 1 line · Edward Shishkin
I do believe you are missing:
'k' / 'kill'
'w' / 'stopwatch'
for this patch, could you add those and resend?
Thanks,
Alan
Quoted 9 lines · Alan D. Brunelle
Quoted 1 line · Edward Shishkin
I do believe you are missing:
'k' / 'kill'
'w' / 'stopwatch'for this patch, could you add those and resend?
Actually, just add in the 'w' / 'stopwatch' one - I see that you had previously removed the documentation for 'k' in commit
fb7f86674a516ddff0d60bfab3bd284a4812075f
Quoted 8 lines · Alan D. Brunelle
Quoted 1 line · Edward Shishkin
I do believe you are missing:
'k' / 'kill'
'w' / 'stopwatch'
Quoted 9 lines
for this patch, could you add those and resend?
Thanks,
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-btrace" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Oh, and your patch does have the 'w' 'stopwatch' in it (missed it during review). <sigh>
(Although that "approval" doesn't mean much after I messed up so bad with the review... ;-) )
Quoted 19 lines · Alan D. Brunelle
Quoted 5 lines · Alan D. Brunelle
Quoted 1 line · Edward Shishkin
I do believe you are missing:
Quoted 13 lines
'k' / 'kill'
'w' / 'stopwatch'for this patch, could you add those and resend?
Thanks,
AlanSignature · 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-btrace" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines
Oh, and your patch does have the 'w' 'stopwatch' in it (missed it during review). <sigh>
Acked-by Alan D. Brunelle <[email protected]>(Although that "approval" doesn't mean much after I messed up so bad with the review... ;-) )
Hello Alan.
Thanks for review.
Edward.