rt_sigprocmask01 issue

PATCH In review lina.zhao 2 participants 2 messages Aug 12, 2010 – Aug 13, 2010

lore

Share & tools

lore

lina.zhao

author

2010-08-12 08:16 UTC #0 lore raw

PATCH 1/1 rt_sigprocmask01 issue

Hi,

In rt_sigprocmask01.c:

TEST(syscall(__NR_rt_sigpending, &oset,

                  SIGSETSIZE));
              if (TEST_RETURN == -1) {
                  tst_brkm(TFAIL|TTERRNO, cleanup,
                      "rt_sigpending call failed");
              }
              TEST(sigismember(&oset, TEST_SIG));
              if (TEST_RETURN == 0) {
                  tst_brkm(TFAIL|TTERRNO,
                      cleanup,
                      "sigismember call failed");
              }
              /* call rt_sigprocmask() to unblock
               * signal#TEST_SIG */
              TEST(syscall(__NR_rt_sigprocmask,
                  SIG_UNBLOCK, &set, &oset, 8));

on most of the arch,the SIGSETSIZE is 8, but it is 16 for mips, so in sigprocmask, the last parameter should be SIGSETSIZE too, not 8.

Regards,

Lina Zhao

From 69be40baa594c10e5de553a2a60ba4875680c68c Mon Sep 17 00:00:00 2001
From: Lina Zhao <[email protected]>
Date: Thu, 12 Aug 2010 15:45:10 +0800
Subject: [PATCH] On most of the arch,the SIGSETSIZE is 8,
but it is 16 for mips, so in sigprocmask, the last parameter should be SIGSETSIZE too, not 8.

Signed-off-by Lina Zhao <[email protected]>

---
 .../syscalls/rt_sigprocmask/rt_sigprocmask01.c     |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c +1 -1

index cc32ea8..e100561 100644
@@ -210,7 +210,7 @@ int main(int ac, char **av) {
 				/* call rt_sigprocmask() to unblock
 				 * signal#TEST_SIG */
 				TEST(syscall(__NR_rt_sigprocmask,
-					SIG_UNBLOCK, &set, &oset, 8));
+					SIG_UNBLOCK, &set, &oset, SIGSETSIZE));
 				if (TEST_RETURN == -1) {
 					tst_brkm(TFAIL|TTERRNO,
 						cleanup,

Signature · 1 line

1.6.3.1

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2010-08-13 06:14 UTC #1 lore raw

Quoted 21 lines · lina.zhao

Hi,
In rt_sigprocmask01.c:
TEST(syscall(__NR_rt_sigpending, &oset, SIGSETSIZE));
if (TEST_RETURN == -1) { tst_brkm(TFAIL|TTERRNO, cleanup, "rt_sigpending call failed"); }
TEST(sigismember(&oset, TEST_SIG)); if (TEST_RETURN == 0) { tst_brkm(TFAIL|TTERRNO, cleanup,
"sigismember call failed"); }
/* call rt_sigprocmask() to unblock
* signal#TEST_SIG */ TEST(syscall(__NR_rt_sigprocmask, SIG_UNBLOCK, &set, &oset, 8));

Quoted 3 lines

on most of the arch,the SIGSETSIZE is 8, but it is 16 for mips, so in sigprocmask,
the last parameter should be SIGSETSIZE too, not 8.

Committed. Please provide a signed-off-by line next time. Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list