Skip to contentSkip to conversation

mlx4_fc: Enable FC over Ethernet/Infiniband drivers

PATCH In review Vu Pham 2 participants 4 messages Aug 16, 2010 – Aug 18, 2010 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Vu Pham

author
#0 lore raw

PATCH 10/10 mlx4_fc: Enable FC over Ethernet/Infiniband drivers

Quoted 1 line

From 17b0c5412e085e1f288c05cb667ec36e4a05c59b Mon Sep 17 00:00:00 2001

From: Vu Pham <vu-OnC3O1emZK9LiOotz6YBiwC/[email protected]>
Date: Mon, 16 Aug 2010 14:48:01 -0700
Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

Add entries in scsi's Kconfig and Makefile to enable mlx4_fc (fcoe/fcoib offload driver) and mlx4_fcoib (FIP-alike discovery driver)

---
 drivers/scsi/Kconfig  |   22 ++++++++++++++++++++++
 drivers/scsi/Makefile |    2 ++
 2 files changed, 24 insertions(+), 0 deletions(-)
drivers/scsi/Kconfig +22 -0
index 158284f..3573cee 100644
@@ -687,6 +687,28 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	depends on MLX4_EN
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+	  The module will be called mlx4_fc
+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module FIP-alike to discover BridgeX gateways in the
+	  Infiniband fabric
+	  The module will be called mlx4_fc
+
 config SCSI_DMX3191D
 	tristate "DMX3191D SCSI support"
 	depends on PCI && SCSI
drivers/scsi/Makefile +2 -0
index 2a3fca2..0d0dab7 100644
@@ -40,6 +40,8 @@ obj-$(CONFIG_LIBFC)		+= libfc/
 obj-$(CONFIG_LIBFCOE)		+= fcoe/
 obj-$(CONFIG_FCOE)		+= fcoe/
 obj-$(CONFIG_FCOE_FNIC)		+= fnic/
+obj-$(CONFIG_MLX4_FC)		+= mlx4_fc/
+obj-$(CONFIG_MLX4_FCOIB)	+= mlx4_fc/
 obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
 obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
 obj-$(CONFIG_SCSI_A4000T)	+= 53c700.o	a4000t.o
Signature · 1 line
1.6.3.3

_______________________________________________
ewg mailing list [email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

#1 lore raw
Quoted 1 line · On Mon, 16 Aug 2010 15:17:05 -0700 Vu Pham wrote:

{hm, no text to reply to; oh, the patch is an attachment; please don't do that}

(copy-paste here:)

drivers/scsi/Kconfig +3 -0
index 158284f..3573cee 100644
@@ -687,6 +687,28 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	depends on MLX4_EN
 

depends on
+ select LIBFC
+ select LIBFCOE
+ help
+ Fibre Channel over Ethernet/Infiniband module
+
+ This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+ The module will be called mlx4_fc

End both lines above with periods (".").

+
+config MLX4_FCOIB
+ tristate "Mellanox FCoIB discovery module"
+ depends on INFINIBAND
+ select MLX4_FC
+ help
+ Fibre Channel over Infiniband discovery module
+
+ The module FIP-alike to discover BridgeX gateways in the
+ Infiniband fabric

end sentence with ".".

What does "FIP-alike" mean? and fix grammar:

This module attempts to discover BridgeX gateways in the Infiniband fabric.
?

+ The module will be called mlx4_fc
+

end sentence with ".".

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

A message that is not in the archive (sent off-list or not yet received): 20100816165137.d006efd0.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org

author
#3 lore raw
Quoted 18 lines

depends on

(quoted diff) +7 -0
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+	  The module will be called mlx4_fc

End both lines above with periods (".").

(quoted diff) +3 -0
+
+	  The module FIP-alike to discover BridgeX gateways in the
+	  Infiniband fabric

end sentence with ".".

Quoted 8 lines

What does "FIP-alike" mean? and fix grammar:

This module attempts to discover BridgeX gateways in the Infiniband fabric.
?

end sentence with ".".

Thanks for you comments.

Quoted 1 line

From 54041f56fa1896388a52f503e43e21aa11cc9a2a Mon Sep 17 00:00:00 2001

From: Vu Pham <vu-OnC3O1emZK9LiOotz6YBiwC/[email protected]>
Date: Tue, 17 Aug 2010 15:40:42 -0700
Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

Add entries in scsi's Kconfig and Makefile to enable mlx4_fc (fcoe/fcoib offload driver) and mlx4_fcoib (FIP-alike discovery driver)

---
 drivers/scsi/Kconfig  |   23 +++++++++++++++++++++++
 drivers/scsi/Makefile |    2 ++
 2 files changed, 25 insertions(+), 0 deletions(-)
drivers/scsi/Kconfig +23 -0
index 158284f..e3d2850 100644
@@ -687,6 +687,29 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	select MLX4_EN
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs.
+	  The module will be called mlx4_fc.
+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module attempts to discover BridgeX gateways in the
+	  Infiniband fabric by implementing FIP protocol (FCoE
+	  Initialization protocol) over Infiniband.
+	  The module will be called mlx4_fcoib.
+
 config SCSI_DMX3191D
 	tristate "DMX3191D SCSI support"
 	depends on PCI && SCSI
drivers/scsi/Makefile +2 -0
index 2a3fca2..0d0dab7 100644
@@ -40,6 +40,8 @@ obj-$(CONFIG_LIBFC)		+= libfc/
 obj-$(CONFIG_LIBFCOE)		+= fcoe/
 obj-$(CONFIG_FCOE)		+= fcoe/
 obj-$(CONFIG_FCOE_FNIC)		+= fnic/
+obj-$(CONFIG_MLX4_FC)		+= mlx4_fc/
+obj-$(CONFIG_MLX4_FCOIB)	+= mlx4_fc/
 obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
 obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
 obj-$(CONFIG_SCSI_A4000T)	+= 53c700.o	a4000t.o
Signature · 1 line
1.6.3.3
#4 lore raw
Quoted 34 lines · Vu Pham
Quoted 18 lines

depends on

drivers/scsi/Kconfig +7 -0
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+	  The module will be called mlx4_fc

End both lines above with periods (".").

(quoted diff) +3 -0
+
+	  The module FIP-alike to discover BridgeX gateways in the
+	  Infiniband fabric

end sentence with ".".

Quoted 8 lines

What does "FIP-alike" mean? and fix grammar:

This module attempts to discover BridgeX gateways in the Infiniband fabric.
?

end sentence with ".".

Thanks for you comments.

From 54041f56fa1896388a52f503e43e21aa11cc9a2a Mon Sep 17 00:00:00 2001
From: Vu Pham <[email protected]>
Date: Tue, 17 Aug 2010 15:40:42 -0700
Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

Quoted 5 lines

Add entries in scsi's Kconfig and Makefile to enable mlx4_fc (fcoe/fcoib offload driver) and mlx4_fcoib (FIP-alike discovery driver)

Looks good. Thanks for the update.

Quoted 52 lines
---
 drivers/scsi/Kconfig  |   23 +++++++++++++++++++++++
 drivers/scsi/Makefile |    2 ++
 2 files changed, 25 insertions(+), 0 deletions(-)
drivers/scsi/Kconfig +23 -0
index 158284f..e3d2850 100644
@@ -687,6 +687,29 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	select MLX4_EN
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs.
+	  The module will be called mlx4_fc.
+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module attempts to discover BridgeX gateways in the
+	  Infiniband fabric by implementing FIP protocol (FCoE
+	  Initialization protocol) over Infiniband.
+	  The module will be called mlx4_fcoib.
+
 config SCSI_DMX3191D
 	tristate "DMX3191D SCSI support"
 	depends on PCI && SCSI
drivers/scsi/Makefile +2 -0
index 2a3fca2..0d0dab7 100644
@@ -40,6 +40,8 @@ obj-$(CONFIG_LIBFC)		+= libfc/
 obj-$(CONFIG_LIBFCOE)		+= fcoe/
 obj-$(CONFIG_FCOE)		+= fcoe/
 obj-$(CONFIG_FCOE_FNIC)		+= fnic/
+obj-$(CONFIG_MLX4_FC)		+= mlx4_fc/
+obj-$(CONFIG_MLX4_FCOIB)	+= mlx4_fc/
 obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
 obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
 obj-$(CONFIG_SCSI_A4000T)	+= 53c700.o	a4000t.o
Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***