Skip to contentSkip to conversation

problems building mallopt01.c for uClinux

LTP David Marlin 3 participants 5 messages Aug 17, 2010

lore
Share & tools
lore

David Marlin

author
#0 lore raw

The testcase mallopt01 skips performing the test when UCLINUX=1, but the mallinfo structure is defined outside the #if !defined(UCLINUX) block.

Attached is a patch to move the mallinfo structure definition inside the #if !defined(UCLINUX) block.

Signed-off-by d.marlin <[email protected]>
kernel/syscalls/mallopt/mallopt01.c renamed from kernel/syscalls/mallopt/mallopt01.c.orig2 +2 -2
@@ -56,10 +56,10 @@
 extern int Tst_COUNT;		/* Test Case counter for tst_routines */
 
 void printinfo();
-/*****	*	*	*****/
-struct mallinfo info;
 
 #if !defined(UCLINUX)
+/*****	*	*	*****/
+struct mallinfo info;
 
 /*--------------------------------------------------------------*/
 int main(int argc, char *argv[])

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 6 lines · David Marlin

The testcase mallopt01 skips performing the test when UCLINUX=1, but the mallinfo structure is defined outside the #if !defined(UCLINUX) block.

Attached is a patch to move the mallinfo structure definition inside the #if !defined(UCLINUX) block.

ACK.

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 8 lines · Garrett Cooper
Quoted 5 lines · David Marlin

The testcase mallopt01 skips performing the test when UCLINUX=1, but the mallinfo structure is defined outside the #if !defined(UCLINUX) block.

Attached is a patch to move the mallinfo structure definition inside the #if !defined(UCLINUX) block.

ACK.

meaning you're going to merge it ? ;) this change looks fine of course. -mike

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Acked-by
#3 lore raw
Quoted 11 lines · Mike Frysinger
Quoted 8 lines · Garrett Cooper
Quoted 5 lines · David Marlin

The testcase mallopt01 skips performing the test when UCLINUX=1, but the mallinfo structure is defined outside the #if !defined(UCLINUX) block.

Attached is a patch to move the mallinfo structure definition inside the #if !defined(UCLINUX) block.

ACK.

meaning you're going to merge it ? ;)  this change looks fine of course.

Yeah. ACK -> all's good, I'm going to commit later. I kind of adopted it after looking at the yum list, because it's a lot quicker to say and less redundant than:

Acked-by Garrett Cooper <[email protected]>

;)...

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#4 lore raw
Quoted 11 lines · Garrett Cooper
Quoted 10 lines · Mike Frysinger
Quoted 8 lines · Garrett Cooper
Quoted 5 lines · David Marlin

The testcase mallopt01 skips performing the test when UCLINUX=1, but the mallinfo structure is defined outside the #if !defined(UCLINUX) block.

Attached is a patch to move the mallinfo structure definition inside the #if !defined(UCLINUX) block.

ACK.

Quoted 7 lines
Quoted 1 line

meaning you're going to merge it ? ;)  this change looks fine of course.

Yeah. ACK -> all's good, I'm going to commit later. I kind of adopted it after looking at the yum list, because it's a lot quicker to say and less redundant than:

Acked-by Garrett Cooper <[email protected]>

ok, but following the original LKML style, people who ACK usually arent the ones who actually pick up & merge
-mike

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list