Skip to contentSkip to conversation

parport_pc: show the detection of a 2 serial port ITE8874 chip

PATCH Applied Niels de Vos 2 participants 2 messages Aug 23, 2010 – Aug 24, 2010 Parallel port

lore
Share & tools
lore

Niels de Vos

author
#0 lore raw

PATCH 1/1 parport_pc: show the detection of a 2 serial port ITE8874 chip

The printk message for the 2 serial port version is obscured with a debug macro, unlike all other versions of the card. It should be changed to make the output equal for all detected models.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=578616#c1

CC Joe Krahn <[email protected]>
Signed-off-by Niels de Vos <[email protected]>
---
 drivers/parport/parport_pc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/parport/parport_pc.c +1 -1
index 0950fa4..8d62fb7 100644
@@ -2599,7 +2599,7 @@ static int __devinit sio_ite_8872_probe(struct pci_dev *pdev, int autoirq,
 		printk(KERN_INFO "parport_pc: ITE8873 found (1S)\n");
 		return 0;
 	case 0x8:
-		DPRINTK(KERN_DEBUG "parport_pc: ITE8874 found (2S)\n");
+		printk(KERN_INFO "parport_pc: ITE8874 found (2S)\n");
 		return 0;
 	default:
 		printk(KERN_INFO "parport_pc: unknown ITE887x\n");
Signature · 1 line
1.7.2.1
Applied
#1 lore raw
Quoted 17 lines · Niels de Vos

The printk message for the 2 serial port version is obscured with a debug macro, unlike all other versions of the card. It should be changed to make the output equal for all detected models.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=578616#c1

CC Joe Krahn <[email protected]>
Signed-off-by Niels de Vos <[email protected]>
---
 drivers/parport/parport_pc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/parport/parport_pc.c +0 -0
index 0950fa4..8d62fb7 100644

drivers/parport/parport_pc.c static int __devinit sio_ite_8872_probe(struct pci_dev *pdev, int autoirq, · line 2605

Quoted 8 lines
drivers/parport/parport_pc.c +1 -1
@@ -2599,7 +2599,7 @@ static int __devinit sio_ite_8872_probe(struct pci_dev *pdev, int autoirq,
 		printk(KERN_INFO "parport_pc: ITE8873 found (1S)\n");
 		return 0;
 	case 0x8:
-		DPRINTK(KERN_DEBUG "parport_pc: ITE8874 found (2S)\n");
+		printk(KERN_INFO "parport_pc: ITE8874 found (2S)\n");
 		return 0;
 	default:
 		printk(KERN_INFO "parport_pc: unknown ITE887x\n");

Applied, thank you.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.