bug in match_ipaddr6 ?
Subsystems (2)
static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
const struct sockaddr *sa2)
{
const struct sockaddr_in6 *sin1 = (const struct sockaddr_in6 *)sa1;
const struct sockaddr_in6 *sin2 = (const struct sockaddr_in6 *)sa2;
if (ipv6_addr_scope(&sin1->sin6_addr) == IPV6_ADDR_SCOPE_LINKLOCAL &&
sin1->sin6_scope_id != sin2->sin6_scope_id)
return 0;
return ipv6_addr_equal(&sin1->sin6_addr, &sin1->sin6_addr);Looks like this last line, second argument should be &sin2->sin6_addr ???
Thanks,
Ben
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
Quoted 12 lines · On Thu, 02 Sep 2010 15:36:39 -0700 Ben Greear <[email protected]> wrote:
static int nfs_sockaddr_match_ipaddr6(const struct sockaddr *sa1,
const struct sockaddr *sa2){ const struct sockaddr_in6 *sin1 = (const struct sockaddr_in6 *)sa1; const struct sockaddr_in6 *sin2 = (const struct sockaddr_in6 *)sa2; if (ipv6_addr_scope(&sin1->sin6_addr) == IPV6_ADDR_SCOPE_LINKLOCAL && sin1->sin6_scope_id != sin2->sin6_scope_id) return 0; return ipv6_addr_equal(&sin1->sin6_addr, &sin1->sin6_addr);
Quoted 5 lines
Looks like this last line, second argument should be
&sin2->sin6_addr???Thanks,
Ben
Ouch. Yes, that does look wrong. Care to send a patch to fix it?
Signature · 1 line
Jeff Layton <[email protected]>