apparmor: double lock
Hi,
stanse found that you possibly double lock ns->lock:aa_remove_profiles
-> write_lock(&ns->lock)
-> __remove_namespace(ns)
-> destroy_namespace(ns)
-> write_lock(&ns->lock)Could you fix that if that may happen at all?
regards,
Signature · 1 line
js
Quoted 11 lines · Jiri Slaby
Hi,
stanse found that you possibly double lock
ns->lock:aa_remove_profiles
->write_lock(&ns->lock)
->__remove_namespace(ns)-> destroy_namespace(ns) -> write_lock(&ns->lock)Could you fix that if that may happen at all?
Yes, thanks Jiri, the patch has already been posted
http://marc.info/?l=linux-kernel&m=128295924407596&w=2
john
Quoted 10 lines · John Johansen
Quoted 9 lines · Jiri Slaby
Hi,
stanse found that you possibly double lock
ns->lock:aa_remove_profiles
->write_lock(&ns->lock)
->__remove_namespace(ns)-> destroy_namespace(ns) -> write_lock(&ns->lock)
Quoted 5 lines
Quoted 2 lines
Could you fix that if that may happen at all?
Yes, thanks Jiri, the patch has already been posted
Are all of the patches in that set ready to be merged to Linus?
Signature · 2 lines
James Morris <[email protected]>
Quoted 12 lines · James Morris
Quoted 10 lines · John Johansen
Quoted 9 lines · Jiri Slaby
Hi,
stanse found that you possibly double lock
ns->lock:aa_remove_profiles
->write_lock(&ns->lock)
->__remove_namespace(ns)-> destroy_namespace(ns) -> write_lock(&ns->lock)
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Could you fix that if that may happen at all?
Yes, thanks Jiri, the patch has already been posted
Are all of the patches in that set ready to be merged to Linus?
yes they should be now, I believe so.
I have just posted out the updated Fix security_task_setrlimit logic patch that fixes the commenting. I can repost the series if you would like.
thanks
john