Patch to fix swapping of front and back porches when reading from modedb.c
Hi list :-)
I had trouble getting a standard 800x600@60Hz VGA signal to display correctly on my monitors. Measuring the output showed that the front and back porches were swapped both for hsync and vsync. After reading the source I think I found the error in drivers/video/omap2/omapfb/omapfb-main.c. Patch attached.
http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but todays code sets:
hfp = left margin
hbp = right margin
vfp = upper margin
vbp = lower margin
I tested a patched kernel with 800x600@60Hz on two different monitors and a vga grabber, and it solved my issues.
Regards,
Tassle
Quoted 1 line
From
f6a0d18c16bfc827e18356b11c4e3cd96b836787Mon Sep 17 00:00:00 2001
From: Tasslehoff Kjappfot <[email protected]>
Date: Wed, 8 Sep 2010 12:46:14 +0200
Subject: [PATCH] swap front and back porches for both hsync and vsync
--- drivers/video/omap2/omapfb/omapfb-main.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)
drivers/video/omap2/omapfb/omapfb-main.c +8 -8
@@ -711,10 +711,10 @@ int check_fb_var(struct fb_info *fbi, struct fb_var_screeninfo *var) var->pixclock = timings.pixel_clock !=0 ?KHZ2PICOS (timings.pixel_clock) :0 ; - var->left_margin = timings.hfp; - var->right_margin = timings.hbp; - var->upper_margin = timings.vfp; - var->lower_margin = timings.vbp; + var->left_margin = timings.hbp; + var->right_margin = timings.hfp; + var->upper_margin = timings.vbp; + var->lower_margin = timings.vfp; var->hsync_len = timings.hsw; var->vsync_len = timings.vsw; }else {
@@ -1992,10 +1992,10 @@ static int omapfb_mode_to_timings(const char *mode_str,if (r !=0 ) { timings->pixel_clock =PICOS2KHZ (var.pixclock); - timings->hfp = var.left_margin; - timings->hbp = var.right_margin; - timings->vfp = var.upper_margin; - timings->vbp = var.lower_margin; + timings->hbp = var.left_margin; + timings->hfp = var.right_margin; + timings->vbp = var.upper_margin; + timings->vfp = var.lower_margin; timings->hsw = var.hsync_len; timings->vsw = var.vsync_len; timings->x_res = var.xres;
Signature · 1 line
1.7.0.4
Russ Dill
Reviewed-byQuoted 13 lines · Tasslehoff Kjappfot
Hi list :-)
I had trouble getting a standard 800x600@60Hz VGA signal to display correctly on my monitors. Measuring the output showed that the front and back porches were swapped both for hsync and vsync. After reading the source I think I found the error in
drivers/video/omap2/omapfb/omapfb-main.c. Patch attached.http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but todays code sets:
Quoted 7 lines
hfp = left margin
hbp = right margin
vfp = upper margin
vbp = lower marginI tested a patched kernel with 800x600@60Hz on two different monitors and a vga grabber, and it solved my issues.
This looks good. Before this came up, I also thought that front porch meant left margin, and back porch meant margin, but margins are named in relation to pixel data, and porches are named in relation to sync pulses.
You might want to add a Signed-off-by line
Quoted 20 lines · Russ Dill
Quoted 12 lines · Tasslehoff Kjappfot
Hi list :-)
I had trouble getting a standard 800x600@60Hz VGA signal to display correctly on my monitors. Measuring the output showed that the front and back porches were swapped both for hsync and vsync. After reading the source I think I found the error in
drivers/video/omap2/omapfb/omapfb-main.c. Patch attached.http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but todays code sets:
Quoted 7 lines
hfp = left margin
hbp = right margin
vfp = upper margin
vbp = lower marginI tested a patched kernel with 800x600@60Hz on two different monitors and a vga grabber, and it solved my issues.
Quoted 8 lines
This looks good. Before this came up, I also thought that front porch meant left margin, and back porch meant margin, but margins are named in relation to pixel data, and porches are named in relation to sync pulses.
You might want to add a Signed-off-by line
Reviewed-by [email protected]
Quoted 19 lines · ext Russ Dill
Quoted 18 lines · Tasslehoff Kjappfot
Hi list :-)
I had trouble getting a standard 800x600@60Hz VGA signal to display correctly on my monitors. Measuring the output showed that the front and back porches were swapped both for hsync and vsync. After reading the source I think I found the error in
drivers/video/omap2/omapfb/omapfb-main.c. Patch attached.http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but todays code sets:
hfp = left margin
hbp = right margin
vfp = upper margin
vbp = lower margin
Quoted 7 lines
Quoted 2 lines
I tested a patched kernel with 800x600@60Hz on two different monitors and a vga grabber, and it solved my issues.
This looks good. Before this came up, I also thought that front porch meant left margin, and back porch meant margin, but margins are named in relation to pixel data, and porches are named in relation to sync pulses.
Ah, that's new to me too =). After a few minutes of googling, it's quite clear that the patch is correct.
Thanks! I improved the patch description a bit, and added it to my tree.
Tomi