Skip to contentSkip to conversation

enable getsockopt() for IP_NODEFRAG

PATCH In review Michael Kerrisk 3 participants 3 messages Sep 11, 2010 – Sep 14, 2010 2 messages not in the archive

Subsystems (4)
Networking Network drivers netfilter Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7
lore
Share & tools
lore

Michael Kerrisk

author
#0 lore raw

PATCH 1/1 enable getsockopt() for IP_NODEFRAG

Hello Jiri

While integrating your man-pages patch for IP_NODEFRAG, I noticed that this option is settable by setsockopt(), but not gettable by getsockopt(). I suppose this is not intended. The (untested, trivial) patch below adds getsockopt() support.

The patch is against 2.6.36-rc3.

Cheers,

Michael

PS I've just configured Thunderbird on this machine, hopefully the patch is not mangled. Please let me know if there are problems.

Signed-off-by Michael kerrisk <[email protected]>
ipv4/ip_sockglue.c renamed from ipv4/ip_sockglue.c.orig +3 -0
@@ -1129,6 +1129,9 @@ static int do_ip_getsockopt(struct sock
 	case IP_HDRINCL:
 		val = inet->hdrincl;
 		break;
+	case IP_NODEFRAG:
+		val = inet->nodefrag;
+		break;
 	case IP_MTU_DISCOVER:
 		val = inet->pmtudisc;
 		break;
Signature · 4 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Watch my Linux system programming book progress towards publication!
http://blog.man7.org/

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 7 lines · Michael Kerrisk

Hello Jiri

While integrating your man-pages patch for IP_NODEFRAG, I noticed that this option is settable by setsockopt(), but not gettable by getsockopt(). I suppose this is not intended. The (untested, trivial) patch below adds getsockopt() support.

Quoted 8 lines

The patch is against 2.6.36-rc3.

Cheers,

Michael

PS I've just configured Thunderbird on this machine, hopefully the patch is not mangled. Please let me know if there are problems.

hi,

applied ok, compiled ok ;) thanks

Acked-by Jiri Olsa <[email protected]>
Quoted 20 lines
Signed-off-by Michael kerrisk <[email protected]>
ipv4/ip_sockglue.c renamed from ipv4/ip_sockglue.c.orig +3 -0
@@ -1129,6 +1129,9 @@ static int do_ip_getsockopt(struct sock
 	case IP_HDRINCL:
 		val = inet->hdrincl;
 		break;
+	case IP_NODEFRAG:
+		val = inet->nodefrag;
+		break;
 	case IP_MTU_DISCOVER:
 		val = inet->pmtudisc;
 		break;
Signature · 4 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Watch my Linux system programming book progress towards publication!
http://blog.man7.org/

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20100912215230.GA2091-Iosbtnj8/[email protected]

#4 lore raw

From: Jiri Olsa <[email protected]>
Date: Sun, 12 Sep 2010 23:52:30 +0200

Quoted 14 lines · Michael Kerrisk
Quoted 13 lines

Hello Jiri

While integrating your man-pages patch for IP_NODEFRAG, I noticed that this option is settable by setsockopt(), but not gettable by getsockopt(). I suppose this is not intended. The (untested, trivial) patch below adds getsockopt() support.

The patch is against 2.6.36-rc3.

Cheers,

Michael

Quoted 7 lines
Quoted 2 lines

PS I've just configured Thunderbird on this machine, hopefully the patch is not mangled. Please let me know if there are problems.

hi,

applied ok, compiled ok ;) thanks

Acked-by Jiri Olsa <[email protected]>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html