Skip to contentSkip to conversation

sector size warning at mount time

DISCUSSION Eric Sandeen 2 participants 2 messages Sep 16, 2010

lore
Share & tools
lore
#0 lore raw

On ppc64 I'm tripping this warning:

        if (verbose &&
            (PAGE_CACHE_SIZE / BITS_PER_LONG) > sectorsize) {
                printk(KERN_WARNING
                        "XFS: %u byte sectors in use on device %s.  "
                        "This is suboptimal; %u or greater is ideal.\n",
                        sectorsize, XFS_BUFTARG_NAME(btp),
                        (unsigned int)PAGE_CACHE_SIZE / BITS_PER_LONG);
        }

and it's telling me I should have 1024-byte sectors...

If the kernel is going to complain at mount, should we get it right at mkfs time? I'm not even quite sure why it's recommending this?

Thanks,
-Eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 11 lines · Eric Sandeen

On ppc64 I'm tripping this warning:

        if (verbose &&
            (PAGE_CACHE_SIZE / BITS_PER_LONG) > sectorsize) {
                printk(KERN_WARNING
                        "XFS: %u byte sectors in use on device %s.  "
                        "This is suboptimal; %u or greater is ideal.\n",
                        sectorsize, XFS_BUFTARG_NAME(btp),
                        (unsigned int)PAGE_CACHE_SIZE / BITS_PER_LONG);
        }
Quoted 4 lines

and it's telling me I should have 1024-byte sectors...

If the kernel is going to complain at mount, should we get it right at mkfs time? I'm not even quite sure why it's recommending this?

Because it requires 128 bits to track each sector in page when the buffer cache is has to use sub-page buffers. That's all the test/set_region garbage that it has.

The don't-user-the-page-cache part of my buffer cache rework fixes this bug, so I probably wouldn't bother changing anything else at this point in time...

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs