Skip to contentSkip to conversation

xkbd_0.8.15.bb: Fix geometry flag to accept negative offsets.

PATCH In review Graham Gower 2 participants 4 messages Sep 17, 2010 – Sep 19, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xkbd_0.8.15.bb: Fix geometry flag to accept negative offsets.

---
 .../xkbd-0.8.15/xkbd-0.8.15-fix-geometry.patch     |   37 ++++++++++++++++++++
 recipes/xkbd/xkbd_0.8.15.bb                        |    3 +-
 2 files changed, 39 insertions(+), 1 deletions(-)
 create mode 100644 recipes/xkbd/xkbd-0.8.15/xkbd-0.8.15-fix-geometry.patch
recipes/xkbd/xkbd-0.8.15/xkbd-0.8.15-fix-geometry.patch new file +37 -0
new file mode 100644
index 0000000..65deb8d
@@ -0,0 +1,37 @@
+Fix handling of the -geometry option.
+Author: Gautam Iyer, see http://bugs.gentoo.org/214353
+diff -ruN xkbd-0.8.15/src/xkbd.c xkbd-0.8.15-new/src/xkbd.c
+--- xkbd-0.8.15/src/xkbd.c	2003-09-29 10:29:35.000000000 -0700
++++ xkbd-0.8.15-new/src/xkbd.c	2008-03-23 02:43:20.000000000 -0700
+@@ -307,19 +307,20 @@
+ 				0, BlackPixel(display, screen_num),
+ 				WhitePixel(display, screen_num));
+       
++      wret = DisplayWidth(display, screen_num);
++      hret = DisplayHeight(display, screen_num)/4;
++      xret = 0;
++      yret = DisplayHeight(display, screen_num) - hret;
++
+       if (geometry != NULL)
+ 	{
+-	  XParseGeometry(geometry, &xret, &yret, &wret, &hret );
+-	}
+-      else
+-	{
+-	  if (wm_type != WM_MATCHBOX)
+-	    {
+-	      wret = DisplayWidth(display, screen_num);
+-	      hret = DisplayHeight(display, screen_num)/4;
+-	      xret = 0;
+-	      yret = DisplayHeight(display, screen_num) - hret;
+-	    }
++	  int flags;
++
++	  flags = XParseGeometry(geometry, &xret, &yret, &wret, &hret );
++	  if( flags & XNegative )
++	      xret += DisplayWidth( display, screen_num ) - wret;
++	  if( flags & YNegative )
++	      yret += DisplayHeight( display, screen_num ) - hret;
+ 	}
+       
+       /* check for user selected keyboard conf file */
recipes/xkbd/xkbd_0.8.15.bb +2 -1
index 309d7d8..cda2be9 100644
@@ -4,9 +4,10 @@ SRC_URI = "http://www.angstrom-distribution.org/unstable/sources/xkbd-${PV}-CVS.
 	   file://fix-circumkey.patch \
 	   file://add-default-common-slides.patch \
 	   file://differentiate-desktop-name.patch \
+	   file://xkbd-0.8.15-fix-geometry.patch \
 	   file://xkbd.png"
 LICENSE = "GPL"
-PR = "r4"
+PR = "r5"
 
 SECTION = "x11"
 DEPENDS = "libxpm libxtst libxft"
Signature · 1 line
1.7.1
#1 lore raw

On 09/17/2010 01:51 PM, Graham Gower wrote:

Where is this patch coming from? is it upstream?

#2 lore raw
Quoted 4 lines · Holger Freyther

On 09/17/2010 01:51 PM, Graham Gower wrote:

Where is this patch coming from? is it upstream?

It comes from http://bugs.gentoo.org/214353 - as found in the patch header.

-Graham

PS: What upstream?

#3 lore raw
Quoted 2 lines · Graham Gower

It comes from http://bugs.gentoo.org/214353 - as found in the patch header.

Okay, didn't see it.

Quoted 2 lines

PS: What upstream?

Sorry, I thought it is Xorg... but it has no real upstream anymore.

please feel free to apply.