Skip to contentSkip to conversation

Warn user that driver is backported and might not work as expected

PATCH Applied Mauro Carvalho Chehab 3 participants 4 messages Sep 17, 2010 – Sep 19, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Warn user that driver is backported and might not work as expected

Since the migration to -git, less developers are using the -hg tree. Also, some changes are happening upstream that would require much more than just compiling the tree with an older version, to be sure that the backport won't break anything, like the removal of BKL.

As normal users might not be aware of those issues, and bug reports may be sent based on a backported tree, add some messages to warn about the usage of a backported experimental (unsupported) tree.

linux/drivers/media/dvb/dvb-core/dvbdev.c +6 -0
diff -r 60edc4bd92b7 linux/drivers/media/dvb/dvb-core/dvbdev.c
@@ -521,6 +521,12 @@
 #elif LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 31)
 	dvb_class->devnode = dvb_devnode;
 #endif
+#ifdef EXPERIMENTAL_TREE
+	printk(KERN_ERR "WARNING: You're using an experimental version of the DVB stack. As the driver\n"
+			"         is backported to an older kernel, it doesn't offer enough quality for\n"
+			"         its usage in production.\n"
+			"         Use it with care.\n");
+#endif
 	return 0;
 
 error:
linux/drivers/media/video/v4l2-dev.c +6 -0
diff -r 60edc4bd92b7 linux/drivers/media/video/v4l2-dev.c
@@ -686,6 +686,12 @@
 	int ret;
 
 	printk(KERN_INFO "Linux video capture interface: v2.00\n");
+#ifdef EXPERIMENTAL_TREE
+	printk(KERN_ERR "WARNING: You're using an experimental version of the V4L stack. As the driver\n"
+			"         is backported to an older kernel, it doesn't offer enough quality for\n"
+			"         its usage in production.\n"
+			"         Use it with care.\n");
+#endif
 	ret = register_chrdev_region(dev, VIDEO_NUM_DEVICES, VIDEO_NAME);
 	if (ret < 0) {
 		printk(KERN_WARNING "videodev: unable to get major %d\n",
v4l/compat.h +2 -0
diff -r 60edc4bd92b7 v4l/compat.h
@@ -14,6 +14,8 @@
 #define INIT_DELAYED_WORK(a,b,c)	INIT_WORK(a,b,c)
 #endif
 
+#define EXPERIMENTAL_TREE
+
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 35)
 #define usb_buffer_alloc(dev, size, mem_flags, dma) usb_alloc_coherent(dev, size, mem_flags, dma)
 #define usb_buffer_free(dev, size, addr, dma) usb_free_coherent(dev, size, addr, dma)
v4l/scripts/make_kconfig.pl +9 -0
diff -r 60edc4bd92b7 v4l/scripts/make_kconfig.pl
@@ -671,4 +671,13 @@
 
 EOF2
 	}
+print << "EOF3";
+WARNING: This is the V4L/DVB backport tree, with experimental drivers
+	 backported to run on legacy kernels from the development tree at:
+		http://git.linuxtv.org/media-tree.git.
+	 It is generally safe to use it for testing a new driver or
+	 feature, but its usage on production environments is risky.
+	 Don't use it at production. You've being warned.
+EOF3
+	sleep 5;
 }
#1 lore raw

<snip>

v4l/scripts/make_kconfig.pl       Fri Sep 17 11:49:02 2010 -0300

Quoted 13 lines
v4l/scripts/make_kconfig.pl       Fri Sep 17 11:49:02 2010 -0300 renamed from v4l/scripts/make_kconfig.pl       Sun Jun 27 17:17:06 2010 -0300 +0 -0
@@ -671,4 +671,13 @@
 

 EOF2
       }

v4l/scripts/make_kconfig.pl       Fri Sep 17 11:49:02 2010 -0300 renamed from v4l/scripts/make_kconfig.pl       Sun Jun 27 17:17:06 2010 -0300 +7 -0
+print << "EOF3";
+WARNING: This is the V4L/DVB backport tree, with experimental drivers
+        backported to run on legacy kernels from the development tree at:
+               http://git.linuxtv.org/media-tree.git.
+        It is generally safe to use it for testing a new driver or
+        feature, but its usage on production environments is risky.
+        Don't use it at production. You've being warned.

The last line should read: "Don't use it in production. You've been warned."

Quoted 4 lines

+EOF3
+       sleep 5;
 }
--

Regards,

David Ellingsworth

#2 lore raw

Hi,

Quoted 5 lines · David Ellingsworth

<snip>

Quoted 4 lines
v4l/scripts/make_kconfig.pl Fri Sep 17 11:49:02 2010 -0300 renamed from v4l/scripts/make_kconfig.pl Sun Jun 27 17:17:06 2010 -0300 +0 -0
@@ -671,4 +671,13 @@
 
Quoted 12 lines

v4l/scripts/make_kconfig.pl Fri Sep 17 11:49:02 2010 -0300 line 680

Quoted 9 lines
v4l/scripts/make_kconfig.pl Fri Sep 17 11:49:02 2010 -0300 renamed from v4l/scripts/make_kconfig.pl Sun Jun 27 17:17:06 2010 -0300 +7 -0
 EOF2
       }
+print << "EOF3";
+WARNING: This is the V4L/DVB backport tree, with experimental drivers
+        backported to run on legacy kernels from the development tree at:
+               http://git.linuxtv.org/media-tree.git.
+        It is generally safe to use it for testing a new driver or
+        feature, but its usage on production environments is risky.
+        Don't use it at production. You've being warned.

The last line should read: "Don't use it in production. You've been warned."

Fixed thanks!

Cheers
Douglas

#3 lore raw
In reply to Mauro Carvalho Chehab

Hi,

Quoted 10 lines · Mauro Carvalho Chehab

Since the migration to -git, less developers are using the -hg tree. Also, some changes are happening upstream that would require much more than just compiling the tree with an older version, to be sure that the backport won't break anything, like the removal of BKL.

As normal users might not be aware of those issues, and bug reports may be sent based on a backported tree, add some messages to warn about the usage of a backported experimental (unsupported) tree.

Applied, thanks!

Cheers
Douglas