Skip to contentSkip to conversation

V4L/DVB fixes

GIT PULL Mauro Carvalho Chehab 4 participants 7 messages Sep 27, 2010 – Sep 30, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

Andy Walls (1):

      V4L/DVB: cx25840: Fix typo in volume control initialization: 65335 vs. 65535

Baruch Siach (1):
V4L/DVB: mx2_camera: fix a race causing NULL dereference

Dan Carpenter (5):
V4L/DVB: unlock on error path
V4L/DVB: IR: ir-raw-event: null pointer dereference V4L/DVB: opera1: remove unneeded NULL check V4L/DVB: pvrusb2: remove unneeded NULL checks V4L/DVB: saa7164: move dereference under NULL check

Dan Rosenberg (1):
V4L/DVB: ivtvfb: prevent reading uninitialized stack memory

Dmitri Belimov (1):
V4L/DVB: Fix regression for BeholdTV Columbus

Hans Verkuil (2):
V4L/DVB: ivtv: convert gpio subdev to new control framework V4L/DVB: videobuf-dma-sg: set correct size in last sg element

Ionut Gabriel Popescu (1):
V4L/DVB: mt9v022.c: Fixed compilation warning

Jarod Wilson (1):
V4L/DVB: mceusb: add two new ASUS device IDs

Jason Wang (1):
V4L/DVB: gspca - main: Fix a crash of some webcams on ARM arch

Jean-François Moine (1):

      V4L/DVB: gspca - sn9c20x: Bad transfer size of Bayer images

Laurent Pinchart (3):
V4L/DVB: uvcvideo: Add support for Miricle 307K thermal webcam V4L/DVB: uvcvideo: Fix support for Medion Akoya All-in-one PC integrated webcam V4L/DVB: uvcvideo: Restrict frame rates for Chicony CNF7129 webcam

Mauro Carvalho Chehab (3):
V4L/DVB: Don't identify PV SBTVD Hybrid as a DibCom device V4L/DVB: rc-core: increase repeat time
V4L/DVB: cx231xx: Avoid an OOPS when card is unknown (card=0)

Maxim Levitsky (4):
V4L/DVB: IR: Kconfig fixes
V4L/DVB: IR: fix duty cycle capability V4L/DVB: IR: fix keys beeing stuck down forever V4L/DVB: IR: extend MCE keymap

Michael Grzeschik (2):
V4L/DVB: mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE V4L/DVB: mt9m111: added current colorspace at g_fmt

Olivier Grenie (2):
V4L/DVB: dib7770: enable the current mirror
V4L/DVB: dib7000p: add disable sample and hold, and diversity delay parameter

Pawel Osciak (2):
V4L/DVB: v4l: mem2mem_testdev: fix errorenous comparison V4L/DVB: v4l: mem2mem_testdev: add missing release for video_device

Randy Dunlap (1):

      V4L/DVB: tm6000: depends on IR_CORE

Richard Zidlicky (1):
V4L/DVB: dvb: fix smscore_getbuffer() logic

Stefan Ringel (1):
V4L/DVB: tm6000: bugfix data handling

lawrence rust (1):
V4L/DVB: cx88: Kconfig: Remove EXPERIMENTAL dependency from VIDEO_CX88_ALSA

 drivers/media/IR/Kconfig                     |    2 +
 drivers/media/IR/ir-keytable.c               |    9 +++-
 drivers/media/IR/ir-lirc-codec.c             |    2 +-
 drivers/media/IR/ir-raw-event.c              |    4 +-
 drivers/media/IR/keymaps/rc-rc6-mce.c        |    3 +
 drivers/media/IR/mceusb.c                    |    4 ++
 drivers/media/dvb/dvb-usb/dib0700_core.c     |    3 -
 drivers/media/dvb/dvb-usb/dib0700_devices.c  |   56 +++++++++++++++++++++++-
 drivers/media/dvb/dvb-usb/opera1.c           |    4 +-
 drivers/media/dvb/frontends/dib7000p.c       |    8 +++-
 drivers/media/dvb/frontends/dib7000p.h       |    5 ++
 drivers/media/dvb/siano/smscoreapi.c         |   31 +++++--------
 drivers/media/video/cx231xx/Makefile         |    1 +
 drivers/media/video/cx231xx/cx231xx-cards.c  |   17 +++++---
 drivers/media/video/cx25840/cx25840-core.c   |    2 +-
 drivers/media/video/cx88/Kconfig             |    2 +-
 drivers/media/video/gspca/gspca.c            |    1 +
 drivers/media/video/gspca/sn9c20x.c          |    3 +-
 drivers/media/video/ivtv/ivtv-driver.c       |    1 +
 drivers/media/video/ivtv/ivtv-driver.h       |    1 +
 drivers/media/video/ivtv/ivtvfb.c            |    2 +
 drivers/media/video/mem2mem_testdev.c        |    3 +-
 drivers/media/video/mt9m111.c                |    8 +++-
 drivers/media/video/mt9v022.c                |    3 -
 drivers/media/video/mx2_camera.c             |    4 ++
 drivers/media/video/pvrusb2/pvrusb2-ctrl.c   |    6 +-
 drivers/media/video/s5p-fimc/fimc-core.c     |    3 +-
 drivers/media/video/saa7134/saa7134-cards.c  |   10 ++--
 drivers/media/video/saa7164/saa7164-buffer.c |    5 +-
 drivers/media/video/uvc/uvc_driver.c         |   33 ++++++++++++++
 drivers/media/video/uvc/uvcvideo.h           |    1 +
 drivers/media/video/videobuf-dma-sg.c        |   11 +++--
 drivers/staging/tm6000/Kconfig               |    2 +-
 drivers/staging/tm6000/tm6000-input.c        |   61 ++++++++++++++++---------
 include/media/videobuf-dma-sg.h              |    1 +
 35 files changed, 228 insertions(+), 84 deletions(-)
#1 lore raw
Quoted 6 lines · Mauro Carvalho Chehab

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

 alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
 ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

scripts/kconfig/conf --oldconfig arch/x86/Kconfig drivers/media/Kconfig:146: 'endif' in different file than 'if' drivers/media/IR/Kconfig:15: location of the 'if' drivers/Kconfig:114: unexpected 'endmenu' within if block drivers/Kconfig:1: missing end statement for this entry make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

with this. And it seems to be due to a totally broken commit at the very beginning of the series by a commit called "Kconfig fixes" (Hah!), that clearly has not been tested at all.

The commit sequence was also done today, apparently immediately before sending me the pull request. Which sure as hell explains the "clearly not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me total crap.

How effing hard can it be to understand: you don't send me stuff that hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you don't rebase it or take it from some random quilt series just before sending it to me.

That's true _especially_ during the -rc series. But it's damn well true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from people I pull from. This was not it. Get your ^&#! act together!

Linus

#2 lore raw

Em 27-09-2010 21:02, Linus Torvalds escreveu:

Quoted 19 lines
Quoted 6 lines · Mauro Carvalho Chehab

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

scripts/kconfig/conf --oldconfig arch/x86/Kconfig drivers/media/Kconfig:146: 'endif' in different file than 'if' drivers/media/IR/Kconfig:15: location of the 'if' drivers/Kconfig:114: unexpected 'endmenu' within if block drivers/Kconfig:1: missing end statement for this entry make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

Quoted 3 lines

with this. And it seems to be due to a totally broken commit at the very beginning of the series by a commit called "Kconfig fixes" (Hah!), that clearly has not been tested at all.

Argh! something got completely wrong here. Sorry for the mess. This patch is already upstream (changeset ade321c5b8a0e4).

I had some troubles on my local tree (some objects missed after a gc on a shared repository). I had to recover my local tree, to avoid loosing some patches applied there for linux-next. It seems that I did a bad work on recovering them. I always compile everything a few times before sending, but this time, I just didn't notice.

Quoted 12 lines

The commit sequence was also done today, apparently immediately before sending me the pull request. Which sure as hell explains the "clearly not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me total crap.

How effing hard can it be to understand: you don't send me stuff that hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you don't rebase it or take it from some random quilt series just before sending it to me.

Quoted 7 lines

That's true _especially_ during the -rc series. But it's damn well true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from people I pull from. This was not it. Get your ^&#! act together!

Linus

I'll clean up the mess and prepare a new pull request in the next days.

Sorry,
Mauro.

#4 lore raw
In reply to Linus Torvalds

Linus,

Am Montag, den 27.09.2010, 17:02 -0700 schrieb Linus Torvalds:

Quoted 35 lines
Quoted 6 lines · Mauro Carvalho Chehab

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

scripts/kconfig/conf --oldconfig arch/x86/Kconfig drivers/media/Kconfig:146: 'endif' in different file than 'if' drivers/media/IR/Kconfig:15: location of the 'if' drivers/Kconfig:114: unexpected 'endmenu' within if block drivers/Kconfig:1: missing end statement for this entry make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

with this. And it seems to be due to a totally broken commit at the very beginning of the series by a commit called "Kconfig fixes" (Hah!), that clearly has not been tested at all.

The commit sequence was also done today, apparently immediately before sending me the pull request. Which sure as hell explains the "clearly not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me total crap.

How effing hard can it be to understand: you don't send me stuff that hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you don't rebase it or take it from some random quilt series just before sending it to me.

Quoted 7 lines

That's true _especially_ during the -rc series. But it's damn well true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from people I pull from. This was not it. Get your ^&#! act together!

Linus

you should not be such rude.

You have never been in any hardware details on v4l and dvb.

After Gerd Knorr did quit, out of reasons, you noticed there is some noise on v4l and dvb, but you never had to fix much on your own in the last eight years.

Shouting around and blaming others always was enough ...

I agree, a rc-1 should be at least compile tested.

Any idea, why this goes away?

Cheers,
Hermann

#5 lore raw

Em 29-09-2010 22:04, hermann pitton escreveu:

Quoted 55 lines

Linus,

Am Montag, den 27.09.2010, 17:02 -0700 schrieb Linus Torvalds:

Quoted 35 lines
Quoted 6 lines · Mauro Carvalho Chehab

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

scripts/kconfig/conf --oldconfig arch/x86/Kconfig drivers/media/Kconfig:146: 'endif' in different file than 'if' drivers/media/IR/Kconfig:15: location of the 'if' drivers/Kconfig:114: unexpected 'endmenu' within if block drivers/Kconfig:1: missing end statement for this entry make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

with this. And it seems to be due to a totally broken commit at the very beginning of the series by a commit called "Kconfig fixes" (Hah!), that clearly has not been tested at all.

The commit sequence was also done today, apparently immediately before sending me the pull request. Which sure as hell explains the "clearly not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me total crap.

How effing hard can it be to understand: you don't send me stuff that hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you don't rebase it or take it from some random quilt series just before sending it to me.

Quoted 7 lines

That's true _especially_ during the -rc series. But it's damn well true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from people I pull from. This was not it. Get your ^&#! act together!

Linus

you should not be such rude.

You have never been in any hardware details on v4l and dvb.

After Gerd Knorr did quit, out of reasons, you noticed there is some noise on v4l and dvb, but you never had to fix much on your own in the last eight years.

Quoted 5 lines

Shouting around and blaming others always was enough ...

I agree, a rc-1 should be at least compile tested.

Any idea, why this goes away?

Hermann,

That's OK. I did crap. Linus is right. I'll send him the patches again after having the same tree branch being tested for a few days at linux-next, without any bad results.

Cheers,
Mauro.

#6 lore raw

Am Donnerstag, den 30.09.2010, 00:08 -0300 schrieb Mauro Carvalho Chehab:

Quoted 62 lines

Em 29-09-2010 22:04, hermann pitton escreveu:

Quoted 55 lines

Linus,

Am Montag, den 27.09.2010, 17:02 -0700 schrieb Linus Torvalds:

Quoted 35 lines
Quoted 6 lines · Mauro Carvalho Chehab

The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:

alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)

are available in the git repository at:
ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

scripts/kconfig/conf --oldconfig arch/x86/Kconfig drivers/media/Kconfig:146: 'endif' in different file than 'if' drivers/media/IR/Kconfig:15: location of the 'if' drivers/Kconfig:114: unexpected 'endmenu' within if block drivers/Kconfig:1: missing end statement for this entry make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

with this. And it seems to be due to a totally broken commit at the very beginning of the series by a commit called "Kconfig fixes" (Hah!), that clearly has not been tested at all.

The commit sequence was also done today, apparently immediately before sending me the pull request. Which sure as hell explains the "clearly not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me total crap.

How effing hard can it be to understand: you don't send me stuff that hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you don't rebase it or take it from some random quilt series just before sending it to me.

Quoted 7 lines

That's true _especially_ during the -rc series. But it's damn well true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from people I pull from. This was not it. Get your ^&#! act together!

Linus

you should not be such rude.

You have never been in any hardware details on v4l and dvb.

After Gerd Knorr did quit, out of reasons, you noticed there is some noise on v4l and dvb, but you never had to fix much on your own in the last eight years.

Quoted 5 lines

Shouting around and blaming others always was enough ...

I agree, a rc-1 should be at least compile tested.

Any idea, why this goes away?

Quoted 8 lines

Hermann,

That's OK. I did crap. Linus is right. I'll send him the patches again after having the same tree branch being tested for a few days at linux-next, without any bad results.

Cheers,
Mauro.

Mauro,

hopefully, a few days on linux-next can replace all what we had in the past, causing sometimes years of delay ...

What to say ?

OK, if you say we are fine with it now, it is up to you.

So, the whole mistake was, that Linus did not start kicking asses harder earlier?

What a total crap!

Cheers,
Hermann