Skip to contentSkip to conversation

Btrfs: Don't dereference extent_mapping if NULL

PATCH New Roel Kluin 1 participant 1 message Sep 29, 2010 Btrfs file system

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 Btrfs: Don't dereference extent_mapping if NULL

Don't dereference em if it's NULL or an error pointer.

---
I just noticed this by code analysis. It wasn't tested in any way.

 fs/btrfs/inode.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/btrfs/inode.c +2 -1
index c038644..d4a37f8 100644
@@ -1787,7 +1787,8 @@ static int btrfs_io_failed_hook(struct bio *failed_bio,
 
 		read_lock(&em_tree->lock);
 		em = lookup_extent_mapping(em_tree, start, failrec->len);
-		if (em->start > start || em->start + em->len < start) {
+		if (em && !IS_ERR(em) && (em->start > start ||
+					em->start + em->len < start)) {
 			free_extent_map(em);
 			em = NULL;
 		}