Skip to contentSkip to conversation

LZO: Add a LZO compression feature

PATCH Superseded Donggeun Kim 4 participants 6 messages Oct 1, 2010

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 LZO: Add a LZO compression feature

In some case, LZO compression function is needed in U-Boot.

This patch supports LZO compression feature which is originated from Linux kernel.

Thanks.
-Donggeun Kim

---
 lib/lzo/Makefile         |    2 +-
 lib/lzo/lzo1x_compress.c |  219 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 220 insertions(+), 1 deletions(-)
 create mode 100644 lib/lzo/lzo1x_compress.c
lib/lzo/Makefile +1 -1
index 5dd1bf5..0e22a49 100644
@@ -27,7 +27,7 @@ LIB	= $(obj)liblzo.a
 
 SOBJS	=
 
-COBJS-$(CONFIG_LZO) += lzo1x_decompress.o
+COBJS-$(CONFIG_LZO) += lzo1x_decompress.o lzo1x_compress.o
 
 COBJS	= $(COBJS-y)
 SRCS 	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
lib/lzo/lzo1x_compress.c new file +219 -0

219 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 LZO: Add a LZO compression feature

Dear Donggeun Kim,

Quoted 1 line · In message <[email protected]> you wrote:

In some case, LZO compression function is needed in U-Boot.

Can you please explain what use cases you have in mind?

So far, we provide only uncompression functions, and it seems nobody ever needed compression inside U-Boot yet?

If we really add this, then please make it separately configurable, so that not everybody who wants LZO decompression always has to accept the compression functions, too.

Quoted 1 line

This patch supports LZO compression feature which is originated from Linux kernel.

...

Quoted 5 lines
lib/lzo/lzo1x_compress.c new file +2 -0
@@ -0,0 +1,219 @@
+/*
+ *  LZO1X Compressor from MiniLZO

lib/lzo/lzo1x_compress.c line 12

Quoted 10 lines
lib/lzo/lzo1x_compress.c new file +10 -0
+ *
+ *  Copyright (C) 1996-2005 Markus F.X.J. Oberhumer <[email protected]>
+ *
+ *  The full LZO package can be found at:
+ *  http://www.oberhumer.com/opensource/lzo/
+ *
+ *  Changed for kernel use by:
+ *  Nitin Gupta <[email protected]>
+ *  Richard Purdie <[email protected]>
+ */

What exactly are the licensing terms?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Am I your nanny? The kernel is there to support  user  programs,  but
it's a _resource_ handler, not a baby feeder.     - Linus Torvalds in
      <[email protected]>
#2 lore raw

PATCH 1/1 LZO: Add a LZO compression feature

Hi Wolfgang.

Quoted 6 lines · Wolfgang Denk

Dear Donggeun Kim,

Quoted 1 line · In message <[email protected]> you wrote:

In some case, LZO compression function is needed in U-Boot.

Can you please explain what use cases you have in mind?

There's request from other team. They want to transfer the binary but it's written as ubifs filesystem.
So download the binary to RAM and then mkfs.ubifs at this address and ubinize it finally.
Then write it to flash.
When mkfs.ubifs, it requires it.

Quoted 7 lines

So far, we provide only uncompression functions, and it seems nobody ever needed compression inside U-Boot yet?

If we really add this, then please make it separately configurable, so that not everybody who wants LZO decompression always has to accept the compression functions, too.

Agree, It will use the CONFIG_LZO_COMPRESSION

Quoted 13 lines
Quoted 3 lines

This patch supports LZO compression feature which is originated from Linux kernel.

...

Quoted 9 lines
lib/lzo/lzo1x_compress.c new file +6 -0
@@ -0,0 +1,219 @@
+/*
+ * ?LZO1X Compressor from MiniLZO
+ *
+ * ?Copyright (C) 1996-2005 Markus F.X.J. Oberhumer <[email protected]>
+ *
+ * ?The full LZO package can be found at:
Quoted 8 lines

lib/lzo/lzo1x_compress.c line 12

Quoted 6 lines
lib/lzo/lzo1x_compress.c new file +6 -0
+ * ?http://www.oberhumer.com/opensource/lzo/
+ *
+ * ?Changed for kernel use by:
+ * ?Nitin Gupta <[email protected]>
+ * ?Richard Purdie <[email protected]>
+ */

What exactly are the licensing terms?

It's from kernel code. do you want to add the GPL v2?

Thank you,
Kyungmin Park

Quoted 17 lines

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Am I your nanny? The kernel is there to support ?user ?programs, ?but it's a _resource_ handler, not a baby feeder. ? ? - Linus Torvalds in ? ? ?<[email protected]>
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw

PATCH 1/1 LZO: Add a LZO compression feature

Dear Kyungmin Park,

Quoted 7 lines · In message <[email protected]> you…

There's request from other team. They want to transfer the binary but it's written as ubifs filesystem.
So download the binary to RAM and then mkfs.ubifs at this address and ubinize it finally.
Then write it to flash.
When mkfs.ubifs, it requires it.

You mean you want to add both support for ubinize and mkfs.ubifs to U-Boot? Would it not make more sense to boot a (minimal) Linux kernel for that purposes?

Quoted 2 lines
Quoted 1 line

What exactly are the licensing terms?

It's from kernel code. do you want to add the GPL v2?

I think we should do that (if that's what the original code is released under; I'm not so certain), to make things clear.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There's always been Tower of Babel sort of  bickering  inside  Unix,
but  this  is the most extreme form ever. This means at least several
years of confusion." - Bill Gates, founder and chairman of Microsoft,
about the Open Systems Foundation
#4 lore raw

PATCH 1/1 LZO: Add a LZO compression feature

Quoted 11 lines · Wolfgang Denk

Dear Kyungmin Park,

Quoted 7 lines · In message <[email protected]> you…

There's request from other team. They want to transfer the binary but it's written as ubifs filesystem.
So download the binary to RAM and then mkfs.ubifs at this address and ubinize it finally.
Then write it to flash.
When mkfs.ubifs, it requires it.

Quoted 3 lines

You mean you want to add both support for ubinize and mkfs.ubifs to U-Boot? ?Would it not make more sense to boot a (minimal) Linux kernel for that purposes?

Umm it's maybe difficult. This team don't use the linux and don't have linux environment.
Only generate binary it and remaining job are done by each product team. The even worse there's no console when they are use it.

Enter the download mode and send the image to target.

Of course this method is not visible to their. and no behavior changed to our environment.

Thank you,
Kyungmin Park

Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

What exactly are the licensing terms?

It's from kernel code. do you want to add the GPL v2?

I think we should do that (if that's what the original code is released under; I'm not so certain), to make things clear.

Then just add the "It's from linux kernel"

Quoted 18 lines

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There's always been Tower of Babel sort of ?bickering ?inside ?Unix, but ?this ?is the most extreme form ever. This means at least several years of confusion." - Bill Gates, founder and chairman of Microsoft, about the Open Systems Foundation
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#5 lore raw

PATCH 1/1 LZO: Add a LZO compression feature

Quoted 13 lines · Kyungmin Park
Quoted 11 lines · Wolfgang Denk
Quoted 6 lines · Kyungmin Park

There's request from other team. They want to transfer the binary but it's written as ubifs filesystem.
So download the binary to RAM and then mkfs.ubifs at this address and ubinize it finally.
Then write it to flash.
When mkfs.ubifs, it requires it.

You mean you want to add both support for ubinize and mkfs.ubifs to U-Boot? ?Would it not make more sense to boot a (minimal) Linux kernel for that purposes?

Quoted 6 lines

Umm it's maybe difficult. This team don't use the linux and don't have linux environment.
Only generate binary it and remaining job are done by each product team. The even worse there's no console when they are use it.

Enter the download mode and send the image to target.

so why dont you generate the ubifs on the development system and just transfer the image to the board ?
-mike