Skip to contentSkip to conversation

Build failure drivers/s390/net/ctcm_mpc.o

-next Oct 13 Sachin Sant 2 participants 2 messages Oct 13, 2010

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

Today's next fails to build on a s390 box with following error

drivers/s390/net/ctcm_mpc.c: In function ctc_mpc_dealloc_ch:
drivers/s390/net/ctcm_mpc.c:541: error: struct net_device has no member named refcnt

The code in question was changed by
commit 29b4433d991c88d86ca48a4c1cc33c671475be4b
net: percpu net_device refcount

The net_device struct member refcnt was changed from atomic_t to int __percpu.

Thanks
-Sachin

Signature · 6 lines
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
maintainer
#1 lore raw

From: Sachin Sant <[email protected]>
Date: Wed, 13 Oct 2010 20:39:16 +0530

Quoted 6 lines

Today's next fails to build on a s390 box with following error

drivers/s390/net/ctcm_mpc.c: In function ctc_mpc_dealloc_ch:
drivers/s390/net/ctcm_mpc.c:541: error: struct net_device has no member named refcnt

This should fix it:

--------------------
s390: ctcm_mpc: Fix build after netdev refcount changes.

---
 drivers/s390/net/ctcm_mpc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/s390/net/ctcm_mpc.c +1 -1
index 2861e78..b64881f 100644
@@ -540,7 +540,7 @@ void ctc_mpc_dealloc_ch(int port_num)
 
 	CTCM_DBF_TEXT_(MPC_SETUP, CTC_DBF_DEBUG,
 			"%s: %s: refcount = %d\n",
-			CTCM_FUNTAIL, dev->name, atomic_read(&dev->refcnt));
+			CTCM_FUNTAIL, dev->name, netdev_refcnt_read(dev));
 
 	fsm_deltimer(&priv->restart_timer);
 	grp->channels_terminating = 0;
Signature · 1 line
1.7.3.1