Skip to contentSkip to conversation

Ensure gd->ram_size end stays on 4k page boundary when 'hiding' RAM

PATCH New Gray Remlin 2 participants 2 messages Oct 15, 2010 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Ensure gd->ram_size end stays on 4k page boundary when 'hiding' RAM

---
 arch/arm/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/lib/board.c +1 -1
index 22bd2c9..2f0d5c4 100644
@@ -532,7 +532,7 @@ void board_init_f (ulong bootflag)
         * memory size from the SDRAM controller setup will have to
         * get fixed.
         */
-       gd->ram_size -= CONFIG_SYS_MEM_TOP_HIDE;
+       gd->ram_size -= roundup(CONFIG_SYS_MEM_TOP_HIDE, 4096);
 #endif
 
        addr = CONFIG_SYS_SDRAM_BASE + gd->ram_size;

--

#1 lore raw

PATCH v2 1/1 Ensure gd->ram_size end stays on 4k page boundary when 'hiding' RAM

Dear Gray Remlin,

Quoted 10 lines · In message <[email protected]> you wrote:
---
 arch/arm/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/lib/board.c +0 -0
index 22bd2c9..2f0d5c4 100644

arch/arm/lib/board.c void board_init_f (ulong bootflag) · line 538

Quoted 8 lines
arch/arm/lib/board.c +1 -1
@@ -532,7 +532,7 @@ void board_init_f (ulong bootflag)
         * memory size from the SDRAM controller setup will have to
         * get fixed.
         */
-       gd->ram_size -= CONFIG_SYS_MEM_TOP_HIDE;
+       gd->ram_size -= roundup(CONFIG_SYS_MEM_TOP_HIDE, 4096);
 #endif
 
        addr = CONFIG_SYS_SDRAM_BASE + gd->ram_size;

If such a change gets implemented, it should be implemented for PowerPC as well, plus the description in the README should be adjusted.

On the other hand, I can see no really good reason to implement such a fix, as the description in the README is precise enough about this item, and there is no good reason to assume that this feature would ever be enabled on any other systems but those with this specific PowerPC processor.

I recommend to just drop this patch.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
365 Days of drinking Lo-Cal beer.                       = 1 Lite-year