Skip to contentSkip to conversation

Old patches sent via the Mailing list

PATCH In review Mauro Carvalho Chehab 10 participants 22 messages Oct 17, 2010 – Nov 17, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth <[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth <[email protected]>

There are some patches where i want to have more tests/acks before applying:

  Aug, 7 2010: Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function  http://patchwork.kernel.org/patch/118147  Marko Ristola <[email protected]>
  Mar, 1 2010: firedtv: add parameter to fake ca_system_ids in CA_INFO                http://patchwork.kernel.org/patch/82912   Henrik Kurelid <[email protected]>

(I'm not sure about this one, Henrik's agument didn't convince me that we should add a workaround for MythTV)

I think that the better is to wait for videobuf2, instead of applying those patches:

  Mar,17 2010: [2/2] V4L/DVB: buf-dma-sg.c: support non-pageable user-allocated memor http://patchwork.kernel.org/patch/97263   Arnout Vandecappelle <[email protected]>
  Jul,27 2010: videobuf_dma_sg: a new implementation for mmap                         http://patchwork.kernel.org/patch/114520  Figo.zhang <[email protected]>
  Jul,28 2010: [v2] videobuf_dma_sg: a new implementation for mmap                    http://patchwork.kernel.org/patch/114760  Figo.zhang <[email protected]>
  Jul,30 2010: [v2] Resend:videobuf_dma_sg: a new implementation for mmap             http://patchwork.kernel.org/patch/115348  Figo.zhang <[email protected]>

Other than that, we have a pending list of older patches, submitted by someone, that I'm still waiting for the maintainer to take care. If I don't have any return from the maintainer for a patch older than, let's say, a month, is probably because it is safe for me to apply.

		== mantis patches - Waiting for Manu Abraham <[email protected]> == 
Apr,15 2010: [5/8] ir-core: convert mantis from ir-functions.c                      http://patchwork.kernel.org/patch/92961   David Härdeman <[email protected]>
Jun,20 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/107036  Marko Ristola <[email protected]>
Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files                             http://patchwork.kernel.org/patch/107062  Bjørn Mork <[email protected]>
Jun,20 2010: mantis: use dvb_attach to avoid double dereferencing on module removal http://patchwork.kernel.org/patch/107063  Bjørn Mork <[email protected]>
Jun,21 2010: Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make modules  http://patchwork.kernel.org/patch/107147  Manu Abraham <[email protected]>
Jul, 3 2010: mantis: Rename gpio_set_bits to mantis_gpio_set_bits                   http://patchwork.kernel.org/patch/109972  Ben Hutchings <[email protected]>
Jul, 8 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/110909  Marko Ristola <[email protected]>
Jul, 9 2010: Mantis: append tasklet maintenance for DVB stream delivery             http://patchwork.kernel.org/patch/111090  Marko Ristola <[email protected]>
Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245  Marko Ristola <[email protected]>
Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis)                                       http://patchwork.kernel.org/patch/112708  Niklas Claesson <[email protected]>
Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt     http://patchwork.kernel.org/patch/118173  Marko Ristola <[email protected]>
Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod   http://patchwork.kernel.org/patch/244201  Tuxoholic <[email protected]>
		== Soc_camera waiting for Guennadi Liakhovetski <[email protected]> review == 

(Guennadi gave me an update about those patches last time. I'm not sure about the updated status)

Jul, 5 2010: soc-camera: module_put() fix                                           http://patchwork.kernel.org/patch/110202  Magnus Damm <[email protected]>
Jul,27 2010: [1/4] mx2_camera: fix a race causing NULL dereference                  http://patchwork.kernel.org/patch/114515  Baruch Siach <[email protected]>
Jul,27 2010: [2/4] mx2_camera: return IRQ_NONE when doing nothing                   http://patchwork.kernel.org/patch/114517  Baruch Siach <[email protected]>
Jul,27 2010: [4/4] mx2_camera: implement forced termination of active buffer for mx http://patchwork.kernel.org/patch/114518  Baruch Siach <[email protected]>
Aug, 3 2010: [2/5] mx2_camera: remove emma limitation for RGB565                    http://patchwork.kernel.org/patch/116703  Michael Grzeschik <[email protected]>
Aug, 3 2010: [3/5] mx2_camera: fix for list bufnum in frame_done_emma               http://patchwork.kernel.org/patch/116705  Michael Grzeschik <[email protected]>
Aug, 3 2010: [4/5] mx2_camera: add rising edge for pixclock                         http://patchwork.kernel.org/patch/116704  Michael Grzeschik <[email protected]>
Aug, 3 2010: [5/5] mx2_camera: add informative camera clock frequency printout      http://patchwork.kernel.org/patch/116707  Michael Grzeschik <[email protected]>
Aug, 3 2010: [04/11] mt9m111: added new bit offset defines                          http://patchwork.kernel.org/patch/116721  Michael Grzeschik <[email protected]>
Aug, 3 2010: [06/11] mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE     http://patchwork.kernel.org/patch/116726  Michael Grzeschik <[email protected]>
Aug, 3 2010: [07/11] mt9m111: added current colorspace at g_fmt                     http://patchwork.kernel.org/patch/116724  Michael Grzeschik <[email protected]>
Aug, 3 2010: [08/11] mt9m111: added reg_mask function                               http://patchwork.kernel.org/patch/116722  Michael Grzeschik <[email protected]>
Aug, 3 2010: [v2,10/11] mt9m111: rewrite set_pixfmt                                 http://patchwork.kernel.org/patch/116728  Michael Grzeschik <[email protected]>
Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern                            http://patchwork.kernel.org/patch/116730  Michael Grzeschik <[email protected]>
		== Waiting for Antti Palosaari <[email protected]> review == 

Mar,21 2010: af9015 : more robust eeprom parsing http://patchwork.kernel.org/patch/87243 matthieu castet <[email protected]>

		== Waiting for Igor M. Liplianin <[email protected]> review == 

Mar,10 2010: DM1105: could not attach frontend 195d:1105 http://patchwork.kernel.org/patch/84549 Hendrik Skarpeid <[email protected]>

		== Waiting for Jarod Wilson <[email protected]> review/ack == 

Jun,20 2010: drivers/media/IR/imon.c: Use pr_err instead of err http://patchwork.kernel.org/patch/107025 Joe Perches <[email protected]>

		== Gspca patches - Waiting Jean-Francois Moine <[email protected]> review == 

Jul, 8 2010: video:gspca.c Fix warning: case value '7' not in enumerated type 'enum http://patchwork.kernel.org/patch/110779 Jean-Francois Moine <[email protected]>

		== Gspca patches - Waiting Hans de Goede <[email protected]> review == 

Jan,29 2010: [gspca_jf,tree] gspca zc3xx: signal when unknown packet received http://patchwork.kernel.org/patch/75837 Németh Márton <[email protected]>

		== Waiting for Patrick Boettcher <[email protected]> review == 
May,25 2010: Adding support to the Geniatech/MyGica SBTVD Stick S870 remote control http://patchwork.kernel.org/patch/102314  Hernán Ordiales <[email protected]>
Jul,14 2010: [1/4] drivers/media/dvb: Remove dead Configs                           http://patchwork.kernel.org/patch/111972  Christian Dietrich <[email protected]>
Jul,14 2010: [2/4] drivers/media/dvb: Remove undead configs                         http://patchwork.kernel.org/patch/111973  Christian Dietrich <[email protected]>

Cheers,
Mauro

#1 lore raw

Hi Mauro

Quoted 5 lines · Mauro Carvalho Chehab
		== Soc_camera waiting for Guennadi Liakhovetski <[email protected]> review == 

(Guennadi gave me an update about those patches last time. I'm not sure about the updated status)

Jul, 5 2010: soc-camera: module_put() fix http://patchwork.kernel.org/patch/110202 Magnus Damm <[email protected]>

Please, mark as dropped

Quoted 1 line

Jul,27 2010: [1/4] mx2_camera: fix a race causing NULL dereference http://patchwork.kernel.org/patch/114515 Baruch Siach <[email protected]>

is upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5384a12b23160e11ff949a94172051476d308b66

Quoted 1 line

Jul,27 2010: [2/4] mx2_camera: return IRQ_NONE when doing nothing http://patchwork.kernel.org/patch/114517 Baruch Siach <[email protected]>

mark as dropped

Quoted 1 line

Jul,27 2010: [4/4] mx2_camera: implement forced termination of active buffer for mx http://patchwork.kernel.org/patch/114518 Baruch Siach <[email protected]>

is in next
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=9cf6ddf5eeedaffd989f9b93df1b7ea8d459786b

Quoted 1 line

Aug, 3 2010: [2/5] mx2_camera: remove emma limitation for RGB565 http://patchwork.kernel.org/patch/116703 Michael Grzeschik <[email protected]>

is in next
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=2b262a18b79768a2b7a62ba187f8830802790b9a

Quoted 1 line

Aug, 3 2010: [3/5] mx2_camera: fix for list bufnum in frame_done_emma http://patchwork.kernel.org/patch/116705 Michael Grzeschik <[email protected]>

is upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cd9ebdbc0541b4e8ee145c81642d68332f79b932

Quoted 1 line

Aug, 3 2010: [4/5] mx2_camera: add rising edge for pixclock http://patchwork.kernel.org/patch/116704 Michael Grzeschik <[email protected]>

upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d86097e19cef2f13a29fc37db0dad17b99b6d5f8

Quoted 1 line

Aug, 3 2010: [5/5] mx2_camera: add informative camera clock frequency printout http://patchwork.kernel.org/patch/116707 Michael Grzeschik <[email protected]>

in next
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=e7d317b5b210a2f9486faa335e4eff81e5f6210d

Quoted 1 line

Aug, 3 2010: [04/11] mt9m111: added new bit offset defines http://patchwork.kernel.org/patch/116721 Michael Grzeschik <[email protected]>

waiting an update (possible merge with 08/11 and 10/11 below)

Quoted 1 line

Aug, 3 2010: [06/11] mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE http://patchwork.kernel.org/patch/116726 Michael Grzeschik <[email protected]>

upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6b6d33c746ace7bd0dbbdde674d3fb1100ab081d

Quoted 1 line

Aug, 3 2010: [07/11] mt9m111: added current colorspace at g_fmt http://patchwork.kernel.org/patch/116724 Michael Grzeschik <[email protected]>

upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=01f5a394eac48b74c84434e95e74cd172b0682c3

Quoted 1 line

Aug, 3 2010: [08/11] mt9m111: added reg_mask function http://patchwork.kernel.org/patch/116722 Michael Grzeschik <[email protected]>

waiting for update (see 04/11 above)

Quoted 1 line

Aug, 3 2010: [v2,10/11] mt9m111: rewrite set_pixfmt http://patchwork.kernel.org/patch/116728 Michael Grzeschik <[email protected]>

waiting for update (see 04/11 above)

Quoted 1 line

Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern http://patchwork.kernel.org/patch/116730 Michael Grzeschik <[email protected]>

waiting for a new version, using additional inputs to provide test patterns.

Somehow, looks like patches, that I push to you, don't (automatically) get updated in patchwork, is there anything, that I'm doing wrongly, why this is happening?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#2 lore raw

Em 17-10-2010 20:03, Guennadi Liakhovetski escreveu:

Quoted 64 lines

Hi Mauro

Quoted 5 lines · Mauro Carvalho Chehab
		== Soc_camera waiting for Guennadi Liakhovetski <[email protected]> review == 

(Guennadi gave me an update about those patches last time. I'm not sure about the updated status)

Jul, 5 2010: soc-camera: module_put() fix http://patchwork.kernel.org/patch/110202 Magnus Damm <[email protected]>

Please, mark as dropped

Quoted 1 line

Jul,27 2010: [1/4] mx2_camera: fix a race causing NULL dereference http://patchwork.kernel.org/patch/114515 Baruch Siach <[email protected]>

is upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5384a12b23160e11ff949a94172051476d308b66

Quoted 1 line

Jul,27 2010: [2/4] mx2_camera: return IRQ_NONE when doing nothing http://patchwork.kernel.org/patch/114517 Baruch Siach <[email protected]>

mark as dropped

Quoted 1 line

Jul,27 2010: [4/4] mx2_camera: implement forced termination of active buffer for mx http://patchwork.kernel.org/patch/114518 Baruch Siach <[email protected]>

is in next
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=9cf6ddf5eeedaffd989f9b93df1b7ea8d459786b

Quoted 1 line

Aug, 3 2010: [2/5] mx2_camera: remove emma limitation for RGB565 http://patchwork.kernel.org/patch/116703 Michael Grzeschik <[email protected]>

is in next
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=2b262a18b79768a2b7a62ba187f8830802790b9a

Quoted 1 line

Aug, 3 2010: [3/5] mx2_camera: fix for list bufnum in frame_done_emma http://patchwork.kernel.org/patch/116705 Michael Grzeschik <[email protected]>

is upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cd9ebdbc0541b4e8ee145c81642d68332f79b932

Quoted 1 line

Aug, 3 2010: [4/5] mx2_camera: add rising edge for pixclock http://patchwork.kernel.org/patch/116704 Michael Grzeschik <[email protected]>

upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d86097e19cef2f13a29fc37db0dad17b99b6d5f8

Quoted 1 line

Aug, 3 2010: [5/5] mx2_camera: add informative camera clock frequency printout http://patchwork.kernel.org/patch/116707 Michael Grzeschik <[email protected]>

in next
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=e7d317b5b210a2f9486faa335e4eff81e5f6210d

Quoted 1 line

Aug, 3 2010: [04/11] mt9m111: added new bit offset defines http://patchwork.kernel.org/patch/116721 Michael Grzeschik <[email protected]>

waiting an update (possible merge with 08/11 and 10/11 below)

Quoted 1 line

Aug, 3 2010: [06/11] mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE http://patchwork.kernel.org/patch/116726 Michael Grzeschik <[email protected]>

upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6b6d33c746ace7bd0dbbdde674d3fb1100ab081d

Quoted 1 line

Aug, 3 2010: [07/11] mt9m111: added current colorspace at g_fmt http://patchwork.kernel.org/patch/116724 Michael Grzeschik <[email protected]>

upstream
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=01f5a394eac48b74c84434e95e74cd172b0682c3

Quoted 1 line

Aug, 3 2010: [08/11] mt9m111: added reg_mask function http://patchwork.kernel.org/patch/116722 Michael Grzeschik <[email protected]>

waiting for update (see 04/11 above)

Quoted 8 lines
Quoted 1 line

Aug, 3 2010: [v2,10/11] mt9m111: rewrite set_pixfmt http://patchwork.kernel.org/patch/116728 Michael Grzeschik <[email protected]>

waiting for update (see 04/11 above)

Quoted 1 line

Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern http://patchwork.kernel.org/patch/116730 Michael Grzeschik <[email protected]>

waiting for a new version, using additional inputs to provide test patterns.

Updated, thanks!

Quoted 4 lines

Somehow, looks like patches, that I push to you, don't (automatically) get updated in patchwork, is there anything, that I'm doing wrongly, why this is happening?

Unfortunately, they're not updated automatically. There's no easy way to discover when a patch at a pull request were also sent to the ML. I need to do it manually.

In fact, there's an easy way to allow me to automatically update the patchwork ID. All you need is to add:

X-Patchwork-Id: <ID>

in the body of the email. My scripts use this tag to mark a patch as accepted/rejected when I accept/reject a patch, as this tag is generated by patchwork.

Thanks,
Mauro

#3 lore raw
In reply to Mauro Carvalho Chehab
Quoted 13 lines · Mauro Carvalho Chehab

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 6 lines
Quoted 1 line

From the list of patches under review, we have:

		== Waiting for Antti Palosaari<[email protected]>  review ==

Mar,21 2010: af9015 : more robust eeprom parsing http://patchwork.kernel.org/patch/87243 matthieu castet<[email protected]>

Mark as dropped.

Antti

Signature · 1 line
http://palosaari.fi/
#4 lore raw

Em 17-10-2010 20:27, Antti Palosaari escreveu:

Quoted 17 lines · Mauro Carvalho Chehab
Quoted 15 lines

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Quoted 6 lines
Quoted 3 lines
        == Waiting for Antti Palosaari<[email protected]>  review ==

Mar,21 2010: af9015 : more robust eeprom parsing http://patchwork.kernel.org/patch/87243 matthieu castet<[email protected]>

Mark as dropped.

Done. Thanks!

#5 lore raw
In reply to Mauro Carvalho Chehab
Quoted 9 lines · Mauro Carvalho Chehab

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

Quoted 8 lines

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth <[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth <[email protected]>

Sven,

We need a "Signed-off-by: " for your submitted patch:

http://www.linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work

Note, your patch has an obvious, unintentional white space change for "if (std == V4L2_STD_NTSC_M_JP)", so could you fix that up and send a new signed off version?

Mauro,

This patch makes obvious sense to me: don't perform audio register updates on a chip that doesn't have an audio processing block. Sven's approach was based on my recommended approach, after his initial discovery on how to get his audio working.

Do we really need an S.O.B for something that appears to be common sense, and wouldn't have been implemented any other way, even if I had implemented it?

Regards,
Andy

#6 lore raw

Em 17-10-2010 21:36, Andy Walls escreveu:

Quoted 32 lines · Mauro Carvalho Chehab
Quoted 9 lines

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

Quoted 8 lines

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth <[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth <[email protected]>

Sven,

We need a "Signed-off-by: " for your submitted patch:

http://www.linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work

Note, your patch has an obvious, unintentional white space change for "if (std == V4L2_STD_NTSC_M_JP)", so could you fix that up and send a new signed off version?

Mauro,

Quoted 8 lines

This patch makes obvious sense to me: don't perform audio register updates on a chip that doesn't have an audio processing block. Sven's approach was based on my recommended approach, after his initial discovery on how to get his audio working.

Do we really need an S.O.B for something that appears to be common sense, and wouldn't have been implemented any other way, even if I had implemented it?

The original patch were in the middle of a discussion, no proper description, bad whitespacing, etc. It is better to let the patch author to fix those issues, as they learn more about how to submit a patch.

Anyway, I agree with you, the patch is obvious, and can proceed without the SOB. I did the usual CodingStyle fixups, put part of your above comment as the patch description, together with your ack and moved it forward. One patch less on my queue ;)

Cheers,
Mauro

#7 lore raw

Am 18.10.2010 08:15, schrieb Mauro Carvalho Chehab:

Quoted 46 lines

Em 17-10-2010 21:36, Andy Walls escreveu:

Quoted 32 lines · Mauro Carvalho Chehab
Quoted 9 lines

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

Quoted 8 lines

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth<[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth<[email protected]>

Sven,

We need a "Signed-off-by: " for your submitted patch:

http://www.linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work

Note, your patch has an obvious, unintentional white space change for "if (std == V4L2_STD_NTSC_M_JP)", so could you fix that up and send a new signed off version?

Mauro,

Quoted 8 lines

This patch makes obvious sense to me: don't perform audio register updates on a chip that doesn't have an audio processing block. Sven's approach was based on my recommended approach, after his initial discovery on how to get his audio working.

Do we really need an S.O.B for something that appears to be common sense, and wouldn't have been implemented any other way, even if I had implemented it?

The original patch were in the middle of a discussion, no proper description, bad whitespacing, etc. It is better to let the patch author to fix those issues, as they learn more about how to submit a patch.

Quoted 6 lines

Anyway, I agree with you, the patch is obvious, and can proceed without the SOB. I did the usual CodingStyle fixups, put part of your above comment as the patch description, together with your ack and moved it forward. One patch less on my queue ;)

Cheers,
Mauro

Eh... I thought I had superseeded it with the patch from 10th July (mail title: [PATCH] Add support for AUX_PLL on cx2583x chips). It included a "Signed-of by" from me as well as "Acked by" from Mike and Andy and I also excluded the whitespace change ^^

Regards,
Sven

#8 lore raw
Quoted 23 lines · Sven Barth

Am 18.10.2010 08:15, schrieb Mauro Carvalho Chehab:

Quoted 20 lines

Em 17-10-2010 21:36, Andy Walls escreveu:

Quoted 18 lines
Quoted 8 lines

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth<[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth<[email protected]>

Sven,

We need a "Signed-off-by: " for your submitted patch:

http://www.linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work

Note, your patch has an obvious, unintentional white space change for "if (std == V4L2_STD_NTSC_M_JP)", so could you fix that up and send a new signed off version?

Quoted 4 lines

Eh... I thought I had superseeded it with the patch from 10th July (mail
title: [PATCH] Add support for AUX_PLL on cx2583x chips). It included a "Signed-of by" from me as well as "Acked by" from Mike and Andy and I also excluded the whitespace change ^^

Hi Sven,

http://www.mail-archive.com/[email protected]/msg20296.html

So you have. How embarrassing. <:}

Thanks,
Andy

#9 lore raw
Quoted 29 lines · Andy Walls
Quoted 23 lines · Sven Barth

Am 18.10.2010 08:15, schrieb Mauro Carvalho Chehab:

Quoted 20 lines

Em 17-10-2010 21:36, Andy Walls escreveu:

Quoted 18 lines
Quoted 8 lines

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth<[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth<[email protected]>

Sven,

We need a "Signed-off-by: " for your submitted patch:

http://www.linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work

Note, your patch has an obvious, unintentional white space change for "if (std == V4L2_STD_NTSC_M_JP)", so could you fix that up and send a new signed off version?

Quoted 4 lines

Eh... I thought I had superseeded it with the patch from 10th July (mail
title: [PATCH] Add support for AUX_PLL on cx2583x chips). It included a "Signed-of by" from me as well as "Acked by" from Mike and Andy and I also excluded the whitespace change ^^

Quoted 5 lines

Hi Sven,

http://www.mail-archive.com/[email protected]/msg20296.html

So you have. How embarrassing.<:}

Well... it's a bit hard to keep the overview in this list. ;) I only saw this thread about "old patches" by pure luck.

And thank you for digging up the link, I only had the mail version lying around.

[And finally I won't have to patch v4l manually anymore... yippieh! I'm looking forward to 2.6.37 :D (Good that I use a distro (ArchLinux) that has a rolling release style ^^) ]

Regards,
Sven

#10 lore raw

Em 20-10-2010 16:01, Sven Barth escreveu:

Quoted 34 lines · Andy Walls
Quoted 33 lines · Sven Barth
Quoted 23 lines

Am 18.10.2010 08:15, schrieb Mauro Carvalho Chehab:

Quoted 20 lines

Em 17-10-2010 21:36, Andy Walls escreveu:

Quoted 18 lines
Quoted 8 lines

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

Quoted 1 line

From the list of patches under review, we have:

Waiting for new patch, signed, from Sven Barth<[email protected]>
Apr,25 2010: Problem with cx25840 and Terratec Grabster AV400 http://patchwork.kernel.org/patch/94960 Sven Barth<[email protected]>

Sven,

We need a "Signed-off-by: " for your submitted patch:

http://www.linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Sign_your_work

Note, your patch has an obvious, unintentional white space change for "if (std == V4L2_STD_NTSC_M_JP)", so could you fix that up and send a new signed off version?

Quoted 4 lines

Eh... I thought I had superseeded it with the patch from 10th July (mail
title: [PATCH] Add support for AUX_PLL on cx2583x chips). It included a "Signed-of by" from me as well as "Acked by" from Mike and Andy and I also excluded the whitespace change ^^

Hi Sven,

http://www.mail-archive.com/[email protected]/msg20296.html

Quoted 8 lines
Quoted 1 line

So you have. How embarrassing.<:}

Well... it's a bit hard to keep the overview in this list. ;) I only saw this thread about "old patches" by pure luck.

And thank you for digging up the link, I only had the mail version lying around.

[And finally I won't have to patch v4l manually anymore... yippieh! I'm looking forward to 2.6.37 :D (Good that I use a distro (ArchLinux) that has a rolling release style ^^) ]

OK, I've replaced the non-signed patch to the signed one, at the new branch I've created for the patches that I'll send during the merge window (staging/v2.6.37-rc1).

The reason why the new patch were not catched is that the emailer broke long lines on your patch, so, patchwork didn't catch it.

Please, next time, be sure that you'll submit your patch with an emailer that don't break long lines.

Thanks,
Mauro

#12 lore raw

Em 18-10-2010 02:27, Németh Márton escreveu:

Quoted 9 lines
Quoted 3 lines · Mauro Carvalho Chehab
		== Gspca patches - Waiting Hans de Goede <[email protected]> review == 

Jan,29 2010: [gspca_jf,tree] gspca zc3xx: signal when unknown packet received http://patchwork.kernel.org/patch/75837 Németh Márton <[email protected]>

This was NACKed by Hans de Goede, as the pachwork link shows. Please drop it.

Márton Németh

Updated,
thanks!

Cheers,
Mauro

#13 lore raw
In reply to Mauro Carvalho Chehab
Quoted 6 lines · On Sun, 17 Oct 2010 19:20:31 -0200 Mauro Carvalho Chehab <[email protected]>…
		== Gspca patches - Waiting Jean-Francois Moine

<[email protected]> review ==

Jul, 8 2010: video:gspca.c Fix warning: case value '7' not in enumerated type 'enum http://patchwork.kernel.org/patch/110779
Jean-Francois Moine <[email protected]>

Hi Mauro,

This patch is already applied.

Cheers.

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#14 lore raw

Em 18-10-2010 04:34, Jean-Francois Moine escreveu:

Quoted 6 lines
Quoted 3 lines · On Sun, 17 Oct 2010 19:20:31 -0200 Mauro Carvalho Chehab <[email protected]>…
		== Gspca patches - Waiting Jean-Francois Moine

<[email protected]> review ==

Quoted 7 lines
Quoted 3 lines

Jul, 8 2010: video:gspca.c Fix warning: case value '7' not in enumerated type 'enum http://patchwork.kernel.org/patch/110779
Jean-Francois Moine <[email protected]>

Hi Mauro,

This patch is already applied.

Updated, thanks!

Quoted 3 lines

Cheers.

#15 lore raw
In reply to Mauro Carvalho Chehab
Quoted 14 lines · Mauro Carvalho Chehab

Hi,

I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests (mostly related to more kABI changes), there are still a list of patches that are marked as Under review. Except for 4 patches from me, related to Doc (that I'm keeping in this list just to remind me that I'll need to fix them when I have some time - just some automation stuff at DocBook), all other patches marked as Under review are stuff that I basically depend on others.

The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I suspect that, for the list bellow, most of them are stuff where the driver maintainer just forgot at limbo.

From the list of patches under review, we have:

...

Quoted 3 lines
		== Waiting for Jarod Wilson <[email protected]> review/ack == 

Jun,20 2010: drivers/media/IR/imon.c: Use pr_err instead of err http://patchwork.kernel.org/patch/107025 Joe Perches <[email protected]>

Acked.

Signature · 2 lines
Jarod Wilson
[email protected]
#16 lore raw

PATCH 1/1 mantis for_2.6.38

In reply to Mauro Carvalho Chehab

Hello,

I've been waiting for this list of patchwork patches to be included for quite a while, and have now taken the liberty to clean them up as necessary and add them to a git tree, based on the current media_tree for_v2.6.38 branch, with exceptions as noted below:

Quoted 3 lines
		== mantis patches - Waiting for Manu Abraham <[email protected]> == 

Apr,15 2010: [5/8] ir-core: convert mantis from ir-functions.c http://patchwork.kernel.org/patch/92961 David Härdeman <[email protected]>

already applied as commit f0bdee26a2dc904c463bae1c2ae9ad06f97f100d

Quoted 1 line

Jun,20 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/107036 Marko Ristola <[email protected]>

duplicate of http://patchwork.kernel.org/patch/118173

Quoted 5 lines
Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files                             http://patchwork.kernel.org/patch/107062  Bjørn Mork <[email protected]>
Jun,20 2010: mantis: use dvb_attach to avoid double dereferencing on module removal http://patchwork.kernel.org/patch/107063  Bjørn Mork <[email protected]>
Jun,21 2010: Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make modules  http://patchwork.kernel.org/patch/107147  Manu Abraham <[email protected]>
Jul, 3 2010: mantis: Rename gpio_set_bits to mantis_gpio_set_bits                   http://patchwork.kernel.org/patch/109972  Ben Hutchings <[email protected]>
Jul, 8 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/110909  Marko Ristola <[email protected]>

another duplicate of http://patchwork.kernel.org/patch/118173

Quoted 3 lines
Jul, 9 2010: Mantis: append tasklet maintenance for DVB stream delivery             http://patchwork.kernel.org/patch/111090  Marko Ristola <[email protected]>
Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245  Marko Ristola <[email protected]>
Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis)                                       http://patchwork.kernel.org/patch/112708  Niklas Claesson <[email protected]>

Missing Signed-off-by, and I'm also a bit confused wrt what the patch actually is. Needs further cleanup.

Quoted 2 lines
Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt     http://patchwork.kernel.org/patch/118173  Marko Ristola <[email protected]>
Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod   http://patchwork.kernel.org/patch/244201  Tuxoholic <[email protected]>

The following changes since commit

af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3 [media] IR: add tv power scancode to rc6 mce keymap

are available in the git repository at:

git://git.mork.no/mantis.git for_2.6.38

Ben Hutchings (1):
V4L/DVB: mantis: Rename gpio_set_bits to mantis_gpio_set_bits

Bjørn Mork (2):
V4L/DVB: mantis: use dvb_attach to avoid double dereferencing on module removal V4L/DVB/V4L: mantis: remove unused files

Manu Abraham (1):
Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make modules auto-loadable

Marko Ristola (3):
V4L/DVB: mantis: append tasklet maintenance for DVB stream delivery Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt
media: mantis: use interrupt for I2C traffic instead of busy registry polling

[email protected] (1):
V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod

 drivers/media/dvb/frontends/stb0899_algo.c |   33 +++--
 drivers/media/dvb/mantis/hopper_cards.c    |    4 +-
 drivers/media/dvb/mantis/hopper_vp3028.c   |    6 +-
 drivers/media/dvb/mantis/mantis_cards.c    |   18 ++-
 drivers/media/dvb/mantis/mantis_common.h   |    9 +-
 drivers/media/dvb/mantis/mantis_core.c     |  235 ----------------------------
 drivers/media/dvb/mantis/mantis_core.h     |   57 -------
 drivers/media/dvb/mantis/mantis_dma.c      |   92 ++++-------
 drivers/media/dvb/mantis/mantis_dvb.c      |   17 ++-
 drivers/media/dvb/mantis/mantis_i2c.c      |  128 ++++++++++++----
 drivers/media/dvb/mantis/mantis_ioc.c      |    4 +-
 drivers/media/dvb/mantis/mantis_ioc.h      |    2 +-
 drivers/media/dvb/mantis/mantis_vp1033.c   |    2 +-
 drivers/media/dvb/mantis/mantis_vp1034.c   |   10 +-
 drivers/media/dvb/mantis/mantis_vp1041.c   |    6 +-
 drivers/media/dvb/mantis/mantis_vp2033.c   |    5 +-
 drivers/media/dvb/mantis/mantis_vp2040.c   |    4 +-
 drivers/media/dvb/mantis/mantis_vp3030.c   |    8 +-
 18 files changed, 208 insertions(+), 432 deletions(-)

Note that some of these patches will trigger checkpatch long line warnings due to deliberate choices. I have no strong feelings about reformatting them, but I believe the review is easier the less I have changed the original patchworks patch...

I sincerely hope this will make your job easier. Thanks for reviewing,

Bjørn

#17 lore raw

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

Em 12-11-2010 12:43, Bjørn Mork escreveu:

Quoted 23 lines

Hello,

I've been waiting for this list of patchwork patches to be included for quite a while, and have now taken the liberty to clean them up as necessary and add them to a git tree, based on the current media_tree for_v2.6.38 branch, with exceptions as noted below:

Quoted 3 lines
		== mantis patches - Waiting for Manu Abraham <[email protected]> == 

Apr,15 2010: [5/8] ir-core: convert mantis from ir-functions.c http://patchwork.kernel.org/patch/92961 David Härdeman <[email protected]>

already applied as commit f0bdee26a2dc904c463bae1c2ae9ad06f97f100d

Quoted 1 line

Jun,20 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/107036 Marko Ristola <[email protected]>

duplicate of http://patchwork.kernel.org/patch/118173

Quoted 5 lines
Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files                             http://patchwork.kernel.org/patch/107062  Bjørn Mork <[email protected]>
Jun,20 2010: mantis: use dvb_attach to avoid double dereferencing on module removal http://patchwork.kernel.org/patch/107063  Bjørn Mork <[email protected]>
Jun,21 2010: Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make modules  http://patchwork.kernel.org/patch/107147  Manu Abraham <[email protected]>
Jul, 3 2010: mantis: Rename gpio_set_bits to mantis_gpio_set_bits                   http://patchwork.kernel.org/patch/109972  Ben Hutchings <[email protected]>
Jul, 8 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/110909  Marko Ristola <[email protected]>
Quoted 12 lines

another duplicate of http://patchwork.kernel.org/patch/118173

Quoted 3 lines
Jul, 9 2010: Mantis: append tasklet maintenance for DVB stream delivery             http://patchwork.kernel.org/patch/111090  Marko Ristola <[email protected]>
Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245  Marko Ristola <[email protected]>
Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis)                                       http://patchwork.kernel.org/patch/112708  Niklas Claesson <[email protected]>

Missing Signed-off-by, and I'm also a bit confused wrt what the patch actually is. Needs further cleanup.

Quoted 2 lines
Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt     http://patchwork.kernel.org/patch/118173  Marko Ristola <[email protected]>
Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod   http://patchwork.kernel.org/patch/244201  Tuxoholic <[email protected]>

Patchwork updated. Thanks for checking those duplicated stuff.

Quoted 9 lines

The following changes since commit

af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3 [media] IR: add tv power scancode to rc6 mce keymap

are available in the git repository at:

git://git.mork.no/mantis.git for_2.6.38

Didn't work:

git pull git://git.mork.no/mantis.git for_2.6.38
fatal: Couldn't find remote ref for_2.6.38

Cheers,
Mauro

#18 lore raw

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

Quoted 8 lines · Mauro Carvalho Chehab

Em 12-11-2010 12:43, Bjørn Mork escreveu:

Quoted 2 lines

git://git.mork.no/mantis.git for_2.6.38

Didn't work:

git pull git://git.mork.no/mantis.git for_2.6.38
fatal: Couldn't find remote ref for_2.6.38

Damn, sorry about that. Was supposed to be

git://git.mork.no/mantis.git for_v2.6.38

Bjørn

#19 lore raw

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

Hi Bjørn,

Em 13-11-2010 12:45, Bjørn Mork escreveu:

Quoted 6 lines
Quoted 4 lines · Mauro Carvalho Chehab

Em 12-11-2010 12:43, Bjørn Mork escreveu:

Quoted 2 lines

git://git.mork.no/mantis.git for_2.6.38

Quoted 8 lines
Quoted 4 lines

Didn't work:

git pull git://git.mork.no/mantis.git for_2.6.38
fatal: Couldn't find remote ref for_2.6.38

Damn, sorry about that. Was supposed to be

git://git.mork.no/mantis.git for_v2.6.38

Except when drivers are not maintained anymore (or when the patch is trivial), I wait for the driver author(s) to test the patches and ask me to pull (or for them to reply that a patch is ok with his ack).

Manu sent a pull request with some of the long-standing Mantis patches tested plus with some improvements for the frontend tuning. I've applied them today.

Please test, and give us a feedback.

Thanks,
Mauro

#20 lore raw

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

In reply to Mauro Carvalho Chehab

Hi Bjørn Mork and Mauro Carvalho Chehab.

The following patch was an experiment and wasn't actually meant for inclusion into the Kernel.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245 Marko Ristola <[email protected]>

Would you please drop it from the Patchwork?
Would you Bjørn remove it from your Git repository?
The patch is ugly and it doesn't work, the broken part is active only with vp2033.

I'm sorry for the hassle.
Cheers, Marko Ristola

Quoted 20 lines · Mauro Carvalho Chehab

Em 12-11-2010 12:43, Bjørn Mork escreveu:

Quoted 18 lines

Hello,

I've been waiting for this list of patchwork patches to be included for quite a while, and have now taken the liberty to clean them up as necessary and add them to a git tree, based on the current media_tree for_v2.6.38 branch, with exceptions as noted below:

Quoted 3 lines
		== mantis patches - Waiting for Manu Abraham <[email protected]> == 

Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245 Marko Ristola <[email protected]>

The following changes since commit

af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3 [media] IR: add tv power scancode to rc6 mce keymap

are available in the git repository at:

git://git.mork.no/mantis.git for_2.6.38

#21 lore raw

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

Em 17-11-2010 17:43, Marko Ristola escreveu:

Quoted 8 lines

Hi Bjørn Mork and Mauro Carvalho Chehab.

The following patch was an experiment and wasn't actually meant for inclusion into the Kernel.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245 Marko Ristola <[email protected]>

Would you please drop it from the Patchwork?

Updated, thanks.

Cheers,
Mauro