Skip to contentSkip to conversation

cacaoh: patches to get do_install do its work

PATCH In review Jaap de Jong 4 participants 12 messages Oct 22, 2010 – Oct 28, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cacaoh: patches to get do_install do its work

From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
From: Jaap de Jong <[email protected]>
Date: Fri, 22 Oct 2010 09:28:25 +0200
Subject: [PATCH] cacaoh: patches to get do_install do its work

---
 recipes/cacao/cacaoh-cldc-native_0.98.bb |    2 +-
 recipes/cacao/cacaoh-native.inc          |    2 +-
 recipes/cacao/cacaoh-openjdk-native.inc  |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
recipes/cacao/cacaoh-cldc-native_0.98.bb +1 -1
index 9a34b36..44b81fe 100644
@@ -5,7 +5,7 @@ SRC_URI = "\
   "
 
 do_stage() {
-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
 }
 
 SRC_URI[md5sum] = "8b8907c8b925761c9410bcadb9705346"
recipes/cacao/cacaoh-native.inc +1 -1
index 2b3709f..d745107 100644
@@ -24,7 +24,7 @@ do_compile() {
 
 do_install() {
   install -d ${D}${bindir}/cacaoh-${PV}
-  install -m 0755 src/cacaoh/.libs/cacaoh ${D}${bindir}/cacaoh-${PV}
+  install -m 0755 src/cacaoh/cacaoh ${D}${bindir}/cacaoh-${PV}
 }
 
 NATIVE_INSTALL_WORKS = "1"
recipes/cacao/cacaoh-openjdk-native.inc +1 -1
index 5070e7e..4afb955 100644
@@ -27,5 +27,5 @@ do_compile() {
 }
 
 do_install() {
-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-openjdk-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-openjdk-${PV}
 }
Signature · 1 line
1.7.1
#1 lore raw

recipes/cacao/cacaoh-cldc-native_0.98.bb SRC_URI = "\ · line 8

Quoted 2 lines · Jaap de Jong
recipes/cacao/cacaoh-cldc-native_0.98.bb +1 -1
-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

This is the wrong way to install libtool binaries/libraries. Please use 'libtool --mode=install install -m ...' (or the platform prefixed 'libtool' program).

Enrico

#2 lore raw
Quoted 9 lines · Enrico Scholz
Quoted 2 lines · Jaap de Jong

-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

This is the wrong way to install libtool binaries/libraries.  Please use 'libtool --mode=install install -m ...' (or the platform prefixed 'libtool' program).

whats the difference ?

Quoted 8 lines

Enrico

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 8 lines · Khem Raj
Quoted 6 lines
Quoted 2 lines

-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

This is the wrong way to install libtool binaries/libraries.  Please use 'libtool --mode=install install -m ...' (or the platform prefixed 'libtool' program).

whats the difference ?

* 'libtool --mode=install' is the documented way[1] to install libtool binaries (in case of libraries, a 'libtool --mode=finish' might be required too)

* libtool creates sometimes a wrapper script for executables (e.g. when they are linked against local libraries) and places the real executable in .libs/. Manually installing one of them is error prone and it might break with other linker flags or libtool versions.

Enrico

Footnotes:
[1] info libtool -> Installing libraries + Installing executables

#4 lore raw
Quoted 11 lines · Enrico Scholz
Quoted 9 lines · Khem Raj
Quoted 8 lines
Quoted 4 lines

- install -m 0755 src/cacaoh/.libs/cacaoh
${STAGING_BINDIR}/cacaoh-cldc-${PV}
+ install -m 0755 src/cacaoh/cacaoh
${STAGING_BINDIR}/cacaoh-cldc-${PV}

This is the wrong way to install libtool binaries/libraries. Please use 'libtool --mode=install install -m ...' (or the platform prefixed 'libtool' program).

Quoted 5 lines
Quoted 1 line

whats the difference ?

* 'libtool --mode=install' is the documented way[1] to install libtool binaries (in case of libraries, a 'libtool --mode=finish' might be required too)

that should not be a problem here as its not a library and does not have .la files to be fixed.

Quoted 6 lines

* libtool creates sometimes a wrapper script for executables (e.g. when they are linked against local libraries) and places the real executable in .libs/. Manually installing one of them is error prone and it might break with other linker flags or libtool versions.

the binary in .libs do not exist so the link is final in this case. but in any case If you can come up with a patch to install it using libtool that would be nice.

Quoted 12 lines

Enrico

Footnotes:
[1] info libtool -> Installing libraries + Installing executables

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
-Khem
#5 lore raw
Quoted 9 lines · Khem Raj
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

recipes/cacao/cacaoh-cldc-native_0.98.bb SRC_URI = "\ · line 8

Quoted 2 lines
recipes/cacao/cacaoh-cldc-native_0.98.bb +1 -1
-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

* libtool creates sometimes a wrapper script for executables (e.g. when they are linked against local libraries) and places the real executable in .libs/. Manually installing one of them is error prone and it might break with other linker flags or libtool versions.

the binary in .libs do not exist so the link is final in this case.

Really? The author of the original recipe had an environment where the executable was in .libs/. Are you really sure that such an environment does not exist anymore? Or will the recipe now silently fail by installing the shell wrapper sometimes?

Quoted 2 lines

but in any case If you can come up with a patch to install it using libtool that would be nice.

Sorry; providing a patch means testing it (regardless whether it is trivial). Here, I am not sure whether 'libtool' or the platform prefixed '<arch>-libtool' is required and how to express '<arch>-libtool' in oe.

I gave my comment to a patch which fixed a broken recipe by replacing it with another broken recipe. So I expect that the author of this patch fixes and tests his work.

For completeness; install command should be

| libtool --mode=install install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

Enrico

#7 lore raw
In reply to Jaap de Jong

Hello.

Quoted 6 lines · Jaap de Jong

From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
From: Jaap de Jong <[email protected]>
Date: Fri, 22 Oct 2010 09:28:25 +0200
Subject: [PATCH] cacaoh: patches to get do_install do its work

This patch broke the openjdk-6 testing build for me. Openjdk did not compile due to missing header files.

This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using angstrom-2010 and therefor the 2.4 libtool?

I will start a fresh build on master instead testing-next now and then we need to see how we could handle this regression.

regards
Stefan Schmidt

#8 lore raw
Quoted 8 lines · Stefan Schmidt

Hello.

Quoted 5 lines · Jaap de Jong

From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
From: Jaap de Jong <[email protected]>
Date: Fri, 22 Oct 2010 09:28:25 +0200
Subject: [PATCH] cacaoh: patches to get do_install do its work

Quoted 8 lines
Quoted 1 line

This patch broke the openjdk-6 testing build for me. Openjdk did not compile due to missing header files.

This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using angstrom-2010 and therefor the 2.4 libtool?

I tested it with both 2.2 ad 2.4 libtools but what Enrico suggested might be a better fix.

Quoted 11 lines

I will start a fresh build on master instead testing-next now and then we need to see how we could handle this regression.

regards
Stefan Schmidt

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#9 lore raw

Hello.

Quoted 14 lines · Khem Raj
Quoted 12 lines · Stefan Schmidt
Quoted 6 lines · Jaap de Jong

From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
From: Jaap de Jong <[email protected]>
Date: Fri, 22 Oct 2010 09:28:25 +0200
Subject: [PATCH] cacaoh: patches to get do_install do its work

This patch broke the openjdk-6 testing build for me. Openjdk did not compile due to missing header files.

Quoted 6 lines
Quoted 3 lines

This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using angstrom-2010 and therefor the 2.4 libtool?

I tested it with both 2.2 ad 2.4 libtools but what Enrico suggested might be a better fix.

Hmm, that works against my theory. :)

I need to wait until my build on master is ready and if it fails as well I try to implement Enricos suggestion.

regards
Stefan Schmidt

#10 lore raw

Hi,
my initial patch was only intended to show the error I got while building openjdk-6 and I hoped to trigger the maintainers to get it fixed. If this patch has caused any inconvenience to anyone, I apologize for that.
Jaap

Quoted 32 lines · Stefan Schmidt

Hello.

Quoted 9 lines · Khem Raj
Quoted 7 lines · Stefan Schmidt
Quoted 6 lines · Jaap de Jong

From 60a5f60af4ad65112452f98d99350fce45332e8e Mon Sep 17 00:00:00 2001
From: Jaap de Jong<[email protected]>
Date: Fri, 22 Oct 2010 09:28:25 +0200
Subject: [PATCH] cacaoh: patches to get do_install do its work

Quoted 8 lines
Quoted 6 lines

This patch broke the openjdk-6 testing build for me. Openjdk did not compile due to missing header files.

This is with angstrom-2008.1 so no libtool 2.4. I guess that you are using angstrom-2010 and therefor the 2.4 libtool?

I tested it with both 2.2 ad 2.4 libtools but what Enrico suggested might be a better fix.

Hmm, that works against my theory. :)

I need to wait until my build on master is ready and if it fails as well I try to implement Enricos suggestion.

regards
Stefan Schmidt

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#6 lore raw
In reply to Enrico Scholz

Hello.

Quoted 10 lines · Enrico Scholz
Quoted 8 lines · Khem Raj
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

recipes/cacao/cacaoh-cldc-native_0.98.bb SRC_URI = "\ · line 8

Quoted 2 lines
recipes/cacao/cacaoh-cldc-native_0.98.bb +1 -1
-    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
+    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

* libtool creates sometimes a wrapper script for executables (e.g. when they are linked against local libraries) and places the real executable in .libs/. Manually installing one of them is error prone and it might break with other linker flags or libtool versions.

Quoted 6 lines
Quoted 1 line

the binary in .libs do not exist so the link is final in this case.

Really? The author of the original recipe had an environment where the executable was in .libs/. Are you really sure that such an environment does not exist anymore? Or will the recipe now silently fail by installing the shell wrapper sometimes?

For me it did silently fail. :)

The openjdk-6 build failed due to missing header files like
exceptions.c:44:45: error: native/include/java_lang_String.h: No such file or directory

Quoted 8 lines
Quoted 2 lines

but in any case If you can come up with a patch to install it using libtool that would be nice.

Sorry; providing a patch means testing it (regardless whether it is trivial). Here, I am not sure whether 'libtool' or the platform prefixed '<arch>-libtool' is required and how to express '<arch>-libtool' in oe.

Quoted 7 lines

I gave my comment to a patch which fixed a broken recipe by replacing it with another broken recipe. So I expect that the author of this patch fixes and tests his work.

For completeness; install command should be

| libtool --mode=install install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

Thanks. I implemented this and the build works fine again. Thanks for letting us know. Will push it in when I have network connectivity again.

regards
Stefan Schmidt

#11 lore raw
In reply to Jaap de Jong

Hello.

Quoted 5 lines · Jaap de Jong

my initial patch was only intended to show the error I got while building openjdk-6 and I hoped to trigger the maintainers to get it fixed.
If this patch has caused any inconvenience to anyone, I apologize for that.

Not a big deal. It broke for me, but thanks to Enricos and Khems hints I was able to fix it for me. I'm pushing my fix right now. Testing on your setup would be appreciated.

regards
Stefan Schmidt