V4L/DVB/IR patches pending merge

This is the list of patches that weren't applied yet. I've made a big effort starting last weekend to handle everything I could. All pull requests were addressed. There are still 43 patches on my queue.

Please help me to clean the list.

This is what we have currently:

		== Waiting for Jonathan Corbet ack/nack <[email protected]> == 

Oct,19 2010: [1/2] ov7670: allow configuration of image size, clock speed, and I/O  http://patchwork.kernel.org/patch/266491  Daniel Drake <[email protected]>
Oct,19 2010: [2/2] cafe_ccic: Configure ov7670 correctly                            http://patchwork.kernel.org/patch/266501  Daniel Drake <[email protected]>

Jon,

in the case of the first patch, I'm not sure if you acked or nacked it. I suspect that you ack ;) You didn't comment the second one (or maybe I just missed your email). Are both ok for you?

		== Videobuf2 series == 

Oct,20 2010: [7/7] v4l: videobuf2: add CMA allocator                                http://patchwork.kernel.org/patch/267521  Pawel Osciak <[email protected]>
Oct,20 2010: [2/7] v4l: videobuf2: add generic memory handling routines             http://patchwork.kernel.org/patch/267531  Pawel Osciak <[email protected]>
Oct,20 2010: [4/7] v4l: videobuf2: add DMA coherent allocator                       http://patchwork.kernel.org/patch/267541  Pawel Osciak <[email protected]>
Oct,20 2010: [6/7] v4l: vivi: port to videobuf2                                     http://patchwork.kernel.org/patch/267551  Pawel Osciak <[email protected]>
Oct,20 2010: [1/7] v4l: add videobuf2 Video for Linux 2 driver framework            http://patchwork.kernel.org/patch/267561  Pawel Osciak <[email protected]>
Oct,20 2010: [3/7] v4l: videobuf2: add vmalloc allocator                            http://patchwork.kernel.org/patch/267571  Pawel Osciak <[email protected]>
Oct,20 2010: [5/7] v4l: videobuf2: add read() emulator                              http://patchwork.kernel.org/patch/267581  Marek Szyprowski <[email protected]>
Oct,13 2010: [1/4] MFC: Changes in include/linux/videodev2.h for MFC 5.1 codec      http://patchwork.kernel.org/patch/250371  Kamil Debski <[email protected]>
Oct,13 2010: [2/4] MFC: Add MFC 5.1 driver to plat-s5p                              http://patchwork.kernel.org/patch/250361  Kamil Debski <[email protected]>
Oct,13 2010: [3/4] MFC: Add MFC 5.1 V4L2 driver                                     http://patchwork.kernel.org/patch/250411  Kamil Debski <[email protected]>
Oct,13 2010: [4/4] s5pc110: Enable MFC 5.1 on Goni                                  http://patchwork.kernel.org/patch/250401  Kamil Debski <[email protected]>

Laurent wants more time to review videobuf2. I agree. reviewing API changes like this require some time and some tests. Also, i would like to see DMA Scatter/Gather version, as it allows testing with more complex devices.

		== Need more tests/acks from DVB users == 

Aug, 7 2010: Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function http://patchwork.kernel.org/patch/118147 Marko Ristola <[email protected]>

Comments? Reviews? I'd like to see more tests about it, as it can potentially break DVB filtering.

		== mantis patches - Waiting for Manu Abraham <[email protected]> == 

Apr,15 2010: [5/8] ir-core: convert mantis from ir-functions.c                      http://patchwork.kernel.org/patch/92961   David Härdeman <[email protected]>
Jun,20 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/107036  Marko Ristola <[email protected]>
Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files                             http://patchwork.kernel.org/patch/107062  Bjørn Mork <[email protected]>
Jun,20 2010: mantis: use dvb_attach to avoid double dereferencing on module removal http://patchwork.kernel.org/patch/107063  Bjørn Mork <[email protected]>
Jun,21 2010: Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make modules  http://patchwork.kernel.org/patch/107147  Manu Abraham <[email protected]>
Jul, 3 2010: mantis: Rename gpio_set_bits to mantis_gpio_set_bits                   http://patchwork.kernel.org/patch/109972  Ben Hutchings <[email protected]>
Jul, 8 2010: Mantis DMA transfer cleanup, fixes data corruption and a race, improve http://patchwork.kernel.org/patch/110909  Marko Ristola <[email protected]>
Jul, 9 2010: Mantis: append tasklet maintenance for DVB stream delivery             http://patchwork.kernel.org/patch/111090  Marko Ristola <[email protected]>
Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy reg http://patchwork.kernel.org/patch/111245  Marko Ristola <[email protected]>
Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis)                                       http://patchwork.kernel.org/patch/112708  Niklas Claesson <[email protected]>
Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt     http://patchwork.kernel.org/patch/118173  Marko Ristola <[email protected]>
Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 demod   http://patchwork.kernel.org/patch/244201  Tuxoholic <[email protected]>
Jun,11 2010: stb0899: Removed an extra byte sent at init on DiSEqC bus              http://patchwork.kernel.org/patch/105621  Florent AUDEBERT <[email protected]>

What to say? Well, still waiting for Manu to handle those patches. He said he had a problem with his dish and should be working on it next week. Let's hope we can finally have some movement on those patches in time for .37.

		== Soc_camera waiting for Guennadi Liakhovetski <[email protected]> review == 

Aug, 3 2010: [04/11] mt9m111: added new bit offset defines                          http://patchwork.kernel.org/patch/116721  Michael Grzeschik <[email protected]>
Aug, 3 2010: [08/11] mt9m111: added reg_mask function                               http://patchwork.kernel.org/patch/116722  Michael Grzeschik <[email protected]>
Aug, 3 2010: [v2,10/11] mt9m111: rewrite set_pixfmt                                 http://patchwork.kernel.org/patch/116728  Michael Grzeschik <[email protected]>
Aug, 3 2010: [v2,11/11] mt9m111: make use of testpattern                            http://patchwork.kernel.org/patch/116730  Michael Grzeschik <[email protected]>

Those are a few experimental patches. Guennadi is already handling them. I'm keeping here just to avoid being forgotten.

		== Waiting for Igor M. Liplianin <[email protected]> review == 

Mar,10 2010: DM1105: could not attach frontend 195d:1105 http://patchwork.kernel.org/patch/84549 Hendrik Skarpeid <[email protected]>

Still waiting for Igor about this one. It is not a trivial patch, so we need some deep analysis on it.

		== Waiting for Patrick Boettcher <[email protected]> review == 

May,25 2010: Adding support to the Geniatech/MyGica SBTVD Stick S870 remote control http://patchwork.kernel.org/patch/102314  Hernán Ordiales <[email protected]>
Jul,14 2010: [1/4] drivers/media/dvb: Remove dead Configs                           http://patchwork.kernel.org/patch/111972  Christian Dietrich <[email protected]>
Jul,14 2010: [2/4] drivers/media/dvb: Remove undead configs                         http://patchwork.kernel.org/patch/111973  Christian Dietrich <[email protected]>

The first patch is probably broken.

Hernán,
Could you please re-generate it?

The other two are probably ok.

Patrick,
any reviews?

		== Waiting for Mauro Carvalho Chehab <[email protected]> fixes on Docbook == 

Feb,25 2010: DocBook/Makefile: Make it less verbose                                 http://patchwork.kernel.org/patch/82076   Mauro Carvalho Chehab <[email protected]>
Feb,25 2010: DocBook: Add rules to auto-generate some media docbooks                http://patchwork.kernel.org/patch/82075   Mauro Carvalho Chehab <[email protected]>
Feb,25 2010: DocBook/v4l/pixfmt.xml: Add missing formats for gspca cpia1 and sn9c20 http://patchwork.kernel.org/patch/82074   Mauro Carvalho Chehab <[email protected]>
Feb,25 2010: v4l: document new Bayer and monochrome pixel formats                   http://patchwork.kernel.org/patch/82073   Mauro Carvalho Chehab <[email protected]>

Those are my fault^Wlack of time. Not really exciting changes. Just a bunch of automatic checks for the DocBook building system, and some patch-dependent stuff. I'll see if I can find some time to finish those stuff.

		== waiting for videobuf2 == 

Mar,17 2010: [2/2] V4L/DVB: buf-dma-sg.c: support non-pageable user-allocated memor http://patchwork.kernel.org/patch/97263   Arnout Vandecappelle <[email protected]>
Jul,27 2010: videobuf_dma_sg: a new implementation for mmap                         http://patchwork.kernel.org/patch/114520  Figo.zhang <[email protected]>
Jul,28 2010: [v2] videobuf_dma_sg: a new implementation for mmap                    http://patchwork.kernel.org/patch/114760  Figo.zhang <[email protected]>
Jul,30 2010: [v2] Resend:videobuf_dma_sg: a new implementation for mmap             http://patchwork.kernel.org/patch/115348  Figo.zhang <[email protected]>

Those are some videobuf changes meant to fix some problems on videobuf. However, I think that the proper way is to address at videobuf2. So, I'm keeping them in order to not forget as requirements for videobuf2.

Number of pending patches per reviewer:

  LinuxTV community                                                     : 18
  Manu Abraham <[email protected]>                                 : 13
  Mauro Carvalho Chehab <[email protected]>                            : 4
  Guennadi Liakhovetski <[email protected]>                         : 4
  Patrick Boettcher <[email protected]                          : 3
  Igor M. Liplianin<[email protected]>                                    : 1

Cheers,
Mauro

---

If you discover any patch submitted via email that weren't caught by kernel.patchwork.org, this means that the patch got mangled by your emailer. The more likely cause is that the emailer converted tabs into spaces or broke long lines, or maybe they were attached with a binary type.

Ok, let me eat my own dogfood...

Em 23-10-2010 02:06, Mauro Carvalho Chehab escreveu:

Patch broken, and not really important. Discarded.

Patch applied.

This patch were made by Guennadi. Not sure why Patchwork pointed it as me. It were depending on the auto-generate rules, due to some changes that were needed to happen at some template files. I just applied those changes semi-manually, and finally applied the patch.

This is actually the patch that auto-generate media-indices.tmpl and media-entities.tmpl. It needs a more serious review, as some things are not working on it anymore, due to some API additions. I'll postpone it, for now, until I have some time to fix. Eventually, I'll just discard, but I think that some of the checks that happen here are important, as they help to track missing stuff at the API.

Cheers,
Mauro

Yes, I'm sorry, I was perhaps a bit too grumpy that day. The patch is a clear improvement over the hacky "just make it work" stuff I did previously. Feel free to add my Acked-by to both.

Thanks,

jon

Em 23-10-2010 12:35, Jonathan Corbet escreveu:

Added, thanks!

Btw, I agree with you that the choose between smsbus and i2c at the driver is a hack that should be addressed at the long term. Yet, removing OLPC-specific stuff from ov7670 is a good improvement, as the driver become more generic.

Cheers,
Mauro

Hi Mauro,

2010/10/22 Mauro Carvalho Chehab <[email protected]>:

Videobuf2 depends on multi-planar extensions. It of course works with the "old" non-multiplanar API, but supports both. What is the status of those patches? I see them as RFC in patchwork.
(I've been away those last couple of weeks, but trying to catch up.)

Best regards,
Pawel Osciak

2010/10/23 Mauro Carvalho Chehab <[email protected]>:

[snip]

Yes, i'm sending it as attachment (regenerated agaisnt trunk, 15168 revision)

Cheers

Hernán
http://h.ordia.com.ar

# HG changeset patch
# User hordia
# Date 1288389936 10800
# Node ID 248f513cf5b8a8ecac08d13c90ddeeaf326c08ea
# Parent abd3aac6644e1a31020f4cdfdee84bde7ca1e1b4
Adding support to the Geniatech/MyGica SBTVD Stick S870 remote control (updated)

diff -r abd3aac6644e -r 248f513cf5b8 linux/drivers/media/dvb/dvb-usb/dib0700_core.c
@@ -555,6 +555,14 @@
 			break;
 		}
 		break;
+	case 1:
+		/* Geniatech/MyGica remote protocol */
+		poll_reply.report_id  = buf[0];
+		poll_reply.data_state = buf[1];
+		poll_reply.system     = (buf[4] << 8) | buf[4];
+		poll_reply.data       = buf[5];
+		poll_reply.not_data   = buf[4]; /* integrity check */
+ 		break;
 	default:
 		/* RC5 Protocol */
 		poll_reply.report_id  = buf[0];

diff -r abd3aac6644e -r 248f513cf5b8 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -831,6 +831,44 @@
 	{ 0x4540, KEY_RECORD }, /* Font 'Size' for Teletext */
 	{ 0x4541, KEY_SCREEN }, /*  Full screen toggle, 'Hold' for Teletext */
 	{ 0x4542, KEY_SELECT }, /* Select video input, 'Select' for Teletext */
+
+	/* Key codes for the Geniatech/MyGica SBTVD Stick S870 remote
+	   set dvb_usb_dib0700_ir_proto=1 */
+	{ 0x38c7, KEY_TV }, /* TV/AV */
+	{ 0x0cf3, KEY_POWER },
+	{ 0x0af5, KEY_MUTE },
+	{ 0x2bd4, KEY_VOLUMEUP },
+	{ 0x2cd3, KEY_VOLUMEDOWN },
+	{ 0x12ed, KEY_CHANNELUP },
+	{ 0x13ec, KEY_CHANNELDOWN },
+	{ 0x01fe, KEY_1 },
+	{ 0x02fd, KEY_2 },
+	{ 0x03fc, KEY_3 },
+	{ 0x04fb, KEY_4 },
+	{ 0x05fa, KEY_5 },
+	{ 0x06f9, KEY_6 },
+	{ 0x07f8, KEY_7 },
+	{ 0x08f7, KEY_8 },
+	{ 0x09f6, KEY_9 },
+	{ 0x00ff, KEY_0 },
+	{ 0x16e9, KEY_PAUSE },
+	{ 0x17e8, KEY_PLAY },
+	{ 0x0bf4, KEY_STOP },
+	{ 0x26d9, KEY_REWIND },
+	{ 0x27d8, KEY_FASTFORWARD },
+	{ 0x29d6, KEY_ESC },
+	{ 0x1fe0, KEY_RECORD },
+	{ 0x20df, KEY_UP },
+	{ 0x21de, KEY_DOWN },
+	{ 0x11ee, KEY_LEFT },
+	{ 0x10ef, KEY_RIGHT },
+	{ 0x0df2, KEY_OK },
+	{ 0x1ee1, KEY_PLAYPAUSE }, /* Timeshift */
+	{ 0x0ef1, KEY_CAMERA }, /* Snapshot */
+	{ 0x25da, KEY_EPG }, /* Info KEY_INFO */
+	{ 0x2dd2, KEY_MENU }, /* DVD Menu */
+	{ 0x0ff0, KEY_SCREEN }, /* Full screen toggle */
+	{ 0x14eb, KEY_SHUFFLE },
 };
 
 /* STK7700P: Hauppauge Nova-T Stick, AVerMedia Volar */

Your keytable seems to be wrong since it have both keycode and its complement (which is used for error check normally). I think it is NEC remote? In that case address byte is typically same for all buttons.

Antti

http://palosaari.fi/

Em 29-10-2010 21:02, Hernán Ordiales escreveu:

Don't rebase against the mercurial tree. It is completely outdated. Use my git tree, instead:

http://git.linuxtv.org/media_tree.git

The IR should go to a separate file, and there's no need anymore to pass any parameter to the driver, as the IR table now specifies the protocol, and the driver automatically switches to NEC protocol, on devices using a NEC table.

Cheers,
Mauro

Yes, i know the complement thing . The table was generated by reverse engineering and i couldn't found the common address so i left in that way. For example, for '7' button i receive:
dib0700: IR raw 01 01 00 00 07 F8 (len 6)

I think Is not a nec remote, it is a generic one that comes with mygica/geniatech products. I rebuilt the key table (patch attached) using '00' as address, is that ok? And leaving it using RC5 protocol (instead adding a case for dvb_usb_dib0700_ir_proto=1)
in this way works ok too

.   default:
.   .   /* RC5 Protocol */
.   .   poll_reply.report_id  = buf[0];
.   .   poll_reply.data_state = buf[1];
.   .   poll_reply.system     = (buf[2] << 8) | buf[3];
.   .   poll_reply.data       = buf[4];
.   .   poll_reply.not_data   = buf[5];
.   .   break;

+ /* Key codes for the Geniatech/MyGica SBTVD Stick S870 remote
+ set dvb_usb_dib0700_ir_proto=1 */
+ { 0x0038, KEY_TV }, /* TV/AV */
+ { 0x000c, KEY_POWER },
+ { 0x000a, KEY_MUTE },
+ { 0x002b, KEY_VOLUMEUP },
+ { 0x002c, KEY_VOLUMEDOWN },
+ { 0x0012, KEY_CHANNELUP },
+ { 0x0013, KEY_CHANNELDOWN },
+ { 0x0001, KEY_1 },
+ { 0x0002, KEY_2 },
+ { 0x0003, KEY_3 },
+ { 0x0004, KEY_4 },
+ { 0x0005, KEY_5 },
+ { 0x0006, KEY_6 },
+ { 0x0007, KEY_7 },
+ { 0x0008, KEY_8 },
+ { 0x0009, KEY_9 },
+ { 0x0000, KEY_0 },
+ { 0x0016, KEY_PAUSE },
+ { 0x0017, KEY_PLAY },
+ { 0x000b, KEY_STOP },
+ { 0x0026, KEY_REWIND },
+ { 0x0027, KEY_FASTFORWARD },
+ { 0x0029, KEY_ESC },
+ { 0x001f, KEY_RECORD },
+ { 0x0020, KEY_UP },
+ { 0x0021, KEY_DOWN },
+ { 0x0011, KEY_LEFT },
+ { 0x0010, KEY_RIGHT },
+ { 0x000d, KEY_OK },
+ { 0x001e, KEY_PLAYPAUSE }, /* Timeshift */
+ { 0x000e, KEY_CAMERA }, /* Snapshot */
+ { 0x0025, KEY_EPG }, /* Info KEY_INFO */
+ { 0x002d, KEY_MENU }, /* DVD Menu */
+ { 0x000f, KEY_SCREEN }, /* Full screen toggle */
+ { 0x0014, KEY_SHUFFLE },

Hernán
http://h.ordia.com.ar

# HG changeset patch
# User hordia
# Date 1288400129 10800
# Node ID b4c5259a13cd1a05af4ab5242236ad88f2de3319 # Parent abd3aac6644e1a31020f4cdfdee84bde7ca1e1b4 Geniatech/MyGica SBTVD Stick S870 remote control keytable

diff -r abd3aac6644e -r b4c5259a13cd linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
@@ -831,6 +831,44 @@
 	{ 0x4540, KEY_RECORD }, /* Font 'Size' for Teletext */
 	{ 0x4541, KEY_SCREEN }, /*  Full screen toggle, 'Hold' for Teletext */
 	{ 0x4542, KEY_SELECT }, /* Select video input, 'Select' for Teletext */
+
+	/* Key codes for the Geniatech/MyGica SBTVD Stick S870 remote
+	   set dvb_usb_dib0700_ir_proto=1 */
+	{ 0x0038, KEY_TV }, /* TV/AV */
+	{ 0x000c, KEY_POWER },
+	{ 0x000a, KEY_MUTE },
+	{ 0x002b, KEY_VOLUMEUP },
+	{ 0x002c, KEY_VOLUMEDOWN },
+	{ 0x0012, KEY_CHANNELUP },
+	{ 0x0013, KEY_CHANNELDOWN },
+	{ 0x0001, KEY_1 },
+	{ 0x0002, KEY_2 },
+	{ 0x0003, KEY_3 },
+	{ 0x0004, KEY_4 },
+	{ 0x0005, KEY_5 },
+	{ 0x0006, KEY_6 },
+	{ 0x0007, KEY_7 },
+	{ 0x0008, KEY_8 },
+	{ 0x0009, KEY_9 },
+	{ 0x0000, KEY_0 },
+	{ 0x0016, KEY_PAUSE },
+	{ 0x0017, KEY_PLAY },
+	{ 0x000b, KEY_STOP },
+	{ 0x0026, KEY_REWIND },
+	{ 0x0027, KEY_FASTFORWARD },
+	{ 0x0029, KEY_ESC },
+	{ 0x001f, KEY_RECORD },
+	{ 0x0020, KEY_UP },
+	{ 0x0021, KEY_DOWN },
+	{ 0x0011, KEY_LEFT },
+	{ 0x0010, KEY_RIGHT },
+	{ 0x000d, KEY_OK },
+	{ 0x001e, KEY_PLAYPAUSE }, /* Timeshift */
+	{ 0x000e, KEY_CAMERA }, /* Snapshot */
+	{ 0x0025, KEY_EPG }, /* Info KEY_INFO */
+	{ 0x002d, KEY_MENU }, /* DVD Menu */
+	{ 0x000f, KEY_SCREEN }, /* Full screen toggle */
+	{ 0x0014, KEY_SHUFFLE },
 };
 
 /* STK7700P: Hauppauge Nova-T Stick, AVerMedia Volar */

Can we agree that this was yet another useless waiting exercise? Please start learning from experience. You are just repeating the same mistake again and again. Its rather frustrating to watch. Like watching a rat in a maze banging it's head against the same wall over and over again.

Bjørn

Am Montag, den 01.11.2010, 11:30 +0100 schrieb Bjørn Mork:

Bjorn,

you are taking it wrong.

Indeed, neither Manu nor Mauro can do anything on this now.

It got stuck from outside. There is a war.

If you look closer, beside of Mantis stuff, there are drivers for much more recent chipsets, failing for not having linux support right now, being able to do the triple performance and even much more.

Without help, neither Manu nor Mauro can "hack" them together.

Cheers,
Hermann