Skip to contentSkip to conversation

USB device driver of Topcliff PCH

PATCH Superseded Toshiharu Okada 2 participants 3 messages Oct 25, 2010 USB

v6 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 USB device driver of Topcliff PCH

Hi Michal

This driver AUTHOR was changed to "Toshiharu Okada" from "Masayuki Ohtake". We updated the Kconfig and Makefile, renamed "Topcliff" to "EG20T".

This patch had not been added to the Linus's kernel tree yet after your "Acked-by". Do we need other actions in order to add this driver to the Linus's kernel tree.

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)
---
This patch adds the USB device driver of EG20T PCH.

EG20T PCH is the platform controller hub that is going to be used in Intel's upcoming general embedded platform. All IO peripherals in EG20T PCH are actually devices sitting on AMBA bus.
EG20T PCH has USB device I/F. Using this I/F, it is able to access system devices connected to USB device.

---
 drivers/usb/gadget/Kconfig        |   22 +
 drivers/usb/gadget/Makefile       |    3 +-
 drivers/usb/gadget/gadget_chips.h |    7 +
 drivers/usb/gadget/pch_udc.c      | 3285 +++++++++++++++++++++++++++++++++++++
 4 files changed, 3315 insertions(+), 2 deletions(-)
 create mode 100644 drivers/usb/gadget/pch_udc.c
drivers/usb/gadget/Kconfig +22 -0
index cd27f9b..e105ffb 100644
@@ -505,6 +505,28 @@ config USB_LANGWELL
 	default USB_GADGET
 	select USB_GADGET_SELECTED
 
+config USB_GADGET_PCH
+	boolean "PCH USB Device controller"
+	depends on PCI
+	select USB_GADGET_DUALSPEED
+	help
+	  This is a USB device driver for EG20T PCH.
+	  EG20T PCH is the platform controller hub that is used in Intel's
+	  general embedded platform. EG20T PCH has USB device interface.
+	  Using this interface, it is able to access system devices connected
+	  to USB device.
+	  This driver enables USB device function.
+	  USB device is a USB peripheral controller which
+	  supports both full and high speed USB 2.0 data transfers.
+	  This driver supports for control transfer, and bulk transfer modes.
+	  This driver dose not support interrupt transfer, and isochronous
+	  transfer modes.
+
+config USB_PCH
+	tristate
+	depends on USB_GADGET_PCH
+	default USB_GADGET
+	select USB_GADGET_SELECTED
 
 #
 # LAST -- dummy/emulated controller
drivers/usb/gadget/Makefile +1 -2
index 27283df..c9832ad 100644
@@ -28,7 +28,7 @@ obj-$(CONFIG_USB_FSL_QE)	+= fsl_qe_udc.o
 obj-$(CONFIG_USB_CI13XXX)	+= ci13xxx_udc.o
 obj-$(CONFIG_USB_S3C_HSOTG)	+= s3c-hsotg.o
 obj-$(CONFIG_USB_LANGWELL)	+= langwell_udc.o
-
+obj-$(CONFIG_USB_PCH)		+= pch_udc.o
 #
 # USB gadget drivers
 #
@@ -64,4 +64,3 @@ obj-$(CONFIG_USB_G_DBGP)	+= g_dbgp.o
 obj-$(CONFIG_USB_G_MULTI)	+= g_multi.o
 obj-$(CONFIG_USB_G_NOKIA)	+= g_nokia.o
 obj-$(CONFIG_USB_G_WEBCAM)	+= g_webcam.o
-
drivers/usb/gadget/gadget_chips.h +7 -0
index e511fec..f67dd29 100644
@@ -142,6 +142,11 @@
 #define gadget_is_s3c_hsotg(g)    0
 #endif
 
+#ifdef CONFIG_USB_GADGET_PCH
+#define	gadget_is_pch(g)	(!strcmp("pch_udc", (g)->name))
+#else
+#define	gadget_is_pch(g)	0
+#endif
 
 /**
  * usb_gadget_controller_number - support bcdDevice id convention
@@ -200,6 +205,8 @@ static inline int usb_gadget_controller_number(struct usb_gadget *gadget)
 		return 0x25;
 	else if (gadget_is_s3c_hsotg(gadget))
 		return 0x26;
+	else if (gadget_is_pch(gadget))
+		return 0x27;
 	return -ENOENT;
 }
 
drivers/usb/gadget/pch_udc.c new file +3285 -0

2,941 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.6.2.5

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 5 lines · Toshiharu Okada

This driver AUTHOR was changed to "Toshiharu Okada" from "Masayuki Ohtake". We updated the Kconfig and Makefile, renamed "Topcliff" to "EG20T".

This patch had not been added to the Linus's kernel tree yet after your "Acked-by". Do we need other actions in order to add this driver to the Linus's kernel tree.

I'm in no power of deciding what gets accepted or rejected. My Acked-by only meant that after looking at the code a few times, I saw no obvious problems with the patch. If you wish for this patch to be included you should send it to or at least cc "Greg Kroah-Hartman" <[email protected]>.

Quoted 6 lines
drivers/usb/gadget/pch_udc.c new file +6 -0
+static int __init pch_udc_pci_init(void)
+{
+	return pci_register_driver(&pch_udc_driver);
+}
+module_init(pch_udc_pci_init);
+

drivers/usb/gadget/pch_udc.c line 3285

Quoted 10 lines
drivers/usb/gadget/pch_udc.c new file +10 -0
+static void __exit pch_udc_pci_exit(void)
+{
+	pci_unregister_driver(&pch_udc_driver);
+}
+module_exit(pch_udc_pci_exit);
+
+MODULE_DESCRIPTION("OKI SEMICONDUCTOR PCH USB Device Controller");
+MODULE_AUTHOR("OKI SEMICONDUCTOR, <[email protected]>");
+MODULE_LICENSE("GPL");
+

Also, emtpy line at the end of file. If you're going to resend the patch, please remove the line.

Signature · 4 lines
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  Michał "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
#2 lore raw

-----
Date: Mon, 25 Oct 2010 11:09:23 +0200
From: "Michał Nazarewicz" <[email protected]>

Quoted 1 line

I'm in no power of deciding what gets accepted or rejected. My Acked-by

only meant

Quoted 1 line

that after looking at the code a few times, I saw no obvious problems with

the patch.

Quoted 1 line

If you wish for this patch to be included you should send it to or at

least cc

Quoted 2 lines

"Greg Kroah-Hartman" <[email protected]>.

Thank you for your reply and information.

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)