espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.
PATCH 1/1 espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.
pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
--- recipes/espgs/espgs_8.15.3.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
recipes/espgs/espgs_8.15.3.bb +1 -1
@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \ including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/" SECTION = "libs" -DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups" LICENSE = "GPL" PR = "r1"
Signature · 1 line
1.7.1
2010/10/26 Graham Gower <[email protected]>:
Quoted 18 lines
pstoraster/gdevcups.c:74:25: fatal error:cups/raster.h: No such file or directorySigned-off-by Graham Gower <[email protected]>---
recipes/espgs/espgs_8.15.3.bb | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)recipes/espgs/espgs_8.15.3.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/"
SECTION = "libs"recipes/espgs/espgs_8.15.3.bb +1
-1-DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
Quoted 4 lines
LICENSE = "GPL"
PR = "r1"
Three small remarks:
- not sure if changes like this require a PR bump. I always choose the the safe way and bump when in doubt.
- it would be nice if, when you are fixing a recipe you would also improve the LICENSE = "GPL" thing
- and there is also a 7.07.1 recipe. Should this apply to this version as well (or alternately should we remove that recipe?)
Quoted 32 lines · Frans Meulenbroeks
2010/10/26 Graham Gower <[email protected]>:
Quoted 18 lines
pstoraster/gdevcups.c:74:25: fatal error:cups/raster.h: No such file or directorySigned-off-by Graham Gower <[email protected]>---
recipes/espgs/espgs_8.15.3.bb | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)recipes/espgs/espgs_8.15.3.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/"
SECTION = "libs"recipes/espgs/espgs_8.15.3.bb +1
-1-DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"Quoted 4 lines
LICENSE = "GPL"
PR = "r1"Three small remarks:
- not sure if changes like this require a PR bump. I always choose the the safe way and bump when in doubt.
- it would be nice if, when you are fixing a recipe you would also improve the LICENSE = "GPL" thing
- and there is also a 7.07.1 recipe. Should this apply to this version as well (or alternately should we remove that recipe?)
Quoted 1 line
I'll resubmit something when I get a chance.
-Graham
Quoted 19 lines · Frans Meulenbroeks
2010/10/26 Graham Gower <[email protected]>:
Quoted 18 lines
pstoraster/gdevcups.c:74:25: fatal error:cups/raster.h: No such file or directorySigned-off-by Graham Gower <[email protected]>---
recipes/espgs/espgs_8.15.3.bb | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)recipes/espgs/espgs_8.15.3.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/"
SECTION = "libs"recipes/espgs/espgs_8.15.3.bb +1
-1-DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
Quoted 8 lines
Quoted 4 lines
LICENSE = "GPL"
PR = "r1"Three small remarks:
- not sure if changes like this require a PR bump. I always choose the the safe way and bump when in doubt.
Well if in doubt always read
http://wiki.openembedded.org/index.php/When_To_Bump_PR
and in this case a PR bump is not needed.
Quoted 2 lines
- it would be nice if, when you are fixing a recipe you would also improve the LICENSE = "GPL" thing
yes.
Quoted 3 lines
- and there is also a 7.07.1 recipe. Should this apply to this version as well (or alternately should we remove that recipe?)
probably remove the old recipe.
Quoted 7 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Quoted 37 lines · Khem Raj
Quoted 19 lines · Frans Meulenbroeks
2010/10/26 Graham Gower <[email protected]>:
Quoted 18 lines
pstoraster/gdevcups.c:74:25: fatal error:cups/raster.h: No such file or directorySigned-off-by Graham Gower <[email protected]>---
recipes/espgs/espgs_8.15.3.bb | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)recipes/espgs/espgs_8.15.3.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/"
SECTION = "libs"recipes/espgs/espgs_8.15.3.bb +1
-1-DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"Quoted 8 lines
Quoted 4 lines
LICENSE = "GPL"
PR = "r1"Three small remarks:
- not sure if changes like this require a PR bump. I always choose the the safe way and bump when in doubt.Well if in doubt always read
http://wiki.openembedded.org/index.php/When_To_Bump_PR
and in this case a PR bump is not needed.Quoted 2 lines
- it would be nice if, when you are fixing a recipe you would also improve the LICENSE = "GPL" thing
Quoted 7 lines
yes.
Quoted 3 lines
- and there is also a 7.07.1 recipe. Should this apply to this version as well (or alternately should we remove that recipe?)
probably remove the old recipe.
Both espgs recipes can be moved to obsolete, as the project has been merged into ghostscript 3 years ago. There are a couple of dependent recipes to be moved to depend on gs instead. But I need to fix the gs recipe to build for me before i can test them.
-Graham
Quoted 44 lines · Graham Gower
Quoted 43 lines · Khem Raj
Quoted 19 lines · Frans Meulenbroeks
2010/10/26 Graham Gower <[email protected]>:
Quoted 18 lines
pstoraster/gdevcups.c:74:25: fatal error:cups/raster.h: No such file or directorySigned-off-by Graham Gower <[email protected]>---
recipes/espgs/espgs_8.15.3.bb | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)recipes/espgs/espgs_8.15.3.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/"
SECTION = "libs"recipes/espgs/espgs_8.15.3.bb +1
-1-DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"Quoted 8 lines
Quoted 4 lines
LICENSE = "GPL"
PR = "r1"Three small remarks:
- not sure if changes like this require a PR bump. I always choose the the safe way and bump when in doubt.Well if in doubt always read
http://wiki.openembedded.org/index.php/When_To_Bump_PR
and in this case a PR bump is not needed.Quoted 2 lines
- it would be nice if, when you are fixing a recipe you would also improve the LICENSE = "GPL" thing
yes.
Quoted 3 lines
- and there is also a 7.07.1 recipe. Should this apply to this version as well (or alternately should we remove that recipe?)
Quoted 7 lines
Quoted 1 line
probably remove the old recipe.
Both espgs recipes can be moved to obsolete, as the project has been merged into ghostscript 3 years ago. There are a couple of dependent recipes to be moved to depend on gs instead. But I need to fix the gs recipe to build for me before i can test them.
good find fantastic.
Quoted 7 lines
-Graham
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Quoted 44 lines · Graham Gower
Quoted 43 lines · Khem Raj
Quoted 19 lines · Frans Meulenbroeks
2010/10/26 Graham Gower <[email protected]>:
Quoted 18 lines
pstoraster/gdevcups.c:74:25: fatal error:cups/raster.h: No such file or directorySigned-off-by Graham Gower <[email protected]>---
recipes/espgs/espgs_8.15.3.bb | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)recipes/espgs/espgs_8.15.3.bb +0
-0@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \including bug fixes, new drivers, and additional support for CUPS." HOMEPAGE = "http://www.cups.org/espgs/"
SECTION = "libs"recipes/espgs/espgs_8.15.3.bb +1
-1-DEPENDS = "jpeg zlib libpng tiff fontconfig" +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"Quoted 8 lines
Quoted 4 lines
LICENSE = "GPL"
PR = "r1"Three small remarks:
- not sure if changes like this require a PR bump. I always choose the the safe way and bump when in doubt.Well if in doubt always read
http://wiki.openembedded.org/index.php/When_To_Bump_PR
and in this case a PR bump is not needed.Quoted 2 lines
- it would be nice if, when you are fixing a recipe you would also improve the LICENSE = "GPL" thing
yes.
Quoted 3 lines
- and there is also a 7.07.1 recipe. Should this apply to this version as well (or alternately should we remove that recipe?)
Quoted 6 lines
Quoted 1 line
probably remove the old recipe.
Both espgs recipes can be moved to obsolete, as the project has been merged into ghostscript 3 years ago. There are a couple of dependent recipes to be moved to depend on gs instead. But I need to fix the gs recipe to build for me before i can test them.
I've been working on this too.
The current state of the recipe is in my working branch (sakoman):
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=openembedded.git;a=shortlog;h=refs/heads/sakoman
It builds, but there is some strangeness in generating the cups-gs and cup-gs-dbg packages that I still haven't quite figured out.
Steve