xl: fix ballooning
PATCH 1/1 xl: fix ballooning
Hi,
we should only check the value of new_target_memkb _after_ it has been properly setup. This fixes ballooning Dom0, which was broken since 22200:49a3c1721734.
Signature · 3 lines
Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448-3567-12
tools/libxl/libxl.c +5 -4
@@ -2927,6 +2927,11 @@ abort =1 ; goto out; } +if (relative) + new_target_memkb = current_target_memkb + target_memkb; +else + new_target_memkb = target_memkb; +if (!domid && new_target_memkb <LIBXL_MIN_DOM0_MEM ) {LIBXL__LOG (ctx,LIBXL__LOG_ERROR ,"new target for dom0 is below the minimum threshold\n" );
@@ -2934,10 +2939,6 @@ goto out; } -if (relative) - new_target_memkb = current_target_memkb + target_memkb; -else - new_target_memkb = target_memkb;if (new_target_memkb > memorykb) {LIBXL__LOG (ctx,LIBXL__LOG_ERROR , "memory_dynamic_max must be less than or equal to"
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 7 lines · Andre Przywara
Hi,
we should only check the value of
new_target_memkb_after_ it has been properly setup. This fixes ballooning Dom0, which was broken since 22200:49a3c1721734.Signed-off-by Andre Przywara <[email protected]>
Again? I thought my fix for this was already applied?! :P
Gianni
Quoted 10 lines · Gianni Tedesco
Quoted 7 lines · Andre Przywara
Hi,
we should only check the value of
new_target_memkb_after_ it has been properly setup. This fixes ballooning Dom0, which was broken since 22200:49a3c1721734.Signed-off-by Andre Przywara <[email protected]>Again? I thought my fix for this was already applied?! :P
I didn't find one. I used the latest staging tip and the problem was still there. Is there a separate xl repository or branch I should know of?
Andre.
Signature · 3 lines
Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448-3567-12
Andre Przywara writes ("Re: [Xen-devel] [PATCH] xl: fix ballooning"):
Quoted 5 lines
Quoted 1 line · Gianni Tedesco
Again? I thought my fix for this was already applied?! :P
I didn't find one. I used the latest staging tip and the problem was still there. Is there a separate xl repository or branch I should know of?
I've been holding off putting more tools patches into xen-unstable staging because I wanted to see Ian C's hypercall buffers series pass the tests first. That's worked so I'll apply the backlog patches today.
Ian.