Skip to contentSkip to conversation

Section conflicts with percpu variables

DISCUSSION Tejun Heo 2 participants 2 messages Oct 28, 2010 – Oct 29, 2010 1 message not in the archive

lore
Share & tools
lore

Tejun Heo

author
#1 lore raw
In reply to a message not in the archive
Quoted 5 lines · Jeremy Fitzhardinge

Hi Tejun,

I wonder if you could have a look at this. I have someone reporting compilation failures when using the stock Centos 5 compiler:

Quoted 7 lines

arch/x86/xen/mmu.c:163: error: __pcpu_scope_xen_cr3 causes a section type conflict arch/x86/xen/mmu.c:164: error: __pcpu_scope_xen_current_cr3 causes a section type conflict arch/x86/xen/mmu.c:163: error: __pcpu_unique_xen_cr3 causes a section type conflict arch/x86/xen/mmu.c:164: error: __pcpu_unique_xen_current_cr3 causes a section type conflict

Looking at mmu.i, I can't see why it is picking on these particular per-cpu variables. Do you have any insight into this.

Hmmm... me neither. section type conflict? Does it make any different if you move the definitions near the top of the file or use a different compiler version?

Thanks.

Signature · 1 line
tejun
#2 lore raw
Quoted 11 lines · Tejun Heo
Quoted 10 lines · Jeremy Fitzhardinge

Hi Tejun,

I wonder if you could have a look at this. I have someone reporting compilation failures when using the stock Centos 5 compiler:

arch/x86/xen/mmu.c:163: error: __pcpu_scope_xen_cr3 causes a section type conflict arch/x86/xen/mmu.c:164: error: __pcpu_scope_xen_current_cr3 causes a section type conflict arch/x86/xen/mmu.c:163: error: __pcpu_unique_xen_cr3 causes a section type conflict arch/x86/xen/mmu.c:164: error: __pcpu_unique_xen_current_cr3 causes a section type conflict

Quoted 5 lines
Quoted 2 lines

Looking at mmu.i, I can't see why it is picking on these particular per-cpu variables. Do you have any insight into this.

Hmmm... me neither. section type conflict? Does it make any different if you move the definitions near the top of the file or use a different compiler version?

This is the first report of this kind I've seen, so it mostly works. The compiler in question is the stock Centos 5 (.1?) compiler, so it would be nice to make sure it works as-is.

I've seen section type conflicts with .discard before when discarding a function and a data type with the same section, which is why I added general support for .discard.* so they can all get their own sections. But that doesn't seem to be the case here.

J