Skip to contentSkip to conversation

Typo in tty_driver.h?

DISCUSSION Timur Tabi 3 participants 3 messages Oct 28, 2010 – Oct 31, 2010

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

I believe I found a typo in a comment in tty_driver.h

* TTY_DRIVER_DYNAMIC_DEV --- if set, the individual tty devices need
* to be registered with a call to tty_register_driver() when the
* device is found in the system and unregistered with a call to
* tty_unregister_device() so the devices will be show up
* properly in sysfs. If not set, driver->num entries will be
* created by the tty core in sysfs when tty_register_driver() is
* called. This is to be used by drivers that have tty devices
* that can appear and disappear while the main tty driver is
* registered with the tty core.

On line 2, I think it should say "tty_register_device()" instead of "tty_register_driver()".

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#1 lore raw
Quoted 12 lines · Timur Tabi

I believe I found a typo in a comment in tty_driver.h

* TTY_DRIVER_DYNAMIC_DEV --- if set, the individual tty devices need
* to be registered with a call to tty_register_driver() when the
* device is found in the system and unregistered with a call to
* tty_unregister_device() so the devices will be show up
* properly in sysfs. If not set, driver->num entries will be
* created by the tty core in sysfs when tty_register_driver() is
* called. This is to be used by drivers that have tty devices
* that can appear and disappear while the main tty driver is
* registered with the tty core.

Quoted 2 lines

On line 2, I think it should say "tty_register_device()" instead of "tty_register_driver()".

Yes, you're correct. Care to bake a patch?

regards,

Signature · 2 lines
js
suse labs
#2 lore raw
Quoted 1 line · Jiri Slaby

Yes, you're correct. Care to bake a patch?

Sure.

Signature · 3 lines
Timur Tabi
Linux kernel developer
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�