Skip to contentSkip to conversation

OMAP4: quick image loading & memory init on Pandaboard

PATCH New Sergiy Kibrik 2 participants 5 messages Nov 5, 2010 – Nov 19, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP4: quick image loading & memory init on Pandaboard

Improved default config for OMAP4 Pandaboard for faster boot:

	-reduced environment size to speed up memory initialization;
	-tweaked blob load address to avoid image relocation (according to default uImage load address);
---
 include/configs/omap4_panda.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/omap4_panda.h +3 -3
index 74defab..5a2df35 100644
@@ -62,10 +62,10 @@
 
 /*
  * Size of malloc() pool
- * Total Size Environment - 256k
+ * Total Size Environment - 2k
  * Malloc - add 256k
  */
-#define CONFIG_ENV_SIZE			(256 << 10)
+#define CONFIG_ENV_SIZE			(256 << 4)
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (256 << 10))
 						/* initial data */
 /* Vector Base */
@@ -146,7 +146,7 @@
 #define CONFIG_ENV_OVERWRITE
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
-	"loadaddr=0x82000000\0" \
+	"loadaddr=0x80007FC0\0" \
 	"console=ttyS2,115200n8\0" \
 	"usbtty=cdc_acm\0" \
 	"vram=16M\0" \
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 OMAP4: quick image loading & memory init on Pandaboard

Dear Sergiy Kibrik,

Quoted 14 lines · In message <[email protected]> you wrote:

Improved default config for OMAP4 Pandaboard for faster boot:

	-reduced environment size to speed up memory initialization;
	-tweaked blob load address to avoid image relocation (according to default uImage load address);
---
 include/configs/omap4_panda.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/omap4_panda.h +0 -0
index 74defab..5a2df35 100644

include/configs/omap4_panda.h line 65

Quoted 5 lines
include/configs/omap4_panda.h +1 -1
@@ -62,10 +62,10 @@
 
 /*
  * Size of malloc() pool
- * Total Size Environment - 256k
+ * Total Size Environment - 2k

An environment size of 2 kB seems way to small for amost practical purposes. I agree that 256 kB might be overkill, but why not chose a more reasonable size like 16 kB, or say 8 kB if you are really trying to squeeze any microsecond?

include/configs/omap4_panda.h line 68

Quoted 4 lines
include/configs/omap4_panda.h +1 -1
  * Malloc - add 256k
  */
-#define CONFIG_ENV_SIZE			(256 << 10)
+#define CONFIG_ENV_SIZE			(256 << 4)

256 << 4 ? Who is supposed to easily read and understand this?

If you mean 2 KiB, you could use either 2048 or (2 << 10).

In any case - please reconside rif 16 KiB is nt more reasonable. The time difference should be minimal (did you measure it?).

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
"Life and death are seldom logical."
"But attaining a desired goal always is."
	-- McCoy and Spock, "The Galileo Seven", stardate 2821.7
#2 lore raw

PATCH 1/1 OMAP4: quick image loading & memory init on Pandaboard

Quoted 28 lines · Wolfgang Denk

Dear Sergiy Kibrik,

Quoted 14 lines · In message <[email protected]> you wrote:

Improved default config for OMAP4 Pandaboard for faster boot:

	-reduced environment size to speed up memory initialization;
	-tweaked blob load address to avoid image relocation (according to default uImage load address);
---
 include/configs/omap4_panda.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/omap4_panda.h +0 -0
index 74defab..5a2df35 100644

include/configs/omap4_panda.h line 65

Quoted 5 lines
include/configs/omap4_panda.h +1 -1
@@ -62,10 +62,10 @@
 
 /*
  * Size of malloc() pool
- * Total Size Environment - 256k
+ * Total Size Environment - 2k

An environment size of 2 kB seems way to small for amost practical purposes. I agree that 256 kB might be overkill, but why not chose a more reasonable size like 16 kB, or say 8 kB if you are really trying to squeeze any microsecond?

Quoted 9 lines

include/configs/omap4_panda.h line 68

Quoted 4 lines
include/configs/omap4_panda.h +1 -1
  * Malloc - add 256k
  */
-#define CONFIG_ENV_SIZE			(256 << 10)
+#define CONFIG_ENV_SIZE			(256 << 4)

256 << 4 ? Who is supposed to easily read and understand this?

If you mean 2 KiB, you could use either 2048 or (2 << 10).

sorry, I just used the way it was done before (besides those lines were commented)

Quoted 3 lines

In any case - please reconside rif 16 KiB is nt more reasonable. The time difference should be minimal (did you measure it?).

sure, 16k is a reasonable tradeoff. Thanks for your comments, I'll resubmit the patch.

Quoted 4 lines

Best regards,

Wolfgang Denk

#3 lore raw

PATCH 1/1 OMAP4: quick image loading & memory init on Pandaboard

Improved default config for OMAP4 Pandaboard for faster boot:

	-reduced environment size to speed up memory initialization;
	-tweaked blob load address to avoid image relocation (according to default uImage load address);
---
 include/configs/omap4_panda.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/omap4_panda.h +3 -3
index 74defab..1a87acf 100644
@@ -62,10 +62,10 @@
 
 /*
  * Size of malloc() pool
- * Total Size Environment - 256k
+ * Total Size Environment - 16k
  * Malloc - add 256k
  */
-#define CONFIG_ENV_SIZE			(256 << 10)
+#define CONFIG_ENV_SIZE			(16 << 10)
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (256 << 10))
 						/* initial data */
 /* Vector Base */
@@ -146,7 +146,7 @@
 #define CONFIG_ENV_OVERWRITE
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
-	"loadaddr=0x82000000\0" \
+	"loadaddr=0x80007FC0\0" \
 	"console=ttyS2,115200n8\0" \
 	"usbtty=cdc_acm\0" \
 	"vram=16M\0" \
Signature · 1 line
1.7.0.4
#4 lore raw

PATCH 1/1 OMAP4: quick image loading & memory init on Pandaboard

Quoted 27 lines · Sergiy Kibrik

Improved default config for OMAP4 Pandaboard for faster boot:

	-reduced environment size to speed up memory initialization;
	-tweaked blob load address to avoid image relocation (according to default uImage load address);
---
 include/configs/omap4_panda.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/omap4_panda.h +2 -2
index 74defab..1a87acf 100644
@@ -62,10 +62,10 @@
 
 /*
  * Size of malloc() pool
- * Total Size Environment - 256k
+ * Total Size Environment - 16k
  * Malloc - add 256k
  */
-#define CONFIG_ENV_SIZE			(256 << 10)
+#define CONFIG_ENV_SIZE			(16 << 10)
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (256 << 10))
 						/* initial data */
 /* Vector Base */

include/configs/omap4_panda.h line 152

Quoted 8 lines
include/configs/omap4_panda.h +1 -1
@@ -146,7 +146,7 @@
 #define CONFIG_ENV_OVERWRITE
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
-	"loadaddr=0x82000000\0" \
+	"loadaddr=0x80007FC0\0" \
 	"console=ttyS2,115200n8\0" \
 	"usbtty=cdc_acm\0" \
 	"vram=16M\0" \

Ping?