Skip to contentSkip to conversation

Skip DOTS category always

RFC PATCH In review Bian Naimeng 4 participants 4 messages Nov 8, 2010 – Nov 11, 2010

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 Skip DOTS category always

After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught when install test suite.

make[2]: Entering directory /home/biannm/ltp-882ad81/testcases/DOTS' make[2]: *** No rule to make target install'. Stop. make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS' make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
make: *** [testcases-install] Error 2

The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we add a checking, it looks unnecessary.

------
Dots need be skip always.

---
 testcases/Makefile |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
testcases/Makefile +1 -6
index b30d6d4..4792811 100644
@@ -31,7 +31,7 @@ include $(top_srcdir)/include/mk/env_pre.mk
 #    run).
 # 3. mce-test doesn't fit cleanly in the build, yet.
 # 4. pounder21 is just broken.
-FILTER_OUT_DIRS		:= ballista kdump mce-test open% pounder21
+FILTER_OUT_DIRS		:= DOTS ballista kdump mce-test open% pounder21
 
 # XXX (garrcoop): Not sure why realtime is still in this list; this was the
 # original list of disabled items...
@@ -41,11 +41,6 @@ ifeq ($(UCLINUX),1)
 FILTER_OUT_DIRS		+= realtime
 endif
 
-# DOTS requires javac
-ifeq ($(strip $(JAVAC)),)
-FILTER_OUT_DIRS		+= DOTS
-endif
-
 #
 # XXX (garrcoop): disabling the open_posix_testsuite by request from Subrata
 # due to build times (open_posix_testsuite runs serially by design to
Signature · 20 lines
1.7.0.4




-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw
Quoted 10 lines · Bian Naimeng

After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught when install test suite.

make[2]: Entering directory /home/biannm/ltp-882ad81/testcases/DOTS' make[2]: *** No rule to make target install'. Stop. make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS' make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
make: *** [testcases-install] Error 2

Quoted 8 lines

The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we add a checking, it looks unnecessary.

------
Dots need be skip always.

Hi Garrettt,

This installation failure is really noisy. Would you Apply this patch?

Gui

Quoted 20 lines
---
 testcases/Makefile |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
testcases/Makefile +1 -1
index b30d6d4..4792811 100644
@@ -31,7 +31,7 @@ include $(top_srcdir)/include/mk/env_pre.mk
 #    run).
 # 3. mce-test doesn't fit cleanly in the build, yet.
 # 4. pounder21 is just broken.
-FILTER_OUT_DIRS		:= ballista kdump mce-test open% pounder21
+FILTER_OUT_DIRS		:= DOTS ballista kdump mce-test open% pounder21
 
 # XXX (garrcoop): Not sure why realtime is still in this list; this was the
 # original list of disabled items...
@@ -41,11 +41,6 @@ ifeq ($(UCLINUX),1)
 FILTER_OUT_DIRS		+= realtime

testcases/Makefile ifeq ($(UCLINUX),1) · line 46

Quoted 10 lines
testcases/Makefile +0 -5
 endif
 
-# DOTS requires javac
-ifeq ($(strip $(JAVAC)),)
-FILTER_OUT_DIRS		+= DOTS
-endif
-
 #
 # XXX (garrcoop): disabling the open_posix_testsuite by request from Subrata
 # due to build times (open_posix_testsuite runs serially by design to

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 15 lines · Gui Jianfeng
Quoted 14 lines · Bian Naimeng

After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught when install test suite.

make[2]: Entering directory /home/biannm/ltp-882ad81/testcases/DOTS' make[2]: *** No rule to make target install'.  Stop. make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS' make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
make: *** [testcases-install] Error 2

The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we add a checking, it looks unnecessary.

Quoted 8 lines
Quoted 4 lines

------
Dots need be skip always.

Hi Garrettt,

This installation failure is really noisy. Would you Apply this patch?

DOTS is no longer built as part of the standard build as of last
night and unless someone speaks up opposing it, it's going away tomorrow evening.
Thanks,
-Garrett

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
Quoted 22 lines · Garrett Cooper
Quoted 20 lines · Gui Jianfeng
Quoted 18 lines · Bian Naimeng

After applied commit 43b57dbb4b959203bda5743ee7ff36c627e0911c, some error are caught when install test suite.

make[2]: Entering directory /home/biannm/ltp-882ad81/testcases/DOTS' make[2]: *** No rule to make target install'. Stop. make[2]: Leaving directory `/home/biannm/ltp-882ad81/testcases/DOTS' make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/biannm/ltp-882ad81/testcases'
make: *** [testcases-install] Error 2

The commit 43b57dbb4b959203bda5743ee7ff36c627e0911c looks to fix some configure error reported by mitani-san. But at the older LTP, Dots is be filtered out always, why we add a checking, it looks unnecessary.

------
Dots need be skip always.

Quoted 7 lines
Quoted 3 lines

Hi Garrettt,

This installation failure is really noisy. Would you Apply this patch?

DOTS is no longer built as part of the standard build as of last
night and unless someone speaks up opposing it, it's going away tomorrow evening.

Yah, it is not used by anybody anymore i believe.

Regards--
Subrata

Quoted 13 lines

Thanks,
-Garrett

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list