Translation faults with OMAP ISP
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00 translation fault omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000
and the select times out.
From a fresh boot, I can stream just fine from the Resizer and then switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Any ideas on the problem?
Thanks,
Lane
Hi Lane,
Quoted 16 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
Quoted 7 lines
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.Any ideas on the problem?
Ouch. First of all, could you please make sure you run the latest code ? Many bugs have been fixed in the last few months.
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 25 lines · Laurent Pinchart
Hi Lane,
Quoted 22 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Quoted 3 lines
Quoted 1 line
Any ideas on the problem?
Ouch. First of all, could you please make sure you run the latest code ? Many bugs have been fixed in the last few months
I had a pretty good idea that this would be your response, but I was hoping otherwise as merging has become more and more difficult to keep up with. Anyway, until I have a chance to merge in everything, I just found a work around for our usage needs, and that is to always use the resizer output and just change the resizer format between full resolution and preview resolution. This has turned out to be much more stable than switching between the CCDC and RESIZER dev nodes.
Thanks again for your feedback.
Lane
Hi Lane,
Quoted 30 lines · ext Lane Brooks
Quoted 25 lines · Laurent Pinchart
Hi Lane,
Quoted 22 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.Quoted 3 lines
Quoted 1 line
Any ideas on the problem?
Ouch. First of all, could you please make sure you run the latest code ? Many bugs have been fixed in the last few months
Quoted 7 lines
I had a pretty good idea that this would be your response, but I was hoping otherwise as merging has become more and more difficult to keep up with. Anyway, until I have a chance to merge in everything, I just found a work around for our usage needs, and that is to always use the resizer output and just change the resizer format between full resolution and preview resolution. This has turned out to be much more stable than switching between the CCDC and RESIZER dev nodes.
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Can you please try a patch I've sent to you (CC'ing linux-media) with subject:
"[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?
Regards,
David
Quoted 8 lines
Thanks again for your feedback.
Lane
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 31 lines · David Cohen
Quoted 17 lines · ext Lane Brooks
Quoted 16 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Quoted 16 lines
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.Any ideas on the problem?
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Quoted 7 lines
Can you please try a patch I've sent to you (CC'ing linux-media) with subject:
"[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?Regards,
David
David,
I am not trying to use multiple outputs simultaneously. I get the translation error with the following sequence:
- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.
Is your patch going to help with this problem?
Lane
Hi Lane,
Quoted 47 lines · On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
Quoted 33 lines · David Cohen
Quoted 17 lines · ext Lane Brooks
Quoted 16 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Quoted 16 lines
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Any ideas on the problem?
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Quoted 7 lines
Can you please try a patch I've sent to you (CC'ing linux-media) with
subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?Regards,
David
David,
I am not trying to use multiple outputs simultaneously. I get the translation error with the following sequence:
Quoted 8 lines
- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.Is your patch going to help with this problem?
If you reset all links before setting them up for the CCDC output, probably not (unless you have a bug in your CCDC links setup, but I doubt that).
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 53 lines · Laurent Pinchart
Quoted 52 lines · On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
Quoted 32 lines · David Cohen
Quoted 17 lines · ext Lane Brooks
Quoted 16 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Quoted 16 lines
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Any ideas on the problem?
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Quoted 7 lines
Can you please try a patch I've sent to you (CC'ing linux-media) with
subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?Regards,
David
David,
I am not trying to use multiple outputs simultaneously. I get the translation error with the following sequence:
- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.
Quoted 3 lines
Quoted 1 line
Is your patch going to help with this problem?
If you reset all links before setting them up for the CCDC output, probably not (unless you have a bug in your CCDC links setup, but I doubt that).
I can stream just fine from the CCDC output if I do not use the resizer prior, so I am pretty sure I am setting up the CCDC links correctly.
Quoted 47 lines · ext Lane Brooks
Quoted 46 lines · Laurent Pinchart
Quoted 45 lines · On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
Quoted 32 lines · David Cohen
Quoted 17 lines · ext Lane Brooks
Quoted 16 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Quoted 16 lines
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
From a fresh boot, I can stream just fine from the Resizer and then
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Any ideas on the problem?
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Quoted 7 lines
Can you please try a patch I've sent to you (CC'ing linux-media) with
subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?Regards,
David
David,
I am not trying to use multiple outputs simultaneously. I get the translation error with the following sequence:
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.
You're describing some different steps from your previous e-mail, as here the iommu faults come while CCDC outputting to memory and in your comment above it was happening while Resizer outputting to memory.
Which one should I consider as the correct? :)
It would be nice if you could print the values of CCDC_SDR_ADDR and RSZ_SDR_OUTADD just before the bug.
Are you also enabling CCDC's LSC?
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Is your patch going to help with this problem?
If you reset all links before setting them up for the CCDC output, probably not (unless you have a bug in your CCDC links setup, but I doubt that).
As Laurent said, probably not. But if you want to go ahead to test this patch, that's fine. It's very unlikely we have a bug on CCDC or Resizer link setup, but not completely impossible. :)
A new version of this patch fixing the typo I mentioned there is going to be locally applied anyway.
Quoted 2 lines
I can stream just fine from the CCDC output if I do not use the resizer prior, so I am pretty sure I am setting up the CCDC links correctly.
Well, iommu faults mean bug on kernel side. If you're still doing something wrong, the driver must be able to return and error to userland.
Regards,
David
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David,
Quoted 82 lines · On Friday 19 November 2010 16:06:21 David Cohen wrote:
Quoted 51 lines · ext Lane Brooks
Quoted 50 lines · Laurent Pinchart
Quoted 49 lines · On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
Quoted 35 lines · David Cohen
Quoted 20 lines · ext Lane Brooks
Quoted 19 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Quoted 19 lines
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
From a fresh boot, I can stream just fine from the Resizer and then
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Any ideas on the problem?
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Quoted 7 lines
Can you please try a patch I've sent to you (CC'ing linux-media) with
subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?Regards,
David
David,
I am not trying to use multiple outputs simultaneously. I get the translation error with the following sequence:
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.You're describing some different steps from your previous e-mail, as here the iommu faults come while CCDC outputting to memory and in your comment above it was happening while Resizer outputting to memory.
Which one should I consider as the correct? :)
It would be nice if you could print the values of
CCDC_SDR_ADDRandRSZ_SDR_OUTADDjust before the bug.Are you also enabling CCDC's LSC?
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Is your patch going to help with this problem?
If you reset all links before setting them up for the CCDC output, probably not (unless you have a bug in your CCDC links setup, but I doubt that).
As Laurent said, probably not. But if you want to go ahead to test this patch, that's fine. It's very unlikely we have a bug on CCDC or Resizer link setup, but not completely impossible. :)
A new version of this patch fixing the typo I mentioned there is going to be locally applied anyway.
Quoted 6 lines
Quoted 2 lines
I can stream just fine from the CCDC output if I do not use the resizer prior, so I am pretty sure I am setting up the CCDC links correctly.
Well, iommu faults mean bug on kernel side. If you're still doing something wrong, the driver must be able to return and error to userland.
Don't forget that Lane is using an older version of the OMAP3 ISP driver. The bug might have been fixed in the latest code.
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 88 lines · ext Laurent Pinchart
Hi David,
Quoted 85 lines · On Friday 19 November 2010 16:06:21 David Cohen wrote:
Quoted 51 lines · ext Lane Brooks
Quoted 50 lines · Laurent Pinchart
Quoted 49 lines · On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
Quoted 35 lines · David Cohen
Quoted 20 lines · ext Lane Brooks
Quoted 19 lines · On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Quoted 19 lines
Laurent,
I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output.
If I use the CCDC output to stream some video, then close it down, switch to the Resizer output and open it up and try to stream, I get the following errors spewing out:
omap-iommu omap-iommu.0:
omap2_iommu_fault_isr: da:00d0ef00 translation fault
omap-iommu omap-iommu.0:iommu_fault_handler: da:00d0ef00 pgd:ce664034 *pgd:00000000and the select times out.
From a fresh boot, I can stream just fine from the Resizer and then
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
switch to the CCDC output just fine. It is only when I go from the CCDC to the Resizer that I get this problem. Furthermore, when it gets into this state, then anything dev node I try to use has the translation errors and the only way to recover is to reboot.
Any ideas on the problem?
I'm not sure if it's your case, but OMAP3 ISP driver does not support pipeline with multiples outputs yet. We have to return error from the driver in this case. If you configured CCDC to write to memory and then to write to preview/resizer afterwards without deactivating the link to write to memory, you may face a similar problem you described.
Quoted 7 lines
Can you please try a patch I've sent to you (CC'ing linux-media) with
subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet"?Regards,
David
David,
I am not trying to use multiple outputs simultaneously. I get the translation error with the following sequence:
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.You're describing some different steps from your previous e-mail, as here the iommu faults come while CCDC outputting to memory and in your comment above it was happening while Resizer outputting to memory.
Which one should I consider as the correct? :)
It would be nice if you could print the values of
CCDC_SDR_ADDRandRSZ_SDR_OUTADDjust before the bug.Are you also enabling CCDC's LSC?
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Is your patch going to help with this problem?
If you reset all links before setting them up for the CCDC output, probably not (unless you have a bug in your CCDC links setup, but I doubt that).
As Laurent said, probably not. But if you want to go ahead to test this patch, that's fine. It's very unlikely we have a bug on CCDC or Resizer link setup, but not completely impossible. :)
A new version of this patch fixing the typo I mentioned there is going to be locally applied anyway.Quoted 2 lines
I can stream just fine from the CCDC output if I do not use the resizer prior, so I am pretty sure I am setting up the CCDC links correctly.
Quoted 6 lines
Quoted 3 lines
Well, iommu faults mean bug on kernel side. If you're still doing something wrong, the driver must be able to return and error to userland.
Don't forget that Lane is using an older version of the OMAP3 ISP driver. The bug might have been fixed in the latest code.
Hm. We did fix some iommu faults.
Maybe it's better to test a newer version instead.
If you still see that bug using an up-to-date version, please report it and I can try to help you. :)
Regards,
David
Quoted 5 lines
Signature · 4 lines
-- Regards, Laurent Pinchart
[omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")
Hi David and Laurent,
<snip>
Quoted 9 lines
Quoted 2 lines
Don't forget that Lane is using an older version of the OMAP3 ISP
driver. The
Quoted 1 line
bug might have been fixed in the latest code.
Hm. We did fix some iommu faults.
Maybe it's better to test a newer version instead.
If you still see that bug using an up-to-date version, please report it and I can try to help you. :)
How close is this tree from the latest internal version you guys work with?
http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel
I have been basing my patches on top of this tree:
http://git.linuxtv.org/pinchartl/media.git?h=refs/heads/media-0004-omap3isp
Would it be better to be based on the gitorious tree instead?
What do you think?
Regards,
Sergio
Quoted 14 lines
Regards,
David
Quoted 5 lines
--
Regards,Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")
Hi Sergio,
Quoted 7 lines · Sergio
Hi David and Laurent,
<snip>
Quoted 3 lines
Quoted 2 lines
Don't forget that Lane is using an older version of the OMAP3 ISP driver. The bug might have been fixed in the latest code.
Quoted 8 lines
Quoted 4 lines
Hm. We did fix some iommu faults.
Maybe it's better to test a newer version instead.
If you still see that bug using an up-to-date version, please report it and I can try to help you. :)How close is this tree from the latest internal version you guys work with?
http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel
There's less differences between gitorious and our internal tree than between linuxtv and our internal tree.
Quoted 7 lines
I have been basing my patches on top of this tree:
http://git.linuxtv.org/pinchartl/media.git?h=refs/heads/media-0004-omap3isp
Would it be better to be based on the gitorious tree instead?
What do you think?
I will push a big patch that ports all the changes made to the MC and V4L2 core, as well as omap3-isp driver, during public review to our internal tree early next week (should be on Monday). The trees will then get in sync. The gitorious tree will be updated as well.
Unless you want your patches to be applied before Monday, which won't happen anyway, please base them on the linuxtv tree :-)
Signature · 3 lines
Regards, Laurent Pinchart
RE: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")
Hi Laurent,
Quoted 24 lines
-----Original Message-----
From: Laurent Pinchart [mailto:[email protected]]
Sent: Friday, November 19, 2010 10:16 AM
To: Aguirre, Sergio
Cc: David Cohen; ext Lane Brooks; [email protected]
Subject: Re: [omap3isp] Prefered patch base for latest code? (was: "RE:
Translation faults with OMAP ISP")Hi Sergio,
Quoted 10 lines · Sergio
Hi David and Laurent,
<snip>
Quoted 6 lines
Quoted 2 lines
Don't forget that Lane is using an older version of the OMAP3 ISP driver. The bug might have been fixed in the latest code.
Hm. We did fix some iommu faults.
Maybe it's better to test a newer version instead.
If you still see that bug using an up-to-date version, please reportit
Quoted 2 lines
Quoted 1 line
and I can try to help you. :)
Quoted 8 lines
Quoted 1 line
How close is this tree from the latest internal version you guys work
with?
There's less differences between gitorious and our internal tree than between
linuxtv and our internal tree.
Ok, I guess I can treat above tree as an "omap3isp-next" tree then, to have a sneak preview of what's coming ;)
Quoted 17 lines
Quoted 4 lines
I have been basing my patches on top of this tree:
http://git.linuxtv.org/pinchartl/media.git?h=refs/heads/media-0004-
omap3isp
Quoted 4 lines
Would it be better to be based on the gitorious tree instead?
What do you think?
I will push a big patch that ports all the changes made to the MC and V4L2 core, as well as omap3-isp driver, during public review to our internal tree
early next week (should be on Monday). The trees will then get in sync. The
gitorious tree will be updated as well.
Quoted 3 lines
Unless you want your patches to be applied before Monday, which won't happen
anyway, please base them on the linuxtv tree :-)
Ok, sure. It's better for me, since the gitorious devel tree includes rx51 support which I don't even have a device to try it out :P
I'll continue to be based on media-0004-omap3isp branch then, and just watch devel branch to know if I'm not doing something conflicting.
Regards,
Sergio
Quoted 5 lines
--
Regards,Laurent Pinchart
Re: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")
Hi Sergio,
Quoted 2 lines · Sergio
Quoted 1 line · Sergio
On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote:
[snip]
Quoted 10 lines
Quoted 7 lines
Quoted 4 lines
How close is this tree from the latest internal version you guys work with?
http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel
There's less differences between gitorious and our internal tree than between linuxtv and our internal tree.
Ok, I guess I can treat above tree as an "omap3isp-next" tree then, to have a sneak preview of what's coming ;)
I haven't expressed myself clearly enough. The gitorious tree is currently more in sync with our internal tree that the linuxtv is for a simple reason:
both our internal tree and the gitorious tree are missing modifications made during the public review process.
Patches published from our internal tree are always pushed to linuxtv and gitorious at the same time (or mostly). Please don't use the gitorious tree for anything else than trying the driver on the N900.
Signature · 3 lines
Regards, Laurent Pinchart
RE: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")
Hi Laurent,
Quoted 29 lines
-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Laurent Pinchart
Sent: Friday, November 19, 2010 10:32 AM
To: Aguirre, Sergio
Cc: David Cohen; ext Lane Brooks; [email protected]
Subject: Re: [omap3isp] Prefered patch base for latest code? (was: "RE:
Translation faults with OMAP ISP")Hi Sergio,
Quoted 2 lines · Sergio
Quoted 1 line · Sergio
On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote:
[snip]
Quoted 1 line
Quoted 1 line
Quoted 1 line
How close is this tree from the latest internal version you guys
work
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
with?
rx51/commits/devel
Quoted 5 lines
Quoted 3 lines
There's less differences between gitorious and our internal tree than between linuxtv and our internal tree.
Ok, I guess I can treat above tree as an "omap3isp-next" tree then, to
have
Quoted 8 lines
Quoted 1 line
a sneak preview of what's coming ;)
I haven't expressed myself clearly enough. The gitorious tree is currently more in sync with our internal tree that the linuxtv is for a simple reason:
both our internal tree and the gitorious tree are missing modifications made
during the public review process.
Ok. Sorry, I think I didn't quite understood that.
Quoted 5 lines
Patches published from our internal tree are always pushed to linuxtv and gitorious at the same time (or mostly). Please don't use the gitorious tree
for anything else than trying the driver on the N900.
I see. So I probably won't worry about this tree at all, since I don't have an N900.
I'm trying this in my Zoom board w/OMAP3630, and I have a Beagleboard xM handy aswell (OMAP3730), so In my tree I'll try to keep support for both of These.
Also, I'm working on trying to bring this in a very different chip, but that's a secret ;) That's why I'm working in doing cleanups.
Regards,
Sergio
Quoted 9 lines
--
Regards,Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html