Skip to contentSkip to conversation

Problem with sram size on OMAP1611 (OSK)

PATCH Tim Bird 4 participants 6 messages Nov 20, 2010 – Dec 10, 2010

Subsystems (2)
lore
Share & tools
lore

Tim Bird

author
#0 lore raw

Santosh,

I just tried the latest kernel (well, v2.6.36), and found a problem that bisected to the following commit:

commit e546f21b4b7af012d9f18edad6237339adfeb681

Author: Santosh Shilimkar <[email protected]>
Date:   Fri Sep 24 07:19:49 2010 +0100

ARM: 6408/1: omap: Map only available sram memory

I am testing Linux on an OSK board (with an OMAP1611), and the above commmit causes the machine to hang. I isolated the problem to the sram length. The commit above changes it to a value detected in omap_detect_sram(), but when this value is used, my OSK hangs on boot.

Below is the hack I used to work around this. I'm not sure what the problem is, but I'd be happy to provide more information or try other things, to fix support for omap1611 in mainline. I tried putting the 1024 * 1024 value into omap_detect_sram(), with no luck. There's some additional processing there which might alter the value. Or perhaps the current value there for omap_sram_size on a 1611 is just wrong.

arch/arm/plat-omap/sram.c +2 -0
index 10b3b4c..d4ba4fa 100644
@@ -236,6 +236,8 @@ void __init omap_map_sram(void)
        base = ROUND_DOWN(base, PAGE_SIZE);
        omap_sram_io_desc[0].pfn = __phys_to_pfn(base);
        omap_sram_io_desc[0].length = ROUND_DOWN(omap_sram_size, PAGE_SIZE);
+       if (cpu_is_omap1611())
+               omap_sram_io_desc[0].length = 1024 * 1024;
        iotable_init(omap_sram_io_desc, ARRAY_SIZE(omap_sram_io_desc));
 
        printk(KERN_INFO "SRAM: Mapped pa 0x%08lx to va 0x%08lx size: 0x%lx\n",

Regards,
-- Tim

=============================
Tim Bird
Architecture Group Chair, CE Linux Forum
Senior Staff Engineer, Sony Network Entertainment
=============================

#1 lore raw

Hi,

Quoted 30 lines · Tim Bird

Santosh,

I just tried the latest kernel (well, v2.6.36), and found a problem that bisected to the following commit:

commit e546f21b4b7af012d9f18edad6237339adfeb681

Author: Santosh Shilimkar <[email protected]>
Date:   Fri Sep 24 07:19:49 2010 +0100

ARM: 6408/1: omap: Map only available sram memory

I am testing Linux on an OSK board (with an OMAP1611), and the above commmit causes the machine to hang. I isolated the problem to the sram length. The commit above changes it to a value detected in omap_detect_sram(), but when this value is used, my OSK hangs on boot.

Below is the hack I used to work around this. I'm not sure what the problem is, but I'd be happy to provide more information or try other things, to fix support for omap1611 in mainline. I tried putting the 1024 * 1024 value into omap_detect_sram(), with no luck. There's some additional processing there which might alter the value. Or perhaps the current value there for omap_sram_size on a 1611 is just wrong.

arch/arm/plat-omap/sram.c +0 -0
index 10b3b4c..d4ba4fa 100644

arch/arm/plat-omap/sram.c void __init omap_map_sram(void) · line 243

Quoted 8 lines
arch/arm/plat-omap/sram.c +2 -0
@@ -236,6 +236,8 @@ void __init omap_map_sram(void)
        base = ROUND_DOWN(base, PAGE_SIZE);
        omap_sram_io_desc[0].pfn = __phys_to_pfn(base);
        omap_sram_io_desc[0].length = ROUND_DOWN(omap_sram_size, PAGE_SIZE);
+       if (cpu_is_omap1611())
+               omap_sram_io_desc[0].length = 1024 * 1024;
        iotable_init(omap_sram_io_desc, ARRAY_SIZE(omap_sram_io_desc));
 
        printk(KERN_INFO "SRAM: Mapped pa 0x%08lx to va 0x%08lx size: 0x%lx\n",

I'm not seeing this on my OSK, can you please check if this still happening with v2.6.37-rc4?

Regards,

Tony

#2 lore raw
Quoted 35 lines

-----Original Message-----
From: Tony Lindgren [mailto:tony at atomide.com]
Sent: Tuesday, December 07, 2010 5:49 AM
To: Tim Bird
Cc: santosh.shilimkar at ti.com; linux-arm-kernel at lists.infradead.org
Subject: Re: Problem with sram size on OMAP1611 (OSK)

Hi,

Quoted 25 lines · Tim Bird

Santosh,

I just tried the latest kernel (well, v2.6.36), and found a problem that bisected to the following commit:

commit e546f21b4b7af012d9f18edad6237339adfeb681

Author: Santosh Shilimkar <[email protected]>
Date:   Fri Sep 24 07:19:49 2010 +0100

ARM: 6408/1: omap: Map only available sram memory

I am testing Linux on an OSK board (with an OMAP1611), and the above commmit causes the machine to hang. I isolated the problem to the sram length. The commit above changes it to a value detected in omap_detect_sram(), but when this value is used, my OSK hangs on boot.

Below is the hack I used to work around this. I'm not sure what the problem is, but I'd be happy to provide more information or try other things, to fix support for omap1611 in mainline. I tried putting the 1024 * 1024 value into omap_detect_sram(), with no luck. There's some additional processing there which might alter the value. Or perhaps the current value there for omap_sram_size on a 1611 is just wrong.

Quoted 12 lines

arch/arm/plat-omap/sram.c void __init omap_map_sram(void) · line 238

Quoted 8 lines
arch/arm/plat-omap/sram.c +0 -0
index 10b3b4c..d4ba4fa 100644
@@ -236,6 +236,8 @@ void __init omap_map_sram(void)
        base = ROUND_DOWN(base, PAGE_SIZE);
        omap_sram_io_desc[0].pfn = __phys_to_pfn(base);
        omap_sram_io_desc[0].length = ROUND_DOWN(omap_sram_size,

PAGE_SIZE);

Quoted 3 lines
arch/arm/plat-omap/sram.c +2 -0
+       if (cpu_is_omap1611())
+               omap_sram_io_desc[0].length = 1024 * 1024;
        iotable_init(omap_sram_io_desc,

ARRAY_SIZE(omap_sram_io_desc));

Quoted 7 lines

arch/arm/plat-omap/sram.c void __init omap_map_sram(void) · line 242

Quoted 2 lines
arch/arm/plat-omap/sram.c +0 -0
        printk(KERN_INFO "SRAM: Mapped pa 0x%08lx to va 0x%08lx size:

0x%lx\n",

I'm not seeing this on my OSK, can you please check if this still happening with v2.6.37-rc4?

Any updates Tim ??

#3 lore raw
In reply to Tony Lindgren
Quoted 40 lines · Tony Lindgren

Hi,

Quoted 37 lines · Tim Bird

Santosh,

I just tried the latest kernel (well, v2.6.36), and found a problem that bisected to the following commit:

commit e546f21b4b7af012d9f18edad6237339adfeb681

Author: Santosh Shilimkar <[email protected]>
Date:   Fri Sep 24 07:19:49 2010 +0100

ARM: 6408/1: omap: Map only available sram memory

I am testing Linux on an OSK board (with an OMAP1611), and the above commmit causes the machine to hang. I isolated the problem to the sram length. The commit above changes it to a value detected in omap_detect_sram(), but when this value is used, my OSK hangs on boot.

Below is the hack I used to work around this. I'm not sure what the problem is, but I'd be happy to provide more information or try other things, to fix support for omap1611 in mainline. I tried putting the 1024 * 1024 value into omap_detect_sram(), with no luck. There's some additional processing there which might alter the value. Or perhaps the current value there for omap_sram_size on a 1611 is just wrong.

arch/arm/plat-omap/sram.c +2 -0
index 10b3b4c..d4ba4fa 100644
@@ -236,6 +236,8 @@ void __init omap_map_sram(void)
        base = ROUND_DOWN(base, PAGE_SIZE);
        omap_sram_io_desc[0].pfn = __phys_to_pfn(base);
        omap_sram_io_desc[0].length = ROUND_DOWN(omap_sram_size, PAGE_SIZE);
+       if (cpu_is_omap1611())
+               omap_sram_io_desc[0].length = 1024 * 1024;
        iotable_init(omap_sram_io_desc, ARRAY_SIZE(omap_sram_io_desc));
 
Quoted 4 lines

arch/arm/plat-omap/sram.c void __init omap_map_sram(void) · line 243

Quoted 1 line
arch/arm/plat-omap/sram.c +0 -0
        printk(KERN_INFO "SRAM: Mapped pa 0x%08lx to va 0x%08lx size: 0x%lx\n",

I'm not seeing this on my OSK, can you please check if this still happening with v2.6.37-rc4?

I have the same problem as Tim on my OSK using latest l-o master. Debugging this with Tony, we realized his OSK has a 1623 whereas mine (and presumably Tim's) has an omap1611. The SRAM code uses different SRAM sizes for 1611 and 1610/1623.

I have no idea what the "right" values of the SRAM size are for these parts.

Setting it to 256k got it booting for me, so will send a patch for that shortly.

Kevin

author
#4 lore raw
Quoted 41 lines · Kevin Hilman
Quoted 40 lines · Tony Lindgren

Hi,

Quoted 37 lines · Tim Bird

Santosh,

I just tried the latest kernel (well, v2.6.36), and found a problem that bisected to the following commit:

commit e546f21b4b7af012d9f18edad6237339adfeb681

Author: Santosh Shilimkar<[email protected]>
Date:   Fri Sep 24 07:19:49 2010 +0100

ARM: 6408/1: omap: Map only available sram memory

I am testing Linux on an OSK board (with an OMAP1611), and the above commmit causes the machine to hang. I isolated the problem to the sram length. The commit above changes it to a value detected in omap_detect_sram(), but when this value is used, my OSK hangs on boot.

Below is the hack I used to work around this. I'm not sure what the problem is, but I'd be happy to provide more information or try other things, to fix support for omap1611 in mainline. I tried putting the 1024 * 1024 value into omap_detect_sram(), with no luck. There's some additional processing there which might alter the value. Or perhaps the current value there for omap_sram_size on a 1611 is just wrong.

arch/arm/plat-omap/sram.c +2 -0
index 10b3b4c..d4ba4fa 100644
@@ -236,6 +236,8 @@ void __init omap_map_sram(void)
         base = ROUND_DOWN(base, PAGE_SIZE);
         omap_sram_io_desc[0].pfn = __phys_to_pfn(base);
         omap_sram_io_desc[0].length = ROUND_DOWN(omap_sram_size, PAGE_SIZE);
+       if (cpu_is_omap1611())
+               omap_sram_io_desc[0].length = 1024 * 1024;
         iotable_init(omap_sram_io_desc, ARRAY_SIZE(omap_sram_io_desc));
 
Quoted 3 lines
Quoted 3 lines

arch/arm/plat-omap/sram.c void __init omap_map_sram(void) · line 243

Quoted 1 line
arch/arm/plat-omap/sram.c +0 -0
         printk(KERN_INFO "SRAM: Mapped pa 0x%08lx to va 0x%08lx size: 0x%lx\n",

I'm not seeing this on my OSK, can you please check if this still happening with v2.6.37-rc4?

Sorry I didn't report back sooner. I was going to try another test to see if I could determine what size *did* work, but ran out of time. However, I tested v2.6.37-rc4, and it had the same problem I originally reported.

Kevin's explanation sounds likely to me.

Quoted 11 lines
Quoted 11 lines

I have the same problem as Tim on my OSK using latest l-o master. Debugging this with Tony, we realized his OSK has a 1623 whereas mine (and presumably Tim's) has an omap1611. The SRAM code uses different SRAM sizes for 1611 and 1610/1623.

I have no idea what the "right" values of the SRAM size are for these parts.

Setting it to 256k got it booting for me, so will send a patch for that shortly.

#5 lore raw
Quoted 11 lines · Tim Bird
Quoted 4 lines · Kevin Hilman
Quoted 3 lines · Tony Lindgren

I'm not seeing this on my OSK, can you please check if this still happening with v2.6.37-rc4?

Sorry I didn't report back sooner. I was going to try another test to see if I could determine what size *did* work, but ran out of time. However, I tested v2.6.37-rc4, and it had the same problem I originally reported.

Kevin's explanation sounds likely to me.

OK thanks, will queue it.

Tony