correct migrate_set_speed's args_type
PATCH 1/1 correct migrate_set_speed's args_type
The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
qmp-commands.hx +1 -1
@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,
Signature · 1 line
1.7.1
Quoted 4 lines · On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.Signed-off-by Wen Congyang
Nice catch.
Was caused by 07de3e60b05 and hence affects master only. Could you please mention that in the commit log? Also, your email address is missing in the signed-off-by line.
Quoted 18 lines
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)qmp-commands.hx +1
-1@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,
Quoted 6 lines · On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino <[email protected]>…
Quoted 3 lines · On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.
Quoted 7 lines
Quoted 1 line
Signed-off-by Wen CongyangNice catch.
Was caused by
07de3e60b05and hence affects master only. Could you please mention that in the commit log? Also, your email address is missing in the signed-off-by line.
There's another problem there: we used to accept a json number but now we accept only a json integer.
Markus, are you aware of this change?
Quoted 20 lines
Quoted 19 lines
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)qmp-commands.hx +1
-1@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,
At 2010年11月23日 21:31, Luiz Capitulino Write:
Quoted 11 lines
Quoted 8 lines · On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino <[email protected]>…
Quoted 4 lines · On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.Signed-off-by Wen Congyang
Quoted 8 lines
Quoted 5 lines
Nice catch.
Was caused by
07de3e60b05and hence affects master only. Could you please mention that in the commit log? Also, your email address is missing in the signed-off-by line.There's another problem there: we used to accept a json number but now we accept only a json integer.
Do you mean the parameter passed to migrate_set_speed by json should be float or integer?
But in the function do_migrate_set_speed(), we only accept a integer.
Quoted 25 lines
Markus, are you aware of this change?
Quoted 20 lines
Quoted 19 lines
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)qmp-commands.hx +1
-1@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,
Quoted 18 lines · On Wed, 24 Nov 2010 09:28:54 +0800 Wen Congyang <[email protected]> wrote:
At 2010年11月23日 21:31, Luiz Capitulino Write:
Quoted 17 lines
Quoted 13 lines · On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino <[email protected]>…
Quoted 4 lines · On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.Signed-off-by Wen CongyangNice catch.
Was caused by
07de3e60b05and hence affects master only. Could you please mention that in the commit log? Also, your email address is missing in the signed-off-by line.
Quoted 5 lines
Quoted 2 lines
There's another problem there: we used to accept a json number but now we accept only a json integer.
Do you mean the parameter passed to
migrate_set_speedby json should be float or integer?
We used to accept both until the aforementioned commit.
Quoted 1 line
But in the function
do_migrate_set_speed(), we only accept a integer.
Yes, that's a behavior change and I'd like to check with Markus that he's aware of it. In any case, I'll apply your fix as soon as you send me a new version with the changes I asked.
Quoted 27 lines
Quoted 26 lines
Markus, are you aware of this change?
Quoted 20 lines
Quoted 19 lines
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)qmp-commands.hx +1
-1@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,
PATCH v2 1/1 correct migrate_set_speed's args_type
The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.
This bug was caused by 07de3e60b05 and hence affects master only.
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
qmp-commands.hx +1 -1
@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,
-- 1.7.1
Luiz Capitulino
AppliedQuoted 6 lines · On Thu, 25 Nov 2010 09:06:05 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.This bug was caused by
07de3e60b05and hence affects master only.Signed-off-by Wen Congyang <[email protected]>
Applied, thanks.
Quoted 20 lines
--- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)qmp-commands.hx +1
-2@@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop, -- 1.7.1
[Note cc: Dan, Avi]
Quoted 13 lines · Luiz Capitulino
Quoted 10 lines · On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino <[email protected]>…
Quoted 4 lines · On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.Signed-off-by Wen CongyangNice catch.
Quoted 8 lines
Quoted 3 lines
Was caused by
07de3e60b05and hence affects master only. Could you please mention that in the commit log? Also, your email address is missing in the signed-off-by line.There's another problem there: we used to accept a json number but now we accept only a json integer.
Markus, are you aware of this change?
I pointed out the incompatible change in my review[*] of the offending patch:
This isn't backwards bug-compatible.
Before, a client could send any number. Any fractional part was ignored.
Now, the number must be an integer. Other numbers are rejected.
I don't care myself, but others have argued most forcefully for keeping QMP fully backward compatible from 0.13 on, so they might object.
"Others" did not object, so this went in. Not released yet, so it's not too late to object.
[*] http://lists.gnu.org/archive/html/qemu-devel/2010-09/msg01905.html
Quoted 21 lines · On Fri, 10 Dec 2010 16:20:34 +0100 Markus Armbruster <[email protected]> wrote:
[Note cc: Dan, Avi]
Quoted 17 lines · Luiz Capitulino
Quoted 13 lines · On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino <[email protected]>…
Quoted 4 lines · On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang <[email protected]> wrote:
The
args_typeofmigrate_set_speedin qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped.Signed-off-by Wen CongyangNice catch.
Was caused by
07de3e60b05and hence affects master only. Could you please mention that in the commit log? Also, your email address is missing in the signed-off-by line.
Quoted 7 lines
Quoted 4 lines
There's another problem there: we used to accept a json number but now we accept only a json integer.
Markus, are you aware of this change?
I pointed out the incompatible change in my review[*] of the offending patch:
Ok, I can remember now. I really think this is a small improvement and I doubt there's any client out there depending on this.
Quoted 16 lines
This isn't backwards bug-compatible.
Before, a client could send any number. Any fractional part was ignored.
Now, the number must be an integer. Other numbers are rejected.
I don't care myself, but others have argued most forcefully for keeping QMP fully backward compatible from 0.13 on, so they might object.
"Others" did not object, so this went in. Not released yet, so it's not too late to object.
[*] http://lists.gnu.org/archive/html/qemu-devel/2010-09/msg01905.html