Skip to contentSkip to conversation

Fixed an issue causing a build failure with MS Visual Studio 2008

PATCH In review Samuli Seppänen 2 participants 2 messages Nov 25, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixed an issue causing a build failure with MS Visual Studio 2008

From 36baafa15e414ab37823160801eaa340171563aa Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= <[email protected]...>
Date: Thu, 25 Nov 2010 21:48:34 +0200
Subject: [PATCH] Fixed an issue causing a build failure with MS Visual Studio 2008.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

The new SOCKS auth code in socks.c contained a call to sprintf instead of openvpn_sprintf. This caused build to fail if MS Visual Studio 2008 C compiler was used. This change fixes that issue.

---
 socks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
socks.c +1 -1
index 1848f08..8287274 100644
@@ -121,7 +121,7 @@ socks_username_password_auth (struct socks_proxy_info *p,
                "Authentication not possible.");
           return false;
   }
-  snprintf (to_send, sizeof (to_send), "\x01%c%s%c%s", (int) strlen(creds.username),
+  openvpn_snprintf (to_send, sizeof (to_send), "\x01%c%s%c%s", (int) strlen(creds.username),
             creds.username, (int) strlen(creds.password), creds.password);
   size = send (sd, to_send, strlen(to_send), MSG_NOSIGNAL);
 
Signature · 1 line
1.6.3.3
Acked-by on v1 1/1
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25/11/10 21:01, Samuli Seppänen wrote:

|
|> From 36baafa15e414ab37823160801eaa340171563aa Mon Sep 17 00:00:00 2001
| From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?=<[email protected]...>
| Date: Thu, 25 Nov 2010 21:48:34 +0200
| Subject: [PATCH] Fixed an issue causing a build failure with MS Visual
Studio 2008.
|
| The new SOCKS auth code in socks.c contained a call to sprintf instead of
| openvpn_sprintf. This caused build to fail if MS Visual Studio 2008 C compiler
| was used. This change fixes that issue.
|
| Signed-off-by: Samuli Seppänen<[email protected]...>
| ---
|   socks.c |    2 +-
|   1 files changed, 1 insertions(+), 1 deletions(-)
|

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzuwZ0ACgkQDC186MBRfro98wCgpJKW88UxgCR/LkosCIcfvPI7 nVgAn3mNJEf/se1FmK0+UqEU1DxdBQhy
=RlX7
-----END PGP SIGNATURE-----