Skip to contentSkip to conversation

your patch "x86, olpc: Rework BIOS signature check"

DISCUSSION Jan Beulich 2 participants 2 messages Nov 26, 2010

lore
Share & tools
lore
#0 lore raw

... adds a select of OLPC_OPENFIRMWARE to the OLPC option, which contradicts OLPC_OPENFIRMWARE itself depending on !X86_64 && !X86_PAE. Are the latter dependencies not necessary anymore (the X86_64 one wasn't very meaningful anyway, since these options all sit inside a "if X86_32"), or should the select be conditional?

Also, how meaningful is having OLPC_OPENFIRMWARE on but OLPC off (i.e. can OLPC_OPENFIRMWARE perhaps go away altogether)?

Thanks, Jan

#1 lore raw

Hi Jan,

Quoted 9 lines · Jan Beulich

... adds a select of OLPC_OPENFIRMWARE to the OLPC option, which contradicts OLPC_OPENFIRMWARE itself depending on !X86_64 && !X86_PAE. Are the latter dependencies not necessary anymore (the X86_64 one wasn't very meaningful anyway, since these options all sit inside a "if X86_32"), or should the select be conditional?

Also, how meaningful is having OLPC_OPENFIRMWARE on but OLPC off (i.e. can OLPC_OPENFIRMWARE perhaps go away altogether)?

Yeah, having reached this point we think OLPC_OPENFIRMWARE should be merged into CONFIG_OLPC. I'll submit a patch soon.

Daniel