Skip to contentSkip to conversation

timer.c changes

U-Boot Nick Thompson 2 participants 2 messages Dec 2, 2010

lore
Share & tools
lore
#0 lore raw

I have changed the davinci timer code to work with the, originally at91 only, gd variables:

	unsigned long	timer_rate_hz;
	unsigned long	tbl;
	unsigned long	tbu;
	unsigned long long	timer_reset_value;

It does use the timer_reset_value to keep compatibility with places where timers are not used correctly.

I have tested it on da830evm and it my board now boots correctly.

Has it been agreed on the way forward for these timer fixes? Is it worth me posting the patch?

It does seem to me that there would be room for a common layer and a arch specific tbl/tbu emulation layer as suggested here:

http://lists.denx.de/pipermail/u-boot/2010-November/081377.html

but maybe it would be good to get more boards working prior to release and then look at how they can be made more common later?

Nick.

#1 lore raw

Hi Nick,

Quoted 8 lines · Nick Thompson

I have changed the davinci timer code to work with the, originally at91 only, gd variables:

? ? ? ?unsigned long ? timer_rate_hz;
? ? ? ?unsigned long ? tbl;
? ? ? ?unsigned long ? tbu;
? ? ? ?unsigned long long ? ? ?timer_reset_value;

Quoted 7 lines

It does use the timer_reset_value to keep compatibility with places where timers are not used correctly.

I have tested it on da830evm and it my board now boots correctly.

Has it been agreed on the way forward for these timer fixes? Is it worth me posting the patch?

I am very interested in taking your patch for a test-drive.

Quoted 2 lines

but maybe it would be good to get more boards working prior to release and then look at how they can be made more common later?

+1 for that.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca