Skip to contentSkip to conversation

mpcore watchdogs questions

DISCUSSION Per Fransson 3 participants 4 messages Dec 3, 2010 – Dec 6, 2010

lore
Share & tools
lore
#0 lore raw

Hi,

I have some questions regarding the ARM mpcore watchdogs and the kernel watchdog API in the case of a Cortex-A9. These local watchdogs have two properties which appear to make them less well-suited to the existing framework:

1) Their clocking is tied to that of the cores, in the sense that the WDs are unclocked if the interrupt controller is. There's nothing we can do about this, but it does mean that they can't be used to watch over a sleeping system and therefore that we don't want the user space kicker to be driven by a timer which will cause a wake-up - not when power management is an issue. In the kernel there are deferred timers to use for these cases, but the kicker doesn't live there.

2) They are local to each core, which gives us at least these alternatives:

* Use only one of them and...
- set the affinity of the user space kicker to the corresponding core, or
- let the kicker migrate, but get the message to the correct core in kernel space through IPI

* Use all of them and...
- One user space kicker per core, or
- One user space kicker, but with "cyclic affinity", or
- One user-space kicker, but each kick causes all the cores to get the message in kernel space, again using IPIs

All of the above assumes these local watchdogs should be shoe-horned into the existing framework in the first place. Should they? Another alternative is to somehow use them to watch over the lockup detectors in

kernel/{softlockup,watchdog}.c

Maybe there are other options as well.

Regards,
Per Fransson

#1 lore raw
Quoted 29 lines · Per Fransson

Hi,

I have some questions regarding the ARM mpcore watchdogs and the kernel watchdog API in the case of a Cortex-A9. These local watchdogs have two properties which appear to make them less well-suited to the existing framework:

1) Their clocking is tied to that of the cores, in the sense that the WDs are unclocked if the interrupt controller is. There's nothing we can do about this, but it does mean that they can't be used to watch over a sleeping system and therefore that we don't want the user space kicker to be driven by a timer which will cause a wake-up - not when power management is an issue. In the kernel there are deferred timers to use for these cases, but the kicker doesn't live there.

2) They are local to each core, which gives us at least these alternatives:

* Use only one of them and...
- set the affinity of the user space kicker to the corresponding core, or
- let the kicker migrate, but get the message to the correct core in kernel space through IPI

* Use all of them and...
- One user space kicker per core, or
- One user space kicker, but with "cyclic affinity", or
- One user-space kicker, but each kick causes all the cores to get the message in kernel space, again using IPIs

Quoted 7 lines

All of the above assumes these local watchdogs should be shoe-horned into the existing framework in the first place. Should they? Another alternative is to somehow use them to watch over the lockup detectors in

kernel/{softlockup,watchdog}.c

Maybe there are other options as well.

I am not entirely sure what you are looking for, but the kernel/{softlockup,watchdog}.c takes a different approach to a normal watchdog. Normal watchdogs have somebody kick them so they stay asleep, with the intention that if they wake up bad things happened.

The hard/soft lockup detector will always wake up at a periodic rate and check to see if they system has progressed since the last check. Unfortunately, because of its periodic rate, it will cause wakeup events (though every 60 seconds isn't that bad is it? :-) ), except for the hardlockup case which uses the NMI. That is tied to cpu activity and won't fire an NMI if the cpu is sleeping.

There have been talks about trying to tie the hrtimer and the kthread to the power management layer with the idea that if the system is sleeping there is no need to increment interrupt stats (using hrtimer) or check process usage (using the kthread). That would cut down the number of wakeups.

Cheers,
Don

#2 lore raw
Quoted 1 line

I am not entirely sure what you are looking for, but the

Well, the basic premise of the question is this:

We have these per-CPU watchdogs,
what's the best fit for them in a linux kernel setting?

Now, there's already a driver for these WDs, but even so the existing watchdog framework seems more suited to non-local watchdogs which can be counted on to stay awake all the time.

Quoted 11 lines

kernel/{softlockup,watchdog}.c takes a different approach to a normal watchdog. ?Normal watchdogs have somebody kick them so they stay asleep, with the intention that if they wake up bad things happened.

The hard/soft lockup detector will always wake up at a periodic rate and check to see if they system has progressed since the last check. Unfortunately, because of its periodic rate, it will cause wakeup events (though every 60 seconds isn't that bad is it? :-) ), except for the hardlockup case which uses the NMI. ?That is tied to cpu activity and won't fire an NMI if the cpu is sleeping.

Quoted 6 lines

There have been talks about trying to tie the hrtimer and the kthread to the power management layer with the idea that if the system is sleeping there is no need to increment interrupt stats (using hrtimer) or check process usage (using the kthread). ?That would cut down the number of wakeups.

The way I see it, the idea behind the lockup detection code, and please correct me if I'm wrong, is to cover the following case on a per-CPU basis:

* Assuming the CPU in question is actually chugging along, is it getting real work
done, where "real work" is defined as being able to schedule a high-prio kernel thread and have it perform the actions expected of it (kicking the watchdog). In the hardlockup case "real work" is instead defined as being able to respond to
hrtimers going off.

So, this is precisely why the Cortex-A9 mpcore WDs might work better as a part of
the lockup detection code, they can only watch a CPU which is awake (enough) and they do so on a per-CPU basis.

Regards,
Per

#3 lore raw
Quoted 11 lines · Per Fransson

The way I see it, the idea behind the lockup detection code, and please correct me if I'm wrong, is to cover the following case on a per-CPU basis:

* Assuming the CPU in question is actually chugging along, is it getting real work
done, where "real work" is defined as being able to schedule a high-prio kernel thread and have it perform the actions expected of it (kicking the watchdog). In the hardlockup case "real work" is instead defined as being able to respond to
hrtimers going off.

Yup, that sounds right.

Cheers,
Don