Skip to contentSkip to conversation

Clean up cpu_inject_x86_mce().

PATCH Applied Jin Dongming 2 participants 2 messages Dec 10, 2010 – Dec 20, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Clean up cpu_inject_x86_mce().

Hi, all

I am sorry for replying late.
I modified the patches as the comments of huang-san and Marcelo-san and resend them.

Thanks.

Best Regards,
Jin Dongming
-----------------------------------------------------------
Clean up cpu_inject_x86_mce() for later patch.

---
 target-i386/helper.c |   27 +++++++++++++++++----------
 1 files changed, 17 insertions(+), 10 deletions(-)
target-i386/helper.c +17 -10
index d765cc6..9c07c38 100644
@@ -1023,21 +1023,12 @@ static void breakpoint_handler(CPUState *env)
 /* This should come from sysemu.h - if we could include it here... */
 void qemu_system_reset_request(void);
 
-void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
+static void qemu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
                         uint64_t mcg_status, uint64_t addr, uint64_t misc)
 {
     uint64_t mcg_cap = cenv->mcg_cap;
-    unsigned bank_num = mcg_cap & 0xff;
     uint64_t *banks = cenv->mce_banks;
 
-    if (bank >= bank_num || !(status & MCI_STATUS_VAL))
-        return;
-
-    if (kvm_enabled()) {
-        kvm_inject_x86_mce(cenv, bank, status, mcg_status, addr, misc, 0);
-        return;
-    }
-
     /*
      * if MSR_MCG_CTL is not all 1s, the uncorrected error
      * reporting is disabled
@@ -1078,6 +1069,22 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
     } else
         banks[1] |= MCI_STATUS_OVER;
 }
+
+void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status,
+                        uint64_t mcg_status, uint64_t addr, uint64_t misc)
+{
+    unsigned bank_num = cenv->mcg_cap & 0xff;
+
+    if (bank >= bank_num || !(status & MCI_STATUS_VAL)) {
+        return;
+    }
+
+    if (kvm_enabled()) {
+        kvm_inject_x86_mce(cenv, bank, status, mcg_status, addr, misc, 0);
+    } else {
+        qemu_inject_x86_mce(cenv, bank, status, mcg_status, addr, misc);
+    }
+}
 #endif /* !CONFIG_USER_ONLY */
 
 static void mce_init(CPUX86State *cenv)
Signature · 1 line
1.7.1.1
#1 lore raw
Quoted 5 lines · Jin Dongming

Hi, all

I am sorry for replying late.
I modified the patches as the comments of huang-san and Marcelo-san and resend them.

Applied all 3 to uq/master, thanks.