Skip to contentSkip to conversation

qmp,nmi: convert do_inject_nmi() to QObject, QError

PATCH In review Lai Jiangshan 2 participants 2 messages Dec 20, 2010 KVM

lore
Share & tools
lore

Lai Jiangshan

author
#0 lore raw

PATCH v4 3/3 qmp,nmi: convert do_inject_nmi() to QObject, QError

Make we can inject NMI via qemu-monitor-protocol.
We use "inject-nmi" for the qmp command name, the meaning is clearer. When cpu-index is found invalid in runtime, it will report QERR_INVALID_PARAMETER_VALUE.

Signed-off-by Lai Jiangshan <[email protected]>

---

hmp-commands.hx +2 -1
index d8fe4c0..f6d4c2f 100644
@@ -724,7 +724,8 @@ ETEXI
         .args_type  = "cpu-index:i?",
         .params     = "[cpu]",
         .help       = "inject an NMI on all CPUs or the given CPU",
-        .mhandler.cmd = do_inject_nmi,
+        .user_print = monitor_user_noop,
+        .mhandler.cmd_new = do_inject_nmi,
     },
 #endif
 STEXI
monitor.c +6 -3
index 45a8dc2..d90d6f5 100644
@@ -2407,7 +2407,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
 #endif
 
 #if defined(TARGET_I386)
-static void do_inject_nmi(Monitor *mon, const QDict *qdict)
+static int do_inject_nmi(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
     CPUState *env;
     int cpu_index = qdict_get_try_int(qdict, "cpu-index", -1);

@@ -2415,14 +2415,17 @@ static void do_inject_nmi(Monitor *mon, const QDict *qdict)
     if (cpu_index == -1) {
         for (env = first_cpu; env != NULL; env = env->next_cpu)
             cpu_interrupt(env, CPU_INTERRUPT_NMI);
-        return;
+        return 0;
     }
 
     for (env = first_cpu; env != NULL; env = env->next_cpu)
         if (env->cpu_index == cpu_index) {
             cpu_interrupt(env, CPU_INTERRUPT_NMI);
-            break;
+            return 0;
         }
+
+    qerror_report(QERR_INVALID_PARAMETER_VALUE, "cpu-index", "a CPU number");
+    return -1;
 }
 #endif
qmp-commands.hx +27 -0
index 3486223..8cca5c3 100644
@@ -429,6 +429,33 @@ Example:
 
 EQMP
 
+#if defined(TARGET_I386)
+    {
+        .name       = "inject_nmi",
+        .args_type  = "cpu-index:i?",
+        .params     = "[cpu]",
+        .help       = "inject an NMI on all CPUs or the given CPU",
+        .user_print = monitor_user_noop,
+        .mhandler.cmd_new = do_inject_nmi,
+    },
+#endif
+SQMP
+inject_nmi
+----------
+
+Inject an NMI on the given CPU (x86 only).
+
+Arguments:
+
+- "cpu_index": the index of the CPU to be injected NMI (json-int)
+
+Example:
+
+-> { "execute": "inject_nmi", "arguments": { "cpu-index": 0 } }
+<- { "return": {} }
+
+EQMP
+
     {
         .name       = "migrate",
         .args_type  = "detach:-d,blk:-b,inc:-i,uri:s",
#1 lore raw

Re: [Qemu-devel] [PATCH V4 3/3] qmp, nmi: convert do_inject_nmi() to QObject, QError

Quoted 4 lines · Lai Jiangshan

Make we can inject NMI via qemu-monitor-protocol.
We use "inject-nmi" for the qmp command name, the meaning is clearer. When cpu-index is found invalid in runtime, it will report QERR_INVALID_PARAMETER_VALUE.

This patch does two separate things:

1. Fix do_inject_nmi() to detect invalid arguments.

2. Convert it to QObject.

If you have to respin anyway, please split the patch to keep the two separate.