Skip to contentSkip to conversation

fix bug of tst_brk

PATCH In review Bian Naimeng 2 participants 2 messages Dec 28, 2010 – Jan 2, 2011 Library code

lore
Share & tools
lore

Bian Naimeng

author
#0 lore raw

PATCH 1/1 fix bug of tst_brk

Test will fail if invoke tst_brk with (TCONF | TERRNO), it's not our expectation.

Signed-off-by Bian Naimeng <[email protected]>
---
 lib/tst_res.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
lib/tst_res.c +4 -4
index 2debd44..193653f 100644
@@ -616,21 +616,21 @@ void tst_brk(int ttype, char *fname, void (*func)(void), char *arg_fmt, ...)
 		sprintf(Warn_mesg, "tst_brk(): Invalid Type: %d.  Using TBROK",
 			ttype_result);
 		tst_print(TCID, 0, TWARN, Warn_mesg);
-		ttype = TBROK;
+		ttype = (ttype & ~ttype_result) | TBROK;
 	}
 
 	/* Print the first result, if necessary. */
 	if (Tst_count < TST_TOTAL)
 		tst_res(ttype, fname, "%s", tmesg);
 
-	if (ttype == TCONF) {
+	if (ttype_result == TCONF) {
 		tst_res(ttype, NULL,
 			"Remaining cases not appropriate for configuration");
 	} else {
-		if (ttype == TRETR)
+		if (ttype_result == TRETR)
 			tst_res(ttype, NULL, "Remaining cases retired");
 		else
-			tst_res(TBROK, NULL, "Remaining cases broken");
+			tst_res(ttype, NULL, "Remaining cases broken");
 	}
 	Expand_varargs = TRUE;
Signature · 20 lines
1.7.0.4




-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw
Quoted 3 lines · Bian Naimeng

Test will fail if invoke tst_brk with (TCONF | TERRNO), it's not our expectation.

Signed-off-by Bian Naimeng <[email protected]>

Good catch -- thanks!
-Garrett
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list