macintosh: wrong test in fan_{read,write}_reg()

PATCH New roel kluin 1 participant 1 message Dec 31, 2010 Linux for power macintosh

lore

Share & tools

lore

roel kluin

author

2010-12-31 14:57 UTC #0 lore raw

PATCH 1/1 macintosh: wrong test in fan_{read,write}_reg()

Fix error test in fan_{read,write}_reg()

Signed-off-by Roel Kluin <[email protected]>

---
 drivers/macintosh/therm_pm72.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

ENODEV and EIO are positive (22 and 8), so the tests did not work.

drivers/macintosh/therm_pm72.c +2 -2

index 4454927..6256a08 100644
@@ -443,7 +443,7 @@ static int fan_read_reg(int reg, unsigned char *buf, int nb)
 	tries = 0;
 	for (;;) {
 		nr = i2c_master_recv(fcu, buf, nb);
-		if (nr > 0 || (nr < 0 && nr != ENODEV) || tries >= 100)
+		if (nr > 0 || (nr < 0 && nr != -ENODEV) || tries >= 100)
 			break;
 		msleep(10);
 		++tries;

@@ -464,7 +464,7 @@ static int fan_write_reg(int reg, const unsigned char *ptr, int nb)
 	tries = 0;
 	for (;;) {
 		nw = i2c_master_send(fcu, buf, nb);
-		if (nw > 0 || (nw < 0 && nw != EIO) || tries >= 100)
+		if (nw > 0 || (nw < 0 && nw != -EIO) || tries >= 100)
 			break;
 		msleep(10);
 		++tries;