Skip to contentSkip to conversation

e2fsprogs.inc - break shared libs into separate packages

PATCH Koen Kooi 2 participants 5 messages Jan 2, 2011 – Jan 4, 2011 1 message not in the archive

lore
Share & tools
lore

Koen Kooi

author
#1 lore raw
In reply to a message not in the archive

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 5 lines · Mike Westerhof

Break the two shared libraries (libe2p and libext2fs) out of the general e2fsprogs package and into their own packages. This avoids pulling in unwanted executables when a distro only desires the basic tools (such as e2fsck and/or mke2fs).

Recipes with e2fsprogs in DEPENDS will need a PR bump as well, since they might link to these libs as well. This will result in missing libraries when using package feeds.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNILjgMkyGM64RGpERAl63AJ9d+oy10QAFluRD89/YB6g9ircOuwCfXljo L2xm9I2E6/rkDke1UFvCG9c=
=Xptt
-----END PGP SIGNATURE-----

#2 lore raw
Quoted 8 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · Mike Westerhof

Break the two shared libraries (libe2p and libext2fs) out of the general e2fsprogs package and into their own packages. This avoids pulling in unwanted executables when a distro only desires the basic tools (such as e2fsck and/or mke2fs).

Quoted 5 lines
Quoted 1 line

Recipes with e2fsprogs in DEPENDS will need a PR bump as well, since they might link to these libs as well. This will result in missing libraries when using package feeds.

Ok, I can do that. But I'm not sure I understand why this is the case.
OE detects the dependencies on the shared libs, and automagically adds
the necessary dependencies to the opkg control file. Hence, if opkg on a device updates "e2fsprogs", it will see that the new version of "e2fsprogs" depends on the two new libraries, and it should pull those in from the feeds as well.

Perhaps a use-case that will fail will help me understand, and consequently, help me put together a more-correct patch.

Thanks,
-Mike (mwester)

Quoted 18 lines

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNILjgMkyGM64RGpERAl63AJ9d+oy10QAFluRD89/YB6g9ircOuwCfXljo L2xm9I2E6/rkDke1UFvCG9c=
=Xptt
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

author
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Mike Westerhof

On 1/2/2011 11:41 AM, Koen Kooi wrote:

Quoted 4 lines · Mike Westerhof
Quoted 4 lines
Quoted 4 lines

Break the two shared libraries (libe2p and libext2fs) out of the general e2fsprogs package and into their own packages. This avoids pulling in unwanted executables when a distro only desires the basic tools (such as e2fsck and/or mke2fs).

Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

Recipes with e2fsprogs in DEPENDS will need a PR bump as well, since they might link to these libs as well. This will result in missing libraries when using package feeds.

Quoted 9 lines

Ok, I can do that. But I'm not sure I understand why this is the case.
OE detects the dependencies on the shared libs, and automagically adds
the necessary dependencies to the opkg control file. Hence, if opkg on a device updates "e2fsprogs", it will see that the new version of "e2fsprogs" depends on the two new libraries, and it should pull those in from the feeds as well.

Perhaps a use-case that will fail will help me understand, and consequently, help me put together a more-correct patch.

Say you have built gparted which (r)depends on e2fsprogs and links to libe2p. After this patch the "old" gparted in the feeds will only pull in e2fsprogs and not libe2p.
If the e2fsprogs package rdepends on libe2p and friends this isn't a problem, but if it doesn't you'll get spurious libs. This has happened a number of times in the past and I'd like to avoid it happening in the future :)

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNIX+IMkyGM64RGpERAocMAKCNlUquJdgA123i1BMNnd3ujNX31QCdFEMq MJ2FPNrTiy83dOjrCb3BtZ0=
=CJpP
-----END PGP SIGNATURE-----

#4 lore raw
Quoted 26 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Mike Westerhof

On 1/2/2011 11:41 AM, Koen Kooi wrote:

Quoted 4 lines · Mike Westerhof
Quoted 4 lines
Quoted 4 lines

Break the two shared libraries (libe2p and libext2fs) out of the general e2fsprogs package and into their own packages. This avoids pulling in unwanted executables when a distro only desires the basic tools (such as e2fsck and/or mke2fs).

Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

Recipes with e2fsprogs in DEPENDS will need a PR bump as well, since they might link to these libs as well. This will result in missing libraries when using package feeds.

Quoted 9 lines

Ok, I can do that. But I'm not sure I understand why this is the case.
OE detects the dependencies on the shared libs, and automagically adds
the necessary dependencies to the opkg control file. Hence, if opkg on a device updates "e2fsprogs", it will see that the new version of "e2fsprogs" depends on the two new libraries, and it should pull those in from the feeds as well.

Perhaps a use-case that will fail will help me understand, and consequently, help me put together a more-correct patch.

Quoted 7 lines

Say you have built gparted which (r)depends on e2fsprogs and links to libe2p. After this patch the "old" gparted in the feeds will only pull in e2fsprogs and not libe2p.
If the e2fsprogs package rdepends on libe2p and friends this isn't a problem, but if it doesn't you'll get spurious libs. This has happened a number of times in the past and I'd like to avoid it happening in the future :)

Got it. So here's the pertinent line from the control file in the e2fsck ipk:

"Depends: util-linux-ng, e2fsprogs-badblocks, libext2fs2, libcom-err2, libe2p2, libuuid1, libc6, libgcc1, libss2, libblkid1"

Both new library packages (libext2fs2 and libe2p2) are present and will be pulled in by opkg, so no other packages will require PR bumps.

Quoted 3 lines

regards,

Koen

-Mike (mwester)

author Acked-by
#5 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 35 lines · Mike Westerhof
Quoted 26 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Mike Westerhof

On 1/2/2011 11:41 AM, Koen Kooi wrote:

Quoted 4 lines · Mike Westerhof
Quoted 4 lines
Quoted 4 lines

Break the two shared libraries (libe2p and libext2fs) out of the general e2fsprogs package and into their own packages. This avoids pulling in unwanted executables when a distro only desires the basic tools (such as e2fsck and/or mke2fs).

Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

Recipes with e2fsprogs in DEPENDS will need a PR bump as well, since they might link to these libs as well. This will result in missing libraries when using package feeds.

Quoted 9 lines

Ok, I can do that. But I'm not sure I understand why this is the case.
OE detects the dependencies on the shared libs, and automagically adds
the necessary dependencies to the opkg control file. Hence, if opkg on a device updates "e2fsprogs", it will see that the new version of "e2fsprogs" depends on the two new libraries, and it should pull those in from the feeds as well.

Perhaps a use-case that will fail will help me understand, and consequently, help me put together a more-correct patch.

Quoted 7 lines

Say you have built gparted which (r)depends on e2fsprogs and links to libe2p. After this patch the "old" gparted in the feeds will only pull in e2fsprogs and not libe2p.
If the e2fsprogs package rdepends on libe2p and friends this isn't a problem, but if it doesn't you'll get spurious libs. This has happened a number of times in the past and I'd like to avoid it happening in the future :)

Quoted 8 lines

Got it. So here's the pertinent line from the control file in the e2fsck ipk:

"Depends: util-linux-ng, e2fsprogs-badblocks, libext2fs2, libcom-err2, libe2p2, libuuid1, libc6, libgcc1, libss2, libblkid1"

Both new library packages (libext2fs2 and libe2p2) are present and will be pulled in by opkg, so no other packages will require PR bumps.

Awesome! Thanks for checking.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNItfZMkyGM64RGpERAvCLAKC9BjKNaH7OCwb+zCLTa383UpGJ7ACgpJrR Nm9ZRWgWzxEdXMInxccB3yE=
=TyUM
-----END PGP SIGNATURE-----