Skip to contentSkip to conversation

random bugfixes of the space management

PATCH In review Miao Xie 2 participants 3 messages Jan 5, 2011 – Jan 12, 2011 Btrfs file system

lore
Share & tools
lore

Miao Xie

author
#0 lore raw

v3 cover random bugfixes of the space management

Hello, Chris

I have a bunch of random fixes of the space management in

git://repo.or.cz/linux-btrfs-devel.git space-manage

They are the ENOSPC fixes, as well as fixes for df command.
The first one and the last one fixed the wrong free space information reported by df command. The second one fixed ENOSPC when there is tiny space in the filesystem. And The third fixed wrong calculation of stripe size. And the 4th and 5th patches fixed the chunk allocation problem when the block devices have no enough space to allocate a default-size chunk.

Changelog V2 -> V3:
- fix panic caused by freeing a invalid memory address.

Changelog V1 -> V2:
- fix compiler errors on x86_32 machines.
- fix some bugs when allocating dup chunks.
- break the chunk allocation when errors happen.
- just allocate min_stripes stripes when the free space is not enough.
- cleanup redundant code.

If you want to merge this patchset to your "next" branch for testing, you can merge it directly after dropping the top four patches of the "next" branch.

Thanks
Miao

---
 fs/btrfs/ctree.h       |    2 +
 fs/btrfs/extent-tree.c |   71 +++++-
 fs/btrfs/super.c       |  147 +++++++++++-
 fs/btrfs/volumes.c     |  614 +++++++++++++++++++++++++++++++++++-------------
 fs/btrfs/volumes.h     |   27 ++
 5 files changed, 685 insertions(+), 176 deletions(-)
#1 lore raw

2011/1/5 Miao Xie <[email protected]>:

Quoted 8 lines

Hello, Chris

I have a bunch of random fixes of the space management in

git://repo.or.cz/linux-btrfs-devel.git space-manage

They are the ENOSPC fixes, as well as fixes for df command. The first one and the last one fixed the wrong free space information=

reported

Quoted 1 line

by df command. The second one fixed ENOSPC when there is tiny space i=

n the

Quoted 1 line

filesystem. And The third fixed wrong calculation of stripe size. And=

the 4th

Quoted 1 line

and 5th patches fixed the chunk allocation problem when the block dev=

ices have

Quoted 10 lines

no enough space to allocate a default-size chunk.

Changelog V2 -> V3:
- fix panic caused by freeing a invalid memory address.

Changelog V1 -> V2:
- fix compiler errors on x86_32 machines.
- fix some bugs when allocating dup chunks.
- break the chunk allocation when errors happen.
- just allocate min_stripes stripes when the free space is not enough=

=2E

Quoted 3 lines

- cleanup redundant code.

If you want to merge this patchset to your "next" branch for testing,=

you can merge it

Quoted 9 lines

directly after dropping the top four patches of the "next" branch.

Thanks
Miao
---
=A0fs/btrfs/ctree.h =A0 =A0 =A0 | =A0 =A02 + =A0fs/btrfs/extent-tree.c | =A0 71 +++++- =A0fs/btrfs/super.c =A0 =A0 =A0 | =A0147 +++++++++++- =A0fs/btrfs/volumes.c =A0 =A0 | =A0614 ++++++++++++++++++++++++++++++=

+++++-------------

Quoted 3 lines

=A0fs/btrfs/volumes.h =A0 =A0 | =A0 27 ++
=A05 files changed, 685 insertions(+), 176 deletions(-)

The problems I was encountering in the V2 version of this patch set are fixed in V3.

Thanks for the updates.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" = in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
In reply to Miao Xie

Any comments for these patches?

Thanks
Miao

Quoted 38 lines · Miao Xie

I have a bunch of random fixes of the space management in

git://repo.or.cz/linux-btrfs-devel.git space-manage

They are the ENOSPC fixes, as well as fixes for df command.
The first one and the last one fixed the wrong free space information reported by df command. The second one fixed ENOSPC when there is tiny space in the filesystem. And The third fixed wrong calculation of stripe size. And the 4th and 5th patches fixed the chunk allocation problem when the block devices have no enough space to allocate a default-size chunk.

Changelog V2 -> V3:
- fix panic caused by freeing a invalid memory address.

Changelog V1 -> V2:
- fix compiler errors on x86_32 machines.
- fix some bugs when allocating dup chunks.
- break the chunk allocation when errors happen.
- just allocate min_stripes stripes when the free space is not enough.
- cleanup redundant code.

If you want to merge this patchset to your "next" branch for testing, you can merge it directly after dropping the top four patches of the "next" branch.

Thanks
Miao

---
  fs/btrfs/ctree.h       |    2 +
  fs/btrfs/extent-tree.c |   71 +++++-
  fs/btrfs/super.c       |  147 +++++++++++-
  fs/btrfs/volumes.c     |  614 +++++++++++++++++++++++++++++++++++-------------
  fs/btrfs/volumes.h     |   27 ++
  5 files changed, 685 insertions(+), 176 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html