link error w/ media-0006-sensors
Hi Laurent & Sakari,
On Laurent's media-0006-sensors branch, when compiling with CONFIG_VIDEO_OMAP3=m, I got the following linking error:
ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko] undefined!
I can get rid of the error with the patch below. But as always, I
wonder: Why didn't anybody else come across this error? Are you all compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see where someone is using that?
And would anything be wrong with the patch below?
-Michael
arch/arm/plat-omap/omap-pm-noop.c +1 -0
@@ -88,6 +88,7 @@ int omap_pm_set_min_bus_tput(struct device *dev, u8 agent_id, unsigned long r)return 0 ; } +EXPORT_SYMBOL_GPL (omap_pm_set_min_bus_tput);int omap_pm_set_max_dev_wakeup_lat (struct device *req_dev,struct device *dev,long t)
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
Hi Michael,
Quoted 8 lines · On Tuesday 18 January 2011 17:14:37 Michael Jones wrote:
Hi Laurent & Sakari,
On Laurent's media-0006-sensors branch, when compiling with
CONFIG_VIDEO_OMAP3=m, I got the following linking error:ERROR: "
omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko] undefined!
Quoted 6 lines
I can get rid of the error with the patch below. But as always, I
wonder: Why didn't anybody else come across this error? Are you all compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see where someone is using that?And would anything be wrong with the patch below?
Martin Hostettler sent the same patch to linux-omap today ("[PATCH] OMAP: PM:
Export omap_pm_set_min_bus_tput to modules"). See Please see Paul Wamsley's answer on the list.
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
sorry to resurrect this from a month ago...
I've continued to export omap_pm_set_min_bus_tput() to enable building the omap3-isp module, although Paul Wamsley's reply you referred to clearly indicates that this is the wrong approach.
Aren't you also building omap3-isp as a module? How are you guys getting around this?
-Michael
Quoted 16 lines · Laurent Pinchart
Hi Michael,
Quoted 13 lines · On Tuesday 18 January 2011 17:14:37 Michael Jones wrote:
Hi Laurent & Sakari,
On Laurent's media-0006-sensors branch, when compiling with
CONFIG_VIDEO_OMAP3=m, I got the following linking error:ERROR: "
omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko] undefined!I can get rid of the error with the patch below. But as always, I
wonder: Why didn't anybody else come across this error? Are you all compiling with VIDEO_OMAP3=y? Is there a config file somewhere I can see where someone is using that?
Quoted 6 lines
Quoted 1 line
And would anything be wrong with the patch below?
Martin Hostettler sent the same patch to linux-omap today ("[PATCH] OMAP: PM:
Exportomap_pm_set_min_bus_tputto modules"). See Please see Paul Wamsley's answer on the list.
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
Hi Michael,
Quoted 10 lines · On Monday 21 February 2011 15:47:28 Michael Jones wrote:
Hi Laurent,
sorry to resurrect this from a month ago...
I've continued to export
omap_pm_set_min_bus_tput()to enable building the omap3-isp module, although Paul Wamsley's reply you referred to clearly indicates that this is the wrong approach.Aren't you also building omap3-isp as a module? How are you guys getting around this?
On MeeGo omap_pm_set_min_bus_tput() is exported. A quick fix would be to add a callback to board code, or even remove the call completely, as omap_pm_set_min_bus_tput() in a no-op in mainline. A good fix would be to export the functionality of omap_pm_set_min_bus_tput() in a generic API that could be used by drivers.
Signature · 3 lines
Regards, Laurent Pinchart